[PATCH mmc/next 1/3] arm64: dts: samsung,coreprimevelte: add PMIC

Karel Balej posted 3 patches 1 month, 1 week ago
[PATCH mmc/next 1/3] arm64: dts: samsung,coreprimevelte: add PMIC
Posted by Karel Balej 1 month, 1 week ago
Bind power management chip to the samsung,coreprimevelte smartphone.
This enables support for onkey and RTC as well as for regulators two of
which are explicitly bound here to the SD card.

Signed-off-by: Karel Balej <balejk@matfyz.cz>
---
 .../mmp/pxa1908-samsung-coreprimevelte.dts    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts b/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts
index 47a4f01a7077..240021e7a371 100644
--- a/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts
+++ b/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts
@@ -303,6 +303,28 @@ &twsi1 {
 
 &twsi2 {
 	status = "okay";
+
+	pmic@30 {
+		compatible = "marvell,88pm886-a1";
+		reg = <0x30>;
+		interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-parent = <&gic>;
+		wakeup-source;
+
+		regulators {
+			ldo6: ldo6 {
+				regulator-boot-on;
+				regulator-min-microvolt = <1200000>;
+				regulator-max-microvolt = <3300000>;
+			};
+
+			ldo14: ldo14 {
+				regulator-boot-on;
+				regulator-min-microvolt = <1200000>;
+				regulator-max-microvolt = <3300000>;
+			};
+		};
+	};
 };
 
 &twsi3 {
@@ -328,4 +350,6 @@ &sdh0 {
 	cd-inverted;
 	bus-width = <4>;
 	wp-inverted;
+	vmmc-supply = <&ldo14>;
+	vqmmc-supply = <&ldo6>;
 };
-- 
2.50.1
Re: [PATCH mmc/next 1/3] arm64: dts: samsung,coreprimevelte: add PMIC
Posted by Duje Mihanović 1 month, 1 week ago
On Sunday, 24 August 2025 12:53:43 Central European Summer Time Karel Balej 
wrote:
>  &twsi2 {
>  	status = "okay";
> +
> +	pmic@30 {
> +		compatible = "marvell,88pm886-a1";
> +		reg = <0x30>;
> +		interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>;

Use GIC_SPI instead of 0 here.

> +		interrupt-parent = <&gic>;

Drop, root node already uses the GIC as the interrupt parent.

Regards,
--
Duje
Re: [PATCH mmc/next 1/3] arm64: dts: samsung,coreprimevelte: add PMIC
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On 24/08/2025 12:53, Karel Balej wrote:
> Bind power management chip to the samsung,coreprimevelte smartphone.
> This enables support for onkey and RTC as well as for regulators two of
> which are explicitly bound here to the SD card.


Your patches have confusing mmc/next prefix. This is a SoC patchset, not
mmc.

> 
> Signed-off-by: Karel Balej <balejk@matfyz.cz>

Best regards,
Krzysztof