drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps

[PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps

Posted by Kavithesh A.S 1 month, 1 week ago

Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.

This is my first patch submission to the kernel, feedback is welcome

Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
---
 drivers/gpu/drm/amd/display/dc/dc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index 59c077561..06f05979b 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -234,6 +234,7 @@ struct lut3d_caps {
  * @ogam_ram: programmable out gamma LUT
  * @ocsc: output color space conversion matrix
  * @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
+ * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
  * @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
  * instance
  * @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
-- 
2.43.0

Re: [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps

Posted by Alex Deucher 1 month, 1 week ago

Applied.  Thanks!

Alex

On Sat, Aug 23, 2025 at 4:25 PM Kavithesh A.S <kavitheshnitt@gmail.com> wrote:
>
> Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.
>
> This is my first patch submission to the kernel, feedback is welcome
>
> Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dc.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 59c077561..06f05979b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -234,6 +234,7 @@ struct lut3d_caps {
>   * @ogam_ram: programmable out gamma LUT
>   * @ocsc: output color space conversion matrix
>   * @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
> + * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
>   * @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
>   * instance
>   * @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
> --
> 2.43.0

Re: [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps

Posted by Melissa Wen 1 month, 1 week ago


On 27/08/2025 17:02, Alex Deucher wrote:
> Applied.  Thanks!
>
> Alex
>
> On Sat, Aug 23, 2025 at 4:25 PM Kavithesh A.S <kavitheshnitt@gmail.com> wrote:
>> Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.
>>
>> This is my first patch submission to the kernel, feedback is welcome
>>
>> Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
>> ---
>>   drivers/gpu/drm/amd/display/dc/dc.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
>> index 59c077561..06f05979b 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc.h
>> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
>> @@ -234,6 +234,7 @@ struct lut3d_caps {
>>    * @ogam_ram: programmable out gamma LUT
>>    * @ocsc: output color space conversion matrix
>>    * @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
>> + * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
A bit late to comment, but I think you should keep the "always assumes a 
preceding shaper LUT" part.
This info is still very useful and links shaper LUT caps to this attribute.

Melissa

>>    * @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
>>    * instance
>>    * @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
>> --
>> 2.43.0

Re: [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps

Posted by Alex Deucher 1 month, 1 week ago

On Wed, Aug 27, 2025 at 4:10 PM Melissa Wen <mwen@igalia.com> wrote:
>
>
>
> On 27/08/2025 17:02, Alex Deucher wrote:
> > Applied.  Thanks!
> >
> > Alex
> >
> > On Sat, Aug 23, 2025 at 4:25 PM Kavithesh A.S <kavitheshnitt@gmail.com> wrote:
> >> Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.
> >>
> >> This is my first patch submission to the kernel, feedback is welcome
> >>
> >> Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
> >> ---
> >>   drivers/gpu/drm/amd/display/dc/dc.h | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> >> index 59c077561..06f05979b 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> >> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> >> @@ -234,6 +234,7 @@ struct lut3d_caps {
> >>    * @ogam_ram: programmable out gamma LUT
> >>    * @ocsc: output color space conversion matrix
> >>    * @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
> >> + * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
> A bit late to comment, but I think you should keep the "always assumes a
> preceding shaper LUT" part.
> This info is still very useful and links shaper LUT caps to this attribute.

I'll add that before I push it.

Alex

>
> Melissa
>
> >>    * @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
> >>    * instance
> >>    * @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
> >> --
> >> 2.43.0
>