kselftest: mm: fix typos in test_vmalloc.sh

[PATCH] kselftest: mm: fix typos in test_vmalloc.sh

Posted by ally heev 5 months, 2 weeks ago

Signed-off-by: ally heev <allyheev@gmail.com>
---
 tools/testing/selftests/mm/test_vmalloc.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh
index d73b846736f1..d39096723fca 100755
--- a/tools/testing/selftests/mm/test_vmalloc.sh
+++ b/tools/testing/selftests/mm/test_vmalloc.sh
@@ -47,14 +47,14 @@ check_test_requirements()
 	fi
 }
 
-run_perfformance_check()
+run_performance_check()
 {
 	echo "Run performance tests to evaluate how fast vmalloc allocation is."
 	echo "It runs all test cases on one single CPU with sequential order."
 
 	modprobe $DRIVER $PERF_PARAM > /dev/null 2>&1
 	echo "Done."
-	echo "Ccheck the kernel message buffer to see the summary."
+	echo "Check the kernel message buffer to see the summary."
 }
 
 run_stability_check()
@@ -160,7 +160,7 @@ function run_test()
 		usage
 	else
 		if [[ "$1" = "performance" ]]; then
-			run_perfformance_check
+			run_performance_check
 		elif [[ "$1" = "stress" ]]; then
 			run_stability_check
 		elif [[ "$1" = "smoke" ]]; then
-- 
2.34.1

Re: [PATCH] kselftest: mm: fix typos in test_vmalloc.sh

Posted by Uladzislau Rezki 5 months, 2 weeks ago

On Sat, Aug 23, 2025 at 10:32:08PM +0530, ally heev wrote:
> Signed-off-by: ally heev <allyheev@gmail.com>
> ---
>  tools/testing/selftests/mm/test_vmalloc.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh
> index d73b846736f1..d39096723fca 100755
> --- a/tools/testing/selftests/mm/test_vmalloc.sh
> +++ b/tools/testing/selftests/mm/test_vmalloc.sh
> @@ -47,14 +47,14 @@ check_test_requirements()
>  	fi
>  }
>  
> -run_perfformance_check()
> +run_performance_check()
>  {
>  	echo "Run performance tests to evaluate how fast vmalloc allocation is."
>  	echo "It runs all test cases on one single CPU with sequential order."
>  
>  	modprobe $DRIVER $PERF_PARAM > /dev/null 2>&1
>  	echo "Done."
> -	echo "Ccheck the kernel message buffer to see the summary."
> +	echo "Check the kernel message buffer to see the summary."
>  }
>  
>  run_stability_check()
> @@ -160,7 +160,7 @@ function run_test()
>  		usage
>  	else
>  		if [[ "$1" = "performance" ]]; then
> -			run_perfformance_check
> +			run_performance_check
>  		elif [[ "$1" = "stress" ]]; then
>  			run_stability_check
>  		elif [[ "$1" = "smoke" ]]; then
> -- 
> 2.34.1
> 
> 
./scripts/checkpatch.pl ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch
WARNING: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 24 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Can you add a commit message?

Thank you!

--
Uladzislau Rezki

Re: [PATCH] kselftest: mm: fix typos in test_vmalloc.sh

Posted by Andrew Morton 5 months, 2 weeks ago

On Sun, 24 Aug 2025 08:53:26 +0200 Uladzislau Rezki <urezki@gmail.com> wrote:

> >  run_stability_check()
> > @@ -160,7 +160,7 @@ function run_test()
> >  		usage
> >  	else
> >  		if [[ "$1" = "performance" ]]; then
> > -			run_perfformance_check
> > +			run_performance_check
> >  		elif [[ "$1" = "stress" ]]; then
> >  			run_stability_check
> >  		elif [[ "$1" = "smoke" ]]; then
> > -- 
> > 2.34.1
> > 
> > 
> ./scripts/checkpatch.pl ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch
> WARNING: Missing commit description - Add an appropriate one
> 
> total: 0 errors, 1 warnings, 24 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch has style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> Can you add a commit message?

A changelog would be identical to the subject.  checkpatch is being a
bit excessive here.

Oh well, I'll add the obvious text.

Re: [PATCH] kselftest: mm: fix typos in test_vmalloc.sh

Posted by ally heev 5 months, 2 weeks ago

> A changelog would be identical to the subject.  checkpatch is being a
> bit excessive here.

Yes. Hence omitted it


On Mon, Aug 25, 2025 at 5:47 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Sun, 24 Aug 2025 08:53:26 +0200 Uladzislau Rezki <urezki@gmail.com> wrote:
>
> > >  run_stability_check()
> > > @@ -160,7 +160,7 @@ function run_test()
> > >             usage
> > >     else
> > >             if [[ "$1" = "performance" ]]; then
> > > -                   run_perfformance_check
> > > +                   run_performance_check
> > >             elif [[ "$1" = "stress" ]]; then
> > >                     run_stability_check
> > >             elif [[ "$1" = "smoke" ]]; then
> > > --
> > > 2.34.1
> > >
> > >
> > ./scripts/checkpatch.pl ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch
> > WARNING: Missing commit description - Add an appropriate one
> >
> > total: 0 errors, 1 warnings, 24 lines checked
> >
> > NOTE: For some of the reported defects, checkpatch may be able to
> >       mechanically convert to the typical style using --fix or --fix-inplace.
> >
> > ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch has style problems, please review.
> >
> > NOTE: If any of the errors are false positives, please report
> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> >
> > Can you add a commit message?
>
> A changelog would be identical to the subject.  checkpatch is being a
> bit excessive here.
>
> Oh well, I'll add the obvious text.