[patch V2 10/37] entry: Cleanup header

Thomas Gleixner posted 37 patches 1 month, 1 week ago
There is a newer version of this series
[patch V2 10/37] entry: Cleanup header
Posted by Thomas Gleixner 1 month, 1 week ago
From: Thomas Gleixner <tglx@linutronix.de>

Cleanup the include ordering, kernel-doc and other trivialities before
making further changes.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>

---
 include/linux/entry-common.h     |    8 ++++----
 include/linux/irq-entry-common.h |    2 ++
 2 files changed, 6 insertions(+), 4 deletions(-)
---
--- a/include/linux/entry-common.h
+++ b/include/linux/entry-common.h
@@ -3,11 +3,11 @@
 #define __LINUX_ENTRYCOMMON_H
 
 #include <linux/irq-entry-common.h>
+#include <linux/livepatch.h>
 #include <linux/ptrace.h>
+#include <linux/resume_user_mode.h>
 #include <linux/seccomp.h>
 #include <linux/sched.h>
-#include <linux/livepatch.h>
-#include <linux/resume_user_mode.h>
 
 #include <asm/entry-common.h>
 #include <asm/syscall.h>
@@ -37,6 +37,7 @@
 				 SYSCALL_WORK_SYSCALL_AUDIT |		\
 				 SYSCALL_WORK_SYSCALL_USER_DISPATCH |	\
 				 ARCH_SYSCALL_WORK_ENTER)
+
 #define SYSCALL_WORK_EXIT	(SYSCALL_WORK_SYSCALL_TRACEPOINT |	\
 				 SYSCALL_WORK_SYSCALL_TRACE |		\
 				 SYSCALL_WORK_SYSCALL_AUDIT |		\
@@ -61,8 +62,7 @@
  */
 void syscall_enter_from_user_mode_prepare(struct pt_regs *regs);
 
-long syscall_trace_enter(struct pt_regs *regs, long syscall,
-			 unsigned long work);
+long syscall_trace_enter(struct pt_regs *regs, long syscall, unsigned long work);
 
 /**
  * syscall_enter_from_user_mode_work - Check and handle work before invoking
--- a/include/linux/irq-entry-common.h
+++ b/include/linux/irq-entry-common.h
@@ -68,6 +68,7 @@ static __always_inline bool arch_in_rcu_
 
 /**
  * enter_from_user_mode - Establish state when coming from user mode
+ * @regs:	Pointer to currents pt_regs
  *
  * Syscall/interrupt entry disables interrupts, but user mode is traced as
  * interrupts enabled. Also with NO_HZ_FULL RCU might be idle.
@@ -357,6 +358,7 @@ irqentry_state_t noinstr irqentry_enter(
  * Conditional reschedule with additional sanity checks.
  */
 void raw_irqentry_exit_cond_resched(void);
+
 #ifdef CONFIG_PREEMPT_DYNAMIC
 #if defined(CONFIG_HAVE_PREEMPT_DYNAMIC_CALL)
 #define irqentry_exit_cond_resched_dynamic_enabled	raw_irqentry_exit_cond_resched
Re: [patch V2 10/37] entry: Cleanup header
Posted by Mathieu Desnoyers 1 month, 1 week ago
On 2025-08-23 12:39, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Cleanup the include ordering, kernel-doc and other trivialities before
> making further changes.

Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> 
> ---
>   include/linux/entry-common.h     |    8 ++++----
>   include/linux/irq-entry-common.h |    2 ++
>   2 files changed, 6 insertions(+), 4 deletions(-)
> ---
> --- a/include/linux/entry-common.h
> +++ b/include/linux/entry-common.h
> @@ -3,11 +3,11 @@
>   #define __LINUX_ENTRYCOMMON_H
>   
>   #include <linux/irq-entry-common.h>
> +#include <linux/livepatch.h>
>   #include <linux/ptrace.h>
> +#include <linux/resume_user_mode.h>
>   #include <linux/seccomp.h>
>   #include <linux/sched.h>
> -#include <linux/livepatch.h>
> -#include <linux/resume_user_mode.h>
>   
>   #include <asm/entry-common.h>
>   #include <asm/syscall.h>
> @@ -37,6 +37,7 @@
>   				 SYSCALL_WORK_SYSCALL_AUDIT |		\
>   				 SYSCALL_WORK_SYSCALL_USER_DISPATCH |	\
>   				 ARCH_SYSCALL_WORK_ENTER)
> +
>   #define SYSCALL_WORK_EXIT	(SYSCALL_WORK_SYSCALL_TRACEPOINT |	\
>   				 SYSCALL_WORK_SYSCALL_TRACE |		\
>   				 SYSCALL_WORK_SYSCALL_AUDIT |		\
> @@ -61,8 +62,7 @@
>    */
>   void syscall_enter_from_user_mode_prepare(struct pt_regs *regs);
>   
> -long syscall_trace_enter(struct pt_regs *regs, long syscall,
> -			 unsigned long work);
> +long syscall_trace_enter(struct pt_regs *regs, long syscall, unsigned long work);
>   
>   /**
>    * syscall_enter_from_user_mode_work - Check and handle work before invoking
> --- a/include/linux/irq-entry-common.h
> +++ b/include/linux/irq-entry-common.h
> @@ -68,6 +68,7 @@ static __always_inline bool arch_in_rcu_
>   
>   /**
>    * enter_from_user_mode - Establish state when coming from user mode
> + * @regs:	Pointer to currents pt_regs
>    *
>    * Syscall/interrupt entry disables interrupts, but user mode is traced as
>    * interrupts enabled. Also with NO_HZ_FULL RCU might be idle.
> @@ -357,6 +358,7 @@ irqentry_state_t noinstr irqentry_enter(
>    * Conditional reschedule with additional sanity checks.
>    */
>   void raw_irqentry_exit_cond_resched(void);
> +
>   #ifdef CONFIG_PREEMPT_DYNAMIC
>   #if defined(CONFIG_HAVE_PREEMPT_DYNAMIC_CALL)
>   #define irqentry_exit_cond_resched_dynamic_enabled	raw_irqentry_exit_cond_resched
> 


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com