arm64: dts: apm: storm: Add default GIC address cells

[PATCH] arm64: dts: apm: storm: Add default GIC address cells

Posted by Krzysztof Kozlowski 1 month, 1 week ago

Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:

  apm-storm.dtsi:636.4-639.42: Warning (interrupt_map): /soc/pcie@1f2b0000:interrupt-map:
    Missing property '#address-cells' in node /interrupt-controller@78010000, using 0 as fallback

Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
   the fourth component "parent unit address", which size is defined by
   '#address-cells' of the node pointed to by the interrupt-parent
   component, is not used (=0)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 872093b05ce1..1b9588f7536c 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -103,6 +103,7 @@ xgene_L2_3: l2-cache-3 {
 
 	gic: interrupt-controller@78010000 {
 		compatible = "arm,cortex-a15-gic";
+		#address-cells = <0>;
 		#interrupt-cells = <3>;
 		interrupt-controller;
 		reg = <0x0 0x78010000 0x0 0x1000>,	/* GIC Dist */
-- 
2.48.1

Re: [PATCH] arm64: dts: apm: storm: Add default GIC address cells

Posted by Krzysztof Kozlowski 4 weeks, 1 day ago

On Fri, 22 Aug 2025 15:34:17 +0200, Krzysztof Kozlowski wrote:
> Add missing address-cells 0 to GIC interrupt node to silence W=1
> warning:
> 
>   apm-storm.dtsi:636.4-639.42: Warning (interrupt_map): /soc/pcie@1f2b0000:interrupt-map:
>     Missing property '#address-cells' in node /interrupt-controller@78010000, using 0 as fallback
> 
> Value '0' is correct because:
> 1. GIC interrupt controller does not have children,
> 2. interrupt-map property (in PCI node) consists of five components and
>    the fourth component "parent unit address", which size is defined by
>    '#address-cells' of the node pointed to by the interrupt-parent
>    component, is not used (=0)
> 
> [...]

Applied, thanks!

No one picked these up, so I grabbed them. Please let me know if someone else
wants to take it.

[1/1] arm64: dts: apm: storm: Add default GIC address cells
      https://git.kernel.org/krzk/linux-dt/c/d5cb16361f89e7f60da76c7e9e32c72c49db3e82

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>