[PATCH v3] serial: 8250_core: fix coding style issue

Osama Abdelkader posted 1 patch 1 month, 1 week ago
drivers/tty/serial/8250/8250_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v3] serial: 8250_core: fix coding style issue
Posted by Osama Abdelkader 1 month, 1 week ago
Fix a coding style issue in 8250_core.c:

- Remove redundant NULL initialization of a global pointer

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
v2:
- Dropped extra blank line after gpios declaration
v3:
- Added changelog to commit message
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index feb920c5b2e8..225bb7e4b89c 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
 		serial_unlink_irq_chain(up);
 }
 
-const struct uart_ops *univ8250_port_base_ops = NULL;
+const struct uart_ops *univ8250_port_base_ops;
 struct uart_ops univ8250_port_ops;
 
 static const struct uart_8250_ops univ8250_driver_ops = {
-- 
2.43.0
Re: [PATCH v3] serial: 8250_core: fix coding style issue
Posted by Jiri Slaby 1 month, 1 week ago
On 22. 08. 25, 11:56, Osama Abdelkader wrote:
> Fix a coding style issue in 8250_core.c:
> 
> - Remove redundant NULL initialization of a global pointer
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

FWIW
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>


-- 
js
suse labs