This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards
compatible to the USB3.0 SS(5Gbps). It requires two clocks, named
"phy" and "ref". The required supplies for USB3.1 are named as
vdd075_usb30(0.75v), vdd18_usb30(1.8v).
Add schemas for combo ssphy found on this SoC.
Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
---
.../bindings/phy/samsung,usb3-drd-phy.yaml | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
index f0cfca5736b8..96e5bbb2e42c 100644
--- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
@@ -34,6 +34,7 @@ properties:
- samsung,exynos7870-usbdrd-phy
- samsung,exynos850-usbdrd-phy
- samsung,exynos990-usbdrd-phy
+ - samsung,exynosautov920-usb31drd-combo-ssphy
- samsung,exynosautov920-usbdrd-combo-hsphy
- samsung,exynosautov920-usbdrd-phy
@@ -118,6 +119,12 @@ properties:
vdd18-usb20-supply:
description: 1.8V power supply for the USB 2.0 phy.
+ dvdd075-usb30-supply:
+ description: 0.75V power supply for the USB 3.0 phy.
+
+ vdd18-usb30-supply:
+ description: 1.8V power supply for the USB 3.0 phy.
+
required:
- compatible
- clocks
@@ -227,6 +234,7 @@ allOf:
- samsung,exynos7870-usbdrd-phy
- samsung,exynos850-usbdrd-phy
- samsung,exynos990-usbdrd-phy
+ - samsung,exynosautov920-usb31drd-combo-ssphy
- samsung,exynosautov920-usbdrd-combo-hsphy
- samsung,exynosautov920-usbdrd-phy
then:
@@ -262,6 +270,21 @@ allOf:
properties:
dvdd075-usb20-supply: false
vdd18-usb20-supply: false
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynosautov920-usb31drd-combo-ssphy
+ then:
+ required:
+ - dvdd075-usb30-supply
+ - vdd18-usb30-supply
+
+ else:
+ properties:
+ dvdd075-usb30-supply: false
+ vdd18-usb30-supply: false
unevaluatedProperties: false
--
2.34.1On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: > This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > compatible to the USB3.0 SS(5Gbps). It requires two clocks, named > "phy" and "ref". The required supplies for USB3.1 are named as > vdd075_usb30(0.75v), vdd18_usb30(1.8v). Please do not describe the schema, but hardware. This sentence does not help me in my question further. > > Add schemas for combo ssphy found on this SoC. > > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > --- > .../bindings/phy/samsung,usb3-drd-phy.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > index f0cfca5736b8..96e5bbb2e42c 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > @@ -34,6 +34,7 @@ properties: > - samsung,exynos7870-usbdrd-phy > - samsung,exynos850-usbdrd-phy > - samsung,exynos990-usbdrd-phy > + - samsung,exynosautov920-usb31drd-combo-ssphy > - samsung,exynosautov920-usbdrd-combo-hsphy > - samsung,exynosautov920-usbdrd-phy > > @@ -118,6 +119,12 @@ properties: > vdd18-usb20-supply: > description: 1.8V power supply for the USB 2.0 phy. > > + dvdd075-usb30-supply: > + description: 0.75V power supply for the USB 3.0 phy. > + > + vdd18-usb30-supply: > + description: 1.8V power supply for the USB 3.0 phy. > + > required: > - compatible > - clocks > @@ -227,6 +234,7 @@ allOf: > - samsung,exynos7870-usbdrd-phy > - samsung,exynos850-usbdrd-phy > - samsung,exynos990-usbdrd-phy > + - samsung,exynosautov920-usb31drd-combo-ssphy > - samsung,exynosautov920-usbdrd-combo-hsphy > - samsung,exynosautov920-usbdrd-phy > then: > @@ -262,6 +270,21 @@ allOf: > properties: > dvdd075-usb20-supply: false > vdd18-usb20-supply: false > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynosautov920-usb31drd-combo-ssphy > + then: > + required: > + - dvdd075-usb30-supply > + - vdd18-usb30-supply Why are you adding usb20 and usb30 suffixes to the supplies? These are separate devices, so they do not have both variants at the same time. From this device point of view, the supply is called dvdd075 or vdd18. If you open device datasheet (not SoC datasheet), that's how it will be called, most likely. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 24 August 2025 02:26 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > johan@kernel.org; m.szyprowski@samsung.com; s.nawrocki@samsung.com; > linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo ssphy > > On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: > > This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > > compatible to the USB3.0 SS(5Gbps). It requires two clocks, named > > "phy" and "ref". The required supplies for USB3.1 are named as > > vdd075_usb30(0.75v), vdd18_usb30(1.8v). > > Please do not describe the schema, but hardware. This sentence does not help > me in my question further. This is a combo phy having Synopsys usb20 and usb30 phys (these 2 phys are totally different). One PHY only supports usb2.0 and data rates whereas another one does usb3.1 ssp+ and usb3.1 ssp This patch only explains about usb30 (since these are two different phys) phy and omitted inclusion of usb20 reference (added separate patch for this patch no 3). Hope this is clear. > > > > > Add schemas for combo ssphy found on this SoC. > > > > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > --- > > .../bindings/phy/samsung,usb3-drd-phy.yaml | 23 +++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > index f0cfca5736b8..96e5bbb2e42c 100644 > > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > @@ -34,6 +34,7 @@ properties: > > - samsung,exynos7870-usbdrd-phy > > - samsung,exynos850-usbdrd-phy > > - samsung,exynos990-usbdrd-phy > > + - samsung,exynosautov920-usb31drd-combo-ssphy > > - samsung,exynosautov920-usbdrd-combo-hsphy > > - samsung,exynosautov920-usbdrd-phy > > > > @@ -118,6 +119,12 @@ properties: > > vdd18-usb20-supply: > > description: 1.8V power supply for the USB 2.0 phy. > > > > + dvdd075-usb30-supply: > > + description: 0.75V power supply for the USB 3.0 phy. > > + > > + vdd18-usb30-supply: > > + description: 1.8V power supply for the USB 3.0 phy. > > + > > required: > > - compatible > > - clocks > > @@ -227,6 +234,7 @@ allOf: > > - samsung,exynos7870-usbdrd-phy > > - samsung,exynos850-usbdrd-phy > > - samsung,exynos990-usbdrd-phy > > + - samsung,exynosautov920-usb31drd-combo-ssphy > > - samsung,exynosautov920-usbdrd-combo-hsphy > > - samsung,exynosautov920-usbdrd-phy > > then: > > @@ -262,6 +270,21 @@ allOf: > > properties: > > dvdd075-usb20-supply: false > > vdd18-usb20-supply: false > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - samsung,exynosautov920-usb31drd-combo-ssphy > > + then: > > + required: > > + - dvdd075-usb30-supply > > + - vdd18-usb30-supply > > Why are you adding usb20 and usb30 suffixes to the supplies? These are > separate devices, so they do not have both variants at the same time. This is a combo phy consisting of usb2 and usb3 phys combined. To drive these separate phys, added suffixes for these supplies respectively. Moreover, gs101 is also using similar convention for its usb20 and dp supplies. Added suffix for usb2 and usb3 as per our last communication https://lore.kernel.org/linux-phy/6e1c67d2-9bfa-442a-9d53-8c5970a2a9ef@kernel.org/ > > From this device point of view, the supply is called dvdd075 or vdd18. > If you open device datasheet (not SoC datasheet), that's how it will be called, > most likely. Yes, Agree. In device datasheet, suffixes are not mentioned, but in our board schematic it is mentioned. Let me know your suggestion about adding suffixes? > > Best regards, > Krzysztof Thank you. Regards, Pritam
On 26/08/2025 08:37, Pritam Manohar Sutar wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: 24 August 2025 02:26 PM >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; >> andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; >> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; >> johan@kernel.org; m.szyprowski@samsung.com; s.nawrocki@samsung.com; >> linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- >> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; >> faraz.ata@samsung.com; muhammed.ali@samsung.com; >> selvarasu.g@samsung.com >> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add >> ExynosAutov920 combo ssphy >> >> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: >>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards >>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, named >>> "phy" and "ref". The required supplies for USB3.1 are named as >>> vdd075_usb30(0.75v), vdd18_usb30(1.8v). >> >> Please do not describe the schema, but hardware. This sentence does not help >> me in my question further. > > This is a combo phy having Synopsys usb20 and usb30 phys (these 2 phys are totally different). > One PHY only supports usb2.0 and data rates whereas another one does usb3.1 ssp+ and usb3.1 ssp > > This patch only explains about usb30 (since these are two different phys) phy and omitted inclusion of usb20 reference (added separate patch for this patch no 3). > > Hope this is clear. No. That sentence still explains what schema is doing. BTW, wrap your email correctly. > >> >>> >>> Add schemas for combo ssphy found on this SoC. >>> >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> >>> --- >>> .../bindings/phy/samsung,usb3-drd-phy.yaml | 23 +++++++++++++++++++ >>> 1 file changed, 23 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> index f0cfca5736b8..96e5bbb2e42c 100644 >>> --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml >>> @@ -34,6 +34,7 @@ properties: >>> - samsung,exynos7870-usbdrd-phy >>> - samsung,exynos850-usbdrd-phy >>> - samsung,exynos990-usbdrd-phy >>> + - samsung,exynosautov920-usb31drd-combo-ssphy >>> - samsung,exynosautov920-usbdrd-combo-hsphy >>> - samsung,exynosautov920-usbdrd-phy >>> >>> @@ -118,6 +119,12 @@ properties: >>> vdd18-usb20-supply: >>> description: 1.8V power supply for the USB 2.0 phy. >>> >>> + dvdd075-usb30-supply: >>> + description: 0.75V power supply for the USB 3.0 phy. >>> + >>> + vdd18-usb30-supply: >>> + description: 1.8V power supply for the USB 3.0 phy. >>> + >>> required: >>> - compatible >>> - clocks >>> @@ -227,6 +234,7 @@ allOf: >>> - samsung,exynos7870-usbdrd-phy >>> - samsung,exynos850-usbdrd-phy >>> - samsung,exynos990-usbdrd-phy >>> + - samsung,exynosautov920-usb31drd-combo-ssphy >>> - samsung,exynosautov920-usbdrd-combo-hsphy >>> - samsung,exynosautov920-usbdrd-phy >>> then: >>> @@ -262,6 +270,21 @@ allOf: >>> properties: >>> dvdd075-usb20-supply: false >>> vdd18-usb20-supply: false >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - samsung,exynosautov920-usb31drd-combo-ssphy >>> + then: >>> + required: >>> + - dvdd075-usb30-supply >>> + - vdd18-usb30-supply >> >> Why are you adding usb20 and usb30 suffixes to the supplies? These are >> separate devices, so they do not have both variants at the same time. > > This is a combo phy consisting of usb2 and usb3 phys combined. > To drive these separate phys, added suffixes for these supplies respectively. But they are separate. > > Moreover, gs101 is also using similar convention for its usb20 and dp supplies. > Added suffix for usb2 and usb3 as per our last communication https://lore.kernel.org/linux-phy/6e1c67d2-9bfa-442a-9d53-8c5970a2a9ef@kernel.org/ Then please review patches on the list and help to improve them BEFORE they got merged. I questioned the suffix there, so I really do not understand why did you added it. > >> >> From this device point of view, the supply is called dvdd075 or vdd18. >> If you open device datasheet (not SoC datasheet), that's how it will be called, >> most likely. > > Yes, Agree. In device datasheet, suffixes are not mentioned, but in our board schematic it is mentioned. > Let me know your suggestion about adding suffixes? I already said, multiple times on various discussions. You name these based on how the inputs are called in this device. Best regards, Krzysztof
Hi Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 26 August 2025 02:05 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; . . [snip] . . > >> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > >> add > >> ExynosAutov920 combo ssphy > >> > >> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: > >>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > >>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, named > >>> "phy" and "ref". The required supplies for USB3.1 are named as > >>> vdd075_usb30(0.75v), vdd18_usb30(1.8v). > >> > >> Please do not describe the schema, but hardware. This sentence does > >> not help me in my question further. > > > > This is a combo phy having Synopsys usb20 and usb30 phys (these 2 phys are > totally different). > > One PHY only supports usb2.0 and data rates whereas another one does > > usb3.1 ssp+ and usb3.1 ssp > > > > This patch only explains about usb30 (since these are two different phys) phy > and omitted inclusion of usb20 reference (added separate patch for this patch > no 3). > > > > Hope this is clear. > > No. That sentence still explains what schema is doing. > Ok, let me simplify the commit message further something like below. Anyways, the coverletter contains more details about it. "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy Add schema for combo ssphy found on this SoC. " Please confirm if this looks fine? If so, will reflect the similar commit messages in patch 1 and 3. > BTW, wrap your email correctly. > Sure, thanks for your input. > > > >> > >>> > >>> Add schemas for combo ssphy found on this SoC. > >>> > >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >>> --- > >>> .../bindings/phy/samsung,usb3-drd-phy.yaml | 23 +++++++++++++++++++ > >>> 1 file changed, 23 insertions(+) > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> index f0cfca5736b8..96e5bbb2e42c 100644 > >>> --- > >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yam > >>> +++ l > >>> @@ -34,6 +34,7 @@ properties: > >>> - samsung,exynos7870-usbdrd-phy > >>> - samsung,exynos850-usbdrd-phy > >>> - samsung,exynos990-usbdrd-phy > >>> + - samsung,exynosautov920-usb31drd-combo-ssphy > >>> - samsung,exynosautov920-usbdrd-combo-hsphy > >>> - samsung,exynosautov920-usbdrd-phy > >>> > >>> @@ -118,6 +119,12 @@ properties: > >>> vdd18-usb20-supply: > >>> description: 1.8V power supply for the USB 2.0 phy. > >>> > >>> + dvdd075-usb30-supply: > >>> + description: 0.75V power supply for the USB 3.0 phy. > >>> + > >>> + vdd18-usb30-supply: > >>> + description: 1.8V power supply for the USB 3.0 phy. > >>> + > >>> required: > >>> - compatible > >>> - clocks > >>> @@ -227,6 +234,7 @@ allOf: > >>> - samsung,exynos7870-usbdrd-phy > >>> - samsung,exynos850-usbdrd-phy > >>> - samsung,exynos990-usbdrd-phy > >>> + - samsung,exynosautov920-usb31drd-combo-ssphy > >>> - samsung,exynosautov920-usbdrd-combo-hsphy > >>> - samsung,exynosautov920-usbdrd-phy > >>> then: > >>> @@ -262,6 +270,21 @@ allOf: > >>> properties: > >>> dvdd075-usb20-supply: false > >>> vdd18-usb20-supply: false > >>> + - if: > >>> + properties: > >>> + compatible: > >>> + contains: > >>> + enum: > >>> + - samsung,exynosautov920-usb31drd-combo-ssphy > >>> + then: > >>> + required: > >>> + - dvdd075-usb30-supply > >>> + - vdd18-usb30-supply > >> > >> Why are you adding usb20 and usb30 suffixes to the supplies? These > >> are separate devices, so they do not have both variants at the same time. > > > > This is a combo phy consisting of usb2 and usb3 phys combined. > > To drive these separate phys, added suffixes for these supplies respectively. > > But they are separate. > > > > > Moreover, gs101 is also using similar convention for its usb20 and dp supplies. > > Added suffix for usb2 and usb3 as per our last communication > > https://lore.kernel.org/linux-phy/6e1c67d2-9bfa-442a-9d53-8c5970a2a9ef > > @kernel.org/ > > Then please review patches on the list and help to improve them BEFORE they > got merged. > > I questioned the suffix there, so I really do not understand why did you added it. > > > > >> > >> From this device point of view, the supply is called dvdd075 or vdd18. > >> If you open device datasheet (not SoC datasheet), that's how it will > >> be called, most likely. > > > > Yes, Agree. In device datasheet, suffixes are not mentioned, but in our board > schematic it is mentioned. > > Let me know your suggestion about adding suffixes? > > I already said, multiple times on various discussions. You name these based on > how the inputs are called in this device. Ok, will remove suffixes from supplies. And will add following supplies dvdd, vdd33 and vdd18. Let me know, because of above changes, should be removing your 'reviewed-by' tag from patch 1 and 3. > > Best regards, > Krzysztof Thank you. Regards, Pritam
On 29/08/2025 12:15, Pritam Manohar Sutar wrote: > Hi Krzysztof > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: 26 August 2025 02:05 PM >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > . > . > [snip] > . > . >>>> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: >>>> add >>>> ExynosAutov920 combo ssphy >>>> >>>> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: >>>>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards >>>>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, named >>>>> "phy" and "ref". The required supplies for USB3.1 are named as >>>>> vdd075_usb30(0.75v), vdd18_usb30(1.8v). >>>> >>>> Please do not describe the schema, but hardware. This sentence does >>>> not help me in my question further. >>> >>> This is a combo phy having Synopsys usb20 and usb30 phys (these 2 phys are >> totally different). >>> One PHY only supports usb2.0 and data rates whereas another one does >>> usb3.1 ssp+ and usb3.1 ssp >>> >>> This patch only explains about usb30 (since these are two different phys) phy >> and omitted inclusion of usb20 reference (added separate patch for this patch >> no 3). >>> >>> Hope this is clear. >> >> No. That sentence still explains what schema is doing. >> > > Ok, let me simplify the commit message further something like below. > Anyways, the coverletter contains more details about it. > > "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy > > Add schema for combo ssphy found on this SoC. > " > > Please confirm if this looks fine? > If so, will reflect the similar commit messages in patch 1 and 3. Please read my first comment again. I do not see how does this satisfy hardware explanation. Best regards, Krzysztof
Hi Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Friday, August 29, 2025 4:07 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > johan@kernel.org; m.szyprowski@samsung.com; > s.nawrocki@samsung.com; linux-phy@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; > rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo ssphy > > On 29/08/2025 12:15, Pritam Manohar Sutar wrote: > > Hi Krzysztof > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: 26 August 2025 02:05 PM > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > > . > > . > > [snip] > > . > > . > >>>> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > >>>> add > >>>> ExynosAutov920 combo ssphy > >>>> > >>>> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: > >>>>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > >>>>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, named > >>>>> "phy" and "ref". The required supplies for USB3.1 are named as > >>>>> vdd075_usb30(0.75v), vdd18_usb30(1.8v). > >>>> > >>>> Please do not describe the schema, but hardware. This sentence does > >>>> not help me in my question further. > >>> > >>> This is a combo phy having Synopsys usb20 and usb30 phys (these 2 > >>> phys are > >> totally different). > >>> One PHY only supports usb2.0 and data rates whereas another one does > >>> usb3.1 ssp+ and usb3.1 ssp > >>> > >>> This patch only explains about usb30 (since these are two different > >>> phys) phy > >> and omitted inclusion of usb20 reference (added separate patch for > >> this patch no 3). > >>> > >>> Hope this is clear. > >> > >> No. That sentence still explains what schema is doing. > >> > > > > Ok, let me simplify the commit message further something like below. > > Anyways, the coverletter contains more details about it. > > > > "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo > > ssphy > > > > Add schema for combo ssphy found on this SoC. > > " > > > > Please confirm if this looks fine? > > If so, will reflect the similar commit messages in patch 1 and 3. > > Please read my first comment again. I do not see how does this satisfy > hardware explanation. > Just went through the conversation above, until what extent hardware description need to be explain in the commit? Do we have any guideline for the same? Could you please help with an example from previous any commit or some other patches? I understand that mentioning, “two clocks, two supplies etc" are part of schema, one may or may not capture that in the commit. However mentioning, “this hardware (SoC) contain a combo PHY which supports usb3.1 and usb3.0" is not ok? > Best regards, > Krzysztof
On 29/08/2025 12:58, Alim Akhtar wrote: > Hi Krzysztof > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: Friday, August 29, 2025 4:07 PM >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; >> andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; >> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; >> johan@kernel.org; m.szyprowski@samsung.com; >> s.nawrocki@samsung.com; linux-phy@lists.infradead.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; >> rosa.pila@samsung.com; dev.tailor@samsung.com; >> faraz.ata@samsung.com; muhammed.ali@samsung.com; >> selvarasu.g@samsung.com >> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add >> ExynosAutov920 combo ssphy >> >> On 29/08/2025 12:15, Pritam Manohar Sutar wrote: >>> Hi Krzysztof >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski <krzk@kernel.org> >>>> Sent: 26 August 2025 02:05 PM >>>> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >>>> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; >>> . >>> . >>> [snip] >>> . >>> . >>>>>> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: >>>>>> add >>>>>> ExynosAutov920 combo ssphy >>>>>> >>>>>> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: >>>>>>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards >>>>>>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, named >>>>>>> "phy" and "ref". The required supplies for USB3.1 are named as >>>>>>> vdd075_usb30(0.75v), vdd18_usb30(1.8v). >>>>>> >>>>>> Please do not describe the schema, but hardware. This sentence does >>>>>> not help me in my question further. >>>>> >>>>> This is a combo phy having Synopsys usb20 and usb30 phys (these 2 >>>>> phys are >>>> totally different). >>>>> One PHY only supports usb2.0 and data rates whereas another one does >>>>> usb3.1 ssp+ and usb3.1 ssp >>>>> >>>>> This patch only explains about usb30 (since these are two different >>>>> phys) phy >>>> and omitted inclusion of usb20 reference (added separate patch for >>>> this patch no 3). >>>>> >>>>> Hope this is clear. >>>> >>>> No. That sentence still explains what schema is doing. >>>> >>> >>> Ok, let me simplify the commit message further something like below. >>> Anyways, the coverletter contains more details about it. >>> >>> "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo >>> ssphy >>> >>> Add schema for combo ssphy found on this SoC. >>> " >>> >>> Please confirm if this looks fine? >>> If so, will reflect the similar commit messages in patch 1 and 3. >> >> Please read my first comment again. I do not see how does this satisfy >> hardware explanation. >> > Just went through the conversation above, > until what extent hardware description need to be explain in the commit? > Do we have any guideline for the same? > Could you please help with an example from previous any commit or some other patches? > I understand that mentioning, “two clocks, two supplies etc" are part of schema, > one may or may not capture that in the commit. > However mentioning, “this hardware (SoC) contain a combo PHY which supports usb3.1 and usb3.0" is not ok? Maybe that's just language, but to me the commit msg did not describe hardware after first sentence, but said what schema requires (some clocks and supplies). Other examples: 00399bbe02d2bb6fd8d6eb90573ec305616449f4 e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb and here another anti-pattern: 23f793850e9ee7390584c0809f085d6c88de7d3f (and before you ask why above carries my Rb tag, then note that Samsung's revenue is around 220 billion USD, so for sure it has a lot, really a lot of resources to review patches internally and improve their quality before posting). Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Sent: 29 August 2025 05:33 PM > To: 'Krzysztof Kozlowski' <krzk@kernel.org>; 'Alim Akhtar' > <alim.akhtar@samsung.com> > Cc: 'vkoul@kernel.org' <vkoul@kernel.org>; 'kishon@kernel.org' > <kishon@kernel.org>; 'robh@kernel.org' <robh@kernel.org>; > 'krzk+dt@kernel.org' <krzk+dt@kernel.org>; 'conor+dt@kernel.org' > <conor+dt@kernel.org>; 'andre.draszik@linaro.org' > <andre.draszik@linaro.org>; 'peter.griffin@linaro.org' > <peter.griffin@linaro.org>; 'kauschluss@disroot.org' <kauschluss@disroot.org>; > 'ivo.ivanov.ivanov1@gmail.com' <ivo.ivanov.ivanov1@gmail.com>; > 'igor.belwon@mentallysanemainliners.org' > <igor.belwon@mentallysanemainliners.org>; 'johan@kernel.org' > <johan@kernel.org>; 'm.szyprowski@samsung.com' > <m.szyprowski@samsung.com>; 's.nawrocki@samsung.com' > <s.nawrocki@samsung.com>; 'linux-phy@lists.infradead.org' <linux- > phy@lists.infradead.org>; 'devicetree@vger.kernel.org' > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' <linux-arm- > kernel@lists.infradead.org>; 'linux-samsung-soc@vger.kernel.org' <linux- > samsung-soc@vger.kernel.org>; 'rosa.pila@samsung.com' > <rosa.pila@samsung.com>; 'dev.tailor@samsung.com' > <dev.tailor@samsung.com>; 'faraz.ata@samsung.com' > <faraz.ata@samsung.com>; 'muhammed.ali@samsung.com' > <muhammed.ali@samsung.com>; 'selvarasu.g@samsung.com' > <selvarasu.g@samsung.com> > Subject: RE: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo ssphy > > Hi Krzysztof, > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzk@kernel.org> > > Sent: 29 August 2025 04:56 PM > > To: Alim Akhtar <alim.akhtar@samsung.com>; 'Pritam Manohar Sutar' > > <pritam.sutar@samsung.com> > > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > > krzk+dt@kernel.org; conor+dt@kernel.org; andre.draszik@linaro.org; > > peter.griffin@linaro.org; kauschluss@disroot.org; > > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > > johan@kernel.org; m.szyprowski@samsung.com; s.nawrocki@samsung.com; > > linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; > > dev.tailor@samsung.com; faraz.ata@samsung.com; > > muhammed.ali@samsung.com; selvarasu.g@samsung.com > > Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > > add > > ExynosAutov920 combo ssphy > > > > On 29/08/2025 12:58, Alim Akhtar wrote: > > > Hi Krzysztof > > > > > >> -----Original Message----- > > >> From: Krzysztof Kozlowski <krzk@kernel.org> > > >> Sent: Friday, August 29, 2025 4:07 PM > > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > > >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > > >> andre.draszik@linaro.org; peter.griffin@linaro.org; > > >> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > > >> igor.belwon@mentallysanemainliners.org; > > >> johan@kernel.org; m.szyprowski@samsung.com; > s.nawrocki@samsung.com; > > >> linux-phy@lists.infradead.org; devicetree@vger.kernel.org; > > >> linux-kernel@vger.kernel.org; linux-arm- > > >> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; > > >> rosa.pila@samsung.com; dev.tailor@samsung.com; > > faraz.ata@samsung.com; > > >> muhammed.ali@samsung.com; selvarasu.g@samsung.com > > >> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > > >> add > > >> ExynosAutov920 combo ssphy > > >> > > >> On 29/08/2025 12:15, Pritam Manohar Sutar wrote: > > >>> Hi Krzysztof > > >>> > > >>>> -----Original Message----- > > >>>> From: Krzysztof Kozlowski <krzk@kernel.org> > > >>>> Sent: 26 August 2025 02:05 PM > > >>>> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > >>>> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > > >>> . > > >>> . > > >>> [snip] > > >>> . > > >>> . > > >>>>>> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > > >>>>>> add > > >>>>>> ExynosAutov920 combo ssphy > > >>>>>> > > >>>>>> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar > wrote: > > >>>>>>> This phy supports USB3.1 SSP+(10Gbps) protocol and is > > >>>>>>> backwards compatible to the USB3.0 SS(5Gbps). It requires two > > >>>>>>> clocks, named "phy" and "ref". The required supplies for > > >>>>>>> USB3.1 are named as vdd075_usb30(0.75v), vdd18_usb30(1.8v). > > >>>>>> > > >>>>>> Please do not describe the schema, but hardware. This sentence > > >>>>>> does not help me in my question further. > > >>>>> > > >>>>> This is a combo phy having Synopsys usb20 and usb30 phys (these > > >>>>> 2 phys are > > >>>> totally different). > > >>>>> One PHY only supports usb2.0 and data rates whereas another one > > >>>>> does > > >>>>> usb3.1 ssp+ and usb3.1 ssp > > >>>>> > > >>>>> This patch only explains about usb30 (since these are two > > >>>>> different > > >>>>> phys) phy > > >>>> and omitted inclusion of usb20 reference (added separate patch > > >>>> for this patch no 3). > > >>>>> > > >>>>> Hope this is clear. > > >>>> > > >>>> No. That sentence still explains what schema is doing. > > >>>> > > >>> > > >>> Ok, let me simplify the commit message further something like below. > > >>> Anyways, the coverletter contains more details about it. > > >>> > > >>> "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo > > >>> ssphy > > >>> > > >>> Add schema for combo ssphy found on this SoC. > > >>> " > > >>> > > >>> Please confirm if this looks fine? > > >>> If so, will reflect the similar commit messages in patch 1 and 3. > > >> > > >> Please read my first comment again. I do not see how does this > > >> satisfy hardware explanation. > > >> > > > Just went through the conversation above, until what extent hardware > > > description need to be explain in the commit? > > > Do we have any guideline for the same? > > > Could you please help with an example from previous any commit or > > > some > > other patches? > > > I understand that mentioning, “two clocks, two supplies etc" are > > > part of schema, one may or may not capture that in the commit. > > > However mentioning, “this hardware (SoC) contain a combo PHY which > > supports usb3.1 and usb3.0" is not ok? > > > > > > Maybe that's just language, but to me the commit msg did not describe > > hardware after first sentence, but said what schema requires (some > > clocks and supplies). Other examples: > > 00399bbe02d2bb6fd8d6eb90573ec305616449f4 > > e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb > > > > Thank you for the pointers, will refer the examples and update the commit > messages accordingly. Can you please confirm, if below message looks fine? " dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy The USBDRD31 5nm controller consists of Synopsys USB20 phy and USB31 SSP+ combophy. Document support for the USB31 SSP+ phy found on combophy of the ExynosAutov920 SoC. " > > > and here another anti-pattern: > > 23f793850e9ee7390584c0809f085d6c88de7d3f > > > > (and before you ask why above carries my Rb tag, then note that > > Samsung's revenue is around 220 billion USD, so for sure it has a lot, > > really a lot of resources to review patches internally and improve > > their quality before posting). > > > > Best regards, > > Krzysztof > > Thank you. > > Regards, > Pritam Thank you. Regards, Pritam
On 02/09/2025 14:12, Pritam Manohar Sutar wrote: >>> >> >> Thank you for the pointers, will refer the examples and update the commit >> messages accordingly. > > Can you please confirm, if below message looks fine? > > " > dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy > > The USBDRD31 5nm controller consists of Synopsys USB20 phy and > USB31 SSP+ combophy. Document support for the USB31 SSP+ phy found > on combophy of the ExynosAutov920 SoC. Yes, that's fine. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 29 August 2025 04:56 PM > To: Alim Akhtar <alim.akhtar@samsung.com>; 'Pritam Manohar Sutar' > <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; andre.draszik@linaro.org; > peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > johan@kernel.org; m.szyprowski@samsung.com; s.nawrocki@samsung.com; > linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo ssphy > > On 29/08/2025 12:58, Alim Akhtar wrote: > > Hi Krzysztof > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: Friday, August 29, 2025 4:07 PM > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > >> andre.draszik@linaro.org; peter.griffin@linaro.org; > >> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > >> igor.belwon@mentallysanemainliners.org; > >> johan@kernel.org; m.szyprowski@samsung.com; s.nawrocki@samsung.com; > >> linux-phy@lists.infradead.org; devicetree@vger.kernel.org; > >> linux-kernel@vger.kernel.org; linux-arm- kernel@lists.infradead.org; > >> linux-samsung-soc@vger.kernel.org; > >> rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; > >> muhammed.ali@samsung.com; selvarasu.g@samsung.com > >> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > >> add > >> ExynosAutov920 combo ssphy > >> > >> On 29/08/2025 12:15, Pritam Manohar Sutar wrote: > >>> Hi Krzysztof > >>> > >>>> -----Original Message----- > >>>> From: Krzysztof Kozlowski <krzk@kernel.org> > >>>> Sent: 26 August 2025 02:05 PM > >>>> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >>>> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > >>> . > >>> . > >>> [snip] > >>> . > >>> . > >>>>>> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > >>>>>> add > >>>>>> ExynosAutov920 combo ssphy > >>>>>> > >>>>>> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: > >>>>>>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > >>>>>>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, > >>>>>>> named "phy" and "ref". The required supplies for USB3.1 are > >>>>>>> named as vdd075_usb30(0.75v), vdd18_usb30(1.8v). > >>>>>> > >>>>>> Please do not describe the schema, but hardware. This sentence > >>>>>> does not help me in my question further. > >>>>> > >>>>> This is a combo phy having Synopsys usb20 and usb30 phys (these 2 > >>>>> phys are > >>>> totally different). > >>>>> One PHY only supports usb2.0 and data rates whereas another one > >>>>> does > >>>>> usb3.1 ssp+ and usb3.1 ssp > >>>>> > >>>>> This patch only explains about usb30 (since these are two > >>>>> different > >>>>> phys) phy > >>>> and omitted inclusion of usb20 reference (added separate patch for > >>>> this patch no 3). > >>>>> > >>>>> Hope this is clear. > >>>> > >>>> No. That sentence still explains what schema is doing. > >>>> > >>> > >>> Ok, let me simplify the commit message further something like below. > >>> Anyways, the coverletter contains more details about it. > >>> > >>> "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo > >>> ssphy > >>> > >>> Add schema for combo ssphy found on this SoC. > >>> " > >>> > >>> Please confirm if this looks fine? > >>> If so, will reflect the similar commit messages in patch 1 and 3. > >> > >> Please read my first comment again. I do not see how does this > >> satisfy hardware explanation. > >> > > Just went through the conversation above, until what extent hardware > > description need to be explain in the commit? > > Do we have any guideline for the same? > > Could you please help with an example from previous any commit or some > other patches? > > I understand that mentioning, “two clocks, two supplies etc" are part > > of schema, one may or may not capture that in the commit. > > However mentioning, “this hardware (SoC) contain a combo PHY which > supports usb3.1 and usb3.0" is not ok? > > > Maybe that's just language, but to me the commit msg did not describe > hardware after first sentence, but said what schema requires (some > clocks and supplies). Other examples: > 00399bbe02d2bb6fd8d6eb90573ec305616449f4 > e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb > Thank you for the pointers, will refer the examples and update the commit messages accordingly. > and here another anti-pattern: > 23f793850e9ee7390584c0809f085d6c88de7d3f > > (and before you ask why above carries my Rb tag, then note that > Samsung's revenue is around 220 billion USD, so for sure it has a lot, > really a lot of resources to review patches internally and improve their > quality before posting). > > Best regards, > Krzysztof Thank you. Regards, Pritam
Hi Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Friday, August 29, 2025 4:56 PM > To: Alim Akhtar <alim.akhtar@samsung.com>; 'Pritam Manohar Sutar' > <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; andre.draszik@linaro.org; > [Snip] > >>>>>> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar > wrote: > >>>>>>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > >>>>>>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, > >>>>>>> named "phy" and "ref". The required supplies for USB3.1 are > >>>>>>> named as vdd075_usb30(0.75v), vdd18_usb30(1.8v). > >>>>>> > >>>>>> Please do not describe the schema, but hardware. This sentence > >>>>>> does not help me in my question further. > >>>>> > >>>>> This is a combo phy having Synopsys usb20 and usb30 phys (these 2 > >>>>> phys are > >>>> totally different). > >>>>> One PHY only supports usb2.0 and data rates whereas another one > >>>>> does > >>>>> usb3.1 ssp+ and usb3.1 ssp > >>>>> > >>>>> This patch only explains about usb30 (since these are two > >>>>> different > >>>>> phys) phy > >>>> and omitted inclusion of usb20 reference (added separate patch for > >>>> this patch no 3). > >>>>> > >>>>> Hope this is clear. > >>>> > >>>> No. That sentence still explains what schema is doing. > >>>> > >>> > >>> Ok, let me simplify the commit message further something like below. > >>> Anyways, the coverletter contains more details about it. > >>> > >>> "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo > >>> ssphy > >>> > >>> Add schema for combo ssphy found on this SoC. > >>> " > >>> > >>> Please confirm if this looks fine? > >>> If so, will reflect the similar commit messages in patch 1 and 3. > >> > >> Please read my first comment again. I do not see how does this > >> satisfy hardware explanation. > >> > > Just went through the conversation above, until what extent hardware > > description need to be explain in the commit? > > Do we have any guideline for the same? > > Could you please help with an example from previous any commit or some > other patches? > > I understand that mentioning, “two clocks, two supplies etc" are part > > of schema, one may or may not capture that in the commit. > > However mentioning, “this hardware (SoC) contain a combo PHY which > supports usb3.1 and usb3.0" is not ok? > > > Maybe that's just language, but to me the commit msg did not describe > hardware after first sentence, but said what schema requires (some > clocks and supplies). Other examples: > 00399bbe02d2bb6fd8d6eb90573ec305616449f4 > e4c9a7b475e5d0d9b2440ee48f91d1364eabd6cb > Thanks for suggestion as always, I hope the author can follow this. > and here another anti-pattern: > 23f793850e9ee7390584c0809f085d6c88de7d3f > > (and before you ask why above carries my Rb tag, then note that I will not ask :-) > Samsung's revenue is around 220 billion USD, so for sure it has a lot, > really a lot of resources to review patches internally and improve their > quality before posting). > Hmm..., however let me check internally. > Best regards, > Krzysztof
© 2016 - 2025 Red Hat, Inc.