In the twl6030_usb_probe(), the variable ret is declared as
a u32 type. However, since ret may receive -ENODEV when accepting
the return value of omap_usb2_set_comparator().Therefore, its type
should be changed to int.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
 drivers/usb/phy/phy-twl6030-usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c
index 49d79c1257f3..8c09db750bfd 100644
--- a/drivers/usb/phy/phy-twl6030-usb.c
+++ b/drivers/usb/phy/phy-twl6030-usb.c
@@ -328,9 +328,8 @@ static int twl6030_set_vbus(struct phy_companion *comparator, bool enabled)
 
 static int twl6030_usb_probe(struct platform_device *pdev)
 {
-	u32 ret;
 	struct twl6030_usb	*twl;
-	int			status, err;
+	int			status, err, ret;
 	struct device_node	*np = pdev->dev.of_node;
 	struct device		*dev = &pdev->dev;
 
-- 
2.34.1

On Fri, Aug 22, 2025 at 04:14:03PM +0800, Xichao Zhao wrote:
> In the twl6030_usb_probe(), the variable ret is declared as
> a u32 type. However, since ret may receive -ENODEV when accepting
> the return value of omap_usb2_set_comparator().Therefore, its type
> should be changed to int.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> ---
>  drivers/usb/phy/phy-twl6030-usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

What commit id does this fix?

thanks,

greg k-h

> On Fri, Aug 22, 2025 at 04:14:03PM +0800, Xichao Zhao wrote:
>> In the twl6030_usb_probe(), the variable ret is declared as
>> a u32 type. However, since ret may receive -ENODEV when accepting
>> the return value of omap_usb2_set_comparator().Therefore, its type
>> should be changed to int.
>>
>> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
>> ---
>>   drivers/usb/phy/phy-twl6030-usb.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
> What commit id does this fix?
>
> thanks,
>
> greg k-h

I have added the fixes and sent out the v2 version of the patch.


Best Regards,

Xichao Zhao