drivers/clk/mediatek/clk-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The `flags` in |struct mtk_mux| are core clk flags, not mux clk flags.
Passing one to the other is wrong.
Since there aren't any actual users adding CLK_MUX_* flags, just drop it
for now.
Fixes: b05ea3314390 ("clk: mediatek: clk-mux: Add .determine_rate() callback")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/clk/mediatek/clk-mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c
index 60990296450b..cb015dcf8d30 100644
--- a/drivers/clk/mediatek/clk-mux.c
+++ b/drivers/clk/mediatek/clk-mux.c
@@ -148,7 +148,7 @@ static int mtk_clk_mux_determine_rate(struct clk_hw *hw,
{
struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
- return clk_mux_determine_rate_flags(hw, req, mux->data->flags);
+ return clk_mux_determine_rate_flags(hw, req, 0);
}
const struct clk_ops mtk_mux_clr_set_upd_ops = {
--
2.51.0.261.g7ce5a0a67e-goog
Hi Chen-Yu, kernel test robot noticed the following build warnings: [auto build test WARNING on clk/clk-next] [also build test WARNING on linus/master v6.17-rc2 next-20250822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chen-Yu-Tsai/clk-mediatek-clk-mux-Do-not-pass-flags-to-clk_mux_determine_rate_flags/20250822-143106 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next patch link: https://lore.kernel.org/r/20250822062854.2633133-1-wenst%40chromium.org patch subject: [PATCH] clk: mediatek: clk-mux: Do not pass flags to clk_mux_determine_rate_flags() config: x86_64-buildonly-randconfig-004-20250823 (https://download.01.org/0day-ci/archive/20250823/202508230416.OIwROhOT-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250823/202508230416.OIwROhOT-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202508230416.OIwROhOT-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/clk/mediatek/clk-mux.c:149:22: warning: unused variable 'mux' [-Wunused-variable] 149 | struct mtk_clk_mux *mux = to_mtk_clk_mux(hw); | ^~~ 1 warning generated. vim +/mux +149 drivers/clk/mediatek/clk-mux.c a3ae549917f163 Owen Chen 2019-03-05 145 b05ea3314390e9 AngeloGioacchino Del Regno 2022-10-11 146 static int mtk_clk_mux_determine_rate(struct clk_hw *hw, b05ea3314390e9 AngeloGioacchino Del Regno 2022-10-11 147 struct clk_rate_request *req) b05ea3314390e9 AngeloGioacchino Del Regno 2022-10-11 148 { b05ea3314390e9 AngeloGioacchino Del Regno 2022-10-11 @149 struct mtk_clk_mux *mux = to_mtk_clk_mux(hw); b05ea3314390e9 AngeloGioacchino Del Regno 2022-10-11 150 6c66f834fd3bf9 Chen-Yu Tsai 2025-08-22 151 return clk_mux_determine_rate_flags(hw, req, 0); b05ea3314390e9 AngeloGioacchino Del Regno 2022-10-11 152 } b05ea3314390e9 AngeloGioacchino Del Regno 2022-10-11 153 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
© 2016 - 2025 Red Hat, Inc.