[PATCH] rust: Update PCI resource_start()/len() to return ResourceSize

Alistair Popple posted 1 patch 1 month, 1 week ago
rust/kernel/pci.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] rust: Update PCI resource_start()/len() to return ResourceSize
Posted by Alistair Popple 1 month, 1 week ago
It's nicer to return native Rust types rather than the FFI bindings to a
type so update the PCI resource bindings to return ResourceSize.

Signed-off-by: Alistair Popple <apopple@nvidia.com>
Suggested-by: Danilo Krummrich <dakr@kernel.org>
---
 rust/kernel/pci.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index cae4e274f7766..ef949ff10a10a 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -10,7 +10,7 @@
     devres::Devres,
     driver,
     error::{from_result, to_result, Result},
-    io::{Io, IoRaw},
+    io::{resource::ResourceSize, Io, IoRaw},
     irq::{self, IrqRequest},
     str::CStr,
     sync::aref::ARef,
@@ -437,7 +437,7 @@ pub fn subsystem_device_id(&self) -> u16 {
     }
 
     /// Returns the start of the given PCI bar resource.
-    pub fn resource_start(&self, bar: u32) -> Result<bindings::resource_size_t> {
+    pub fn resource_start(&self, bar: u32) -> Result<ResourceSize> {
         if !Bar::index_is_valid(bar) {
             return Err(EINVAL);
         }
@@ -449,7 +449,7 @@ pub fn resource_start(&self, bar: u32) -> Result<bindings::resource_size_t> {
     }
 
     /// Returns the size of the given PCI bar resource.
-    pub fn resource_len(&self, bar: u32) -> Result<bindings::resource_size_t> {
+    pub fn resource_len(&self, bar: u32) -> Result<ResourceSize> {
         if !Bar::index_is_valid(bar) {
             return Err(EINVAL);
         }
-- 
2.47.2
Re: [PATCH] rust: Update PCI resource_start()/len() to return ResourceSize
Posted by Alice Ryhl 1 month, 1 week ago
On Fri, Aug 22, 2025 at 6:13 AM Alistair Popple <apopple@nvidia.com> wrote:
>
> It's nicer to return native Rust types rather than the FFI bindings to a
> type so update the PCI resource bindings to return ResourceSize.
>
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

>  rust/kernel/pci.rs | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
> index cae4e274f7766..ef949ff10a10a 100644
> --- a/rust/kernel/pci.rs
> +++ b/rust/kernel/pci.rs
> @@ -10,7 +10,7 @@
>      devres::Devres,
>      driver,
>      error::{from_result, to_result, Result},
> -    io::{Io, IoRaw},
> +    io::{resource::ResourceSize, Io, IoRaw},

Maybe we want ResourceSize re-exported from kernel::io to make this simpler?

Alice