[PATCH] block: mtip32xx: Remove the redundant return

Zhang Heng posted 1 patch 1 month, 1 week ago
drivers/block/mtip32xx/mtip32xx.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] block: mtip32xx: Remove the redundant return
Posted by Zhang Heng 1 month, 1 week ago
Remove the redundant return

Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 drivers/block/mtip32xx/mtip32xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 8fc7761397bd..b0c4d1c92da5 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3841,7 +3841,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,
 iomap_err:
 	kfree(dd);
 	pci_set_drvdata(pdev, NULL);
-	return rv;
 done:
 	return rv;
 }
-- 
2.47.1
Re: [PATCH] block: mtip32xx: Remove the redundant return
Posted by Andy Shevchenko 1 month, 1 week ago
On Fri, Aug 22, 2025 at 10:41:00AM +0800, Zhang Heng wrote:
> Remove the redundant return

Missing period.

...

>  iomap_err:
>  	kfree(dd);

>  	pci_set_drvdata(pdev, NULL);

I'm wondering if this also being redundant. I know about some corner cases, so
is this one of them, or can it be removed as well?

> -	return rv;
>  done:
>  	return rv;

-- 
With Best Regards,
Andy Shevchenko