[v2] arm64: dts: qcom: x1: Add missing pinctrl for eDP HPD

[PATCH v2 00/10] arm64: dts: qcom: x1: Add missing pinctrl for eDP HPD

Posted by Stephan Gerhold 1 month, 1 week ago

At the moment, we indirectly rely on the boot firmware to set up the
pinctrl for the eDP HPD line coming from the internal display. If the boot
firmware does not configure the display (e.g. because a different display
is selected for output in the UEFI settings), then the display fails to
come up and there are several errors in the kernel log:

 [drm:dpu_encoder_phys_vid_wait_for_commit_done:544] [dpu error]vblank timeout: 80020041
 [drm:dpu_kms_wait_for_commit_done:524] [dpu error]wait for commit done returned -110
 [drm:dpu_encoder_frame_done_timeout:2715] [dpu error]enc40 frame done timeout
 ...

Fix this by adding the missing pinctrl for gpio119 for all the boards
supported upstream, using a &edp0_hpd_default template in x1e80100.dtsi.

I ran into this issue on the X1E CRD while testing some things and had this
fix in my local tree for a while. Chris made a similar patch for the T14s
[1], this series fixes up all of the boards upstream.

[1]: https://lore.kernel.org/linux-arm-msm/20250731-wip-obbardc-qcom-t14s-oled-panel-v6-1-4782074104d1@linaro.org/

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
Changes in v2:
- Define &edp0_hpd_default template in the SoC dtsi and only reference it
  individually for each board, since it is exactly the same for all the
  boards upstream anyway (Dmitry)
- The resulting DTBs are functionally still the same, so pick up tags from
  previous version.
- Link to v1: https://lore.kernel.org/r/20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@linaro.org

---
Stephan Gerhold (10):
      arm64: dts: qcom: x1e80100: Add pinctrl template for eDP0 HPD
      arm64: dts: qcom: x1-asus-zenbook-a14: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1-crd: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1e80100-asus-vivobook-s15: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1e80100-dell-xps13-9345: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1e80100-hp-omnibook-x14: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1e80100-microsoft-romulus: Add missing pinctrl for eDP HPD
      arm64: dts: qcom: x1e80100-qcp: Add missing pinctrl for eDP HPD

 arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi           | 3 +++
 arch/arm64/boot/dts/qcom/x1-crd.dtsi                        | 3 +++
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts     | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts       | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts       | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts    | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi    | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                   | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                      | 6 ++++++
 10 files changed, 33 insertions(+)
---
base-commit: 1aa50d938e88fcad1312467bd09be4037bfe68ff
change-id: 20250813-x1e80100-add-edp-hpd-91209c5a0720

Best regards,
-- 
Stephan Gerhold <stephan.gerhold@linaro.org>

Re: [PATCH v2 00/10] arm64: dts: qcom: x1: Add missing pinctrl for eDP HPD

Posted by Bjorn Andersson 1 month ago

On Fri, 22 Aug 2025 11:28:51 +0200, Stephan Gerhold wrote:
> At the moment, we indirectly rely on the boot firmware to set up the
> pinctrl for the eDP HPD line coming from the internal display. If the boot
> firmware does not configure the display (e.g. because a different display
> is selected for output in the UEFI settings), then the display fails to
> come up and there are several errors in the kernel log:
> 
>  [drm:dpu_encoder_phys_vid_wait_for_commit_done:544] [dpu error]vblank timeout: 80020041
>  [drm:dpu_kms_wait_for_commit_done:524] [dpu error]wait for commit done returned -110
>  [drm:dpu_encoder_frame_done_timeout:2715] [dpu error]enc40 frame done timeout
>  ...
> 
> [...]

Applied, thanks!

[01/10] arm64: dts: qcom: x1e80100: Add pinctrl template for eDP0 HPD
        commit: 6dfa62182c3b2b31b3da5e7e5b87c294dc3ddb5c
[02/10] arm64: dts: qcom: x1-asus-zenbook-a14: Add missing pinctrl for eDP HPD
        commit: 35fab4bedcf1fb4a7b2e2f6a5e35b43e9447ad70
[03/10] arm64: dts: qcom: x1-crd: Add missing pinctrl for eDP HPD
        commit: 540020f93b22219690d591fcfd5081ab3d34ad66
[04/10] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Add missing pinctrl for eDP HPD
        commit: d1126668533eedebd6130515c7626af1ef808abb
[05/10] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Add missing pinctrl for eDP HPD
        commit: c95c1ba079f604c504feb8cf7bb038341e2d7805
[06/10] arm64: dts: qcom: x1e80100-dell-xps13-9345: Add missing pinctrl for eDP HPD
        commit: a41d23142d8773614cb2745d7b224e5784cc71ab
[07/10] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Add missing pinctrl for eDP HPD
        commit: 0e94604702eb9f141ef862b10757d67e3880235c
[08/10] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add missing pinctrl for eDP HPD
        commit: f6470367bdb2cde247cd88864208db998fed03ac
[09/10] arm64: dts: qcom: x1e80100-microsoft-romulus: Add missing pinctrl for eDP HPD
        commit: 4b9165960bf2d25817de6f5fda3d2cd07f787927
[10/10] arm64: dts: qcom: x1e80100-qcp: Add missing pinctrl for eDP HPD
        commit: 1616877626228a6ef05ddae4017c9b0f65803a8b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v2 00/10] arm64: dts: qcom: x1: Add missing pinctrl for eDP HPD

Posted by Dmitry Baryshkov 1 month, 1 week ago

On Fri, Aug 22, 2025 at 11:28:51AM +0200, Stephan Gerhold wrote:
> At the moment, we indirectly rely on the boot firmware to set up the
> pinctrl for the eDP HPD line coming from the internal display. If the boot
> firmware does not configure the display (e.g. because a different display
> is selected for output in the UEFI settings), then the display fails to
> come up and there are several errors in the kernel log:
> 
>  [drm:dpu_encoder_phys_vid_wait_for_commit_done:544] [dpu error]vblank timeout: 80020041
>  [drm:dpu_kms_wait_for_commit_done:524] [dpu error]wait for commit done returned -110
>  [drm:dpu_encoder_frame_done_timeout:2715] [dpu error]enc40 frame done timeout
>  ...
> 
> Fix this by adding the missing pinctrl for gpio119 for all the boards
> supported upstream, using a &edp0_hpd_default template in x1e80100.dtsi.
> 
> I ran into this issue on the X1E CRD while testing some things and had this
> fix in my local tree for a while. Chris made a similar patch for the T14s
> [1], this series fixes up all of the boards upstream.
> 
> [1]: https://lore.kernel.org/linux-arm-msm/20250731-wip-obbardc-qcom-t14s-oled-panel-v6-1-4782074104d1@linaro.org/
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
> Changes in v2:
> - Define &edp0_hpd_default template in the SoC dtsi and only reference it
>   individually for each board, since it is exactly the same for all the
>   boards upstream anyway (Dmitry)
> - The resulting DTBs are functionally still the same, so pick up tags from
>   previous version.
> - Link to v1: https://lore.kernel.org/r/20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@linaro.org
> 

For the series:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



-- 
With best wishes
Dmitry