[PATCH v8 0/5] iio: mcp9600: Features and improvements

Ben Collins posted 5 patches 1 month, 1 week ago
.../iio/temperature/microchip,mcp9600.yaml         |  57 +++++++-
drivers/iio/temperature/Kconfig                    |   8 +-
drivers/iio/temperature/mcp9600.c                  | 151 +++++++++++++++++----
3 files changed, 187 insertions(+), 29 deletions(-)
[PATCH v8 0/5] iio: mcp9600: Features and improvements
Posted by Ben Collins 1 month, 1 week ago
ChangeLog:
v7 -> v8:
  - Style changes in dt-bindings example
  - Simplify some return value checks
  - Move assignment to where it's checked
  - Speeling

v6 -> v7:
  - Separate out the mcp9600 IIR series into its own series as there is
    a lot of conversation around implementation (removed related
    comments from this changelog).

v5 -> v6:
  - Fix accidental typo added in dt-bindings: IRQ_TYPE_EDGE_RISIN
  - Correct some constraints in dt-bindings
  - Reverse if/then for mcp9601 vs mcp9600 constraints in dt-bindings
  - Updates to changelog for patch 2/6 (dt-bindings mcp9600)
  - Cleanup tabs that were converted to spaces
  - Split thermocouple-type default to separate patch

v4 -> v5:
  - None

v3 -> v4:
  - Based on feedback from David Lechner <dlechner@baylibre.com>
    * Allow fallback compatible in dt-bindings for mcp9601.
  - Based on feedback from Jonathan Cameron <jic23@kernel.org>
    * Be explicit in patch description for fixed width changes.
    * Check chip_info for NULL to quiet warnings from kernel-test-robot
    * Remove "and similar" for long description of MCP9600.
  - Set default 3 for thermocouple in dt-binding
  - Rework open/short circuit in dt-bindings

v2 -> v3:
  - Improve changelogs in each patch
  - Based on feedback from Andy Shevchenko <andy.shevchenko@gmail.com>
    * Set register offsets to fixed width
    * Fix typos
    * Future-proof Kconfig changes
    * Convert to using chip_info paradigm
    * Verbiage: dt -> firmware description
    * Use proper specifiers and drop castings
    * Fix register offset to be fixed-width
    * u8 for cfg var
    * Fix % type for u32 to be %u
    * Make blank lines consistent between case statements

v1 -> v2:
  - Break into individual patches

v1:
  - Initial patch to enable IIR and thermocouple-type
  - Recognize mcp9601

Signed-off-by: Ben Collins <bcollins@watter.com>
---
- Link to v7: https://lore.kernel.org/r/20250819-upstream-changes-v7-0-88a33aa78f6a@watter.com

---
Ben Collins (5):
      dt-bindings: iio: mcp9600: Set default 3 for thermocouple-type
      dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints
      iio: mcp9600: White space and fixed width cleanup
      iio: mcp9600: Recognize chip id for mcp9601
      iio: mcp9600: Add support for thermocouple-type

 .../iio/temperature/microchip,mcp9600.yaml         |  57 +++++++-
 drivers/iio/temperature/Kconfig                    |   8 +-
 drivers/iio/temperature/mcp9600.c                  | 151 +++++++++++++++++----
 3 files changed, 187 insertions(+), 29 deletions(-)
---
base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
change-id: 20250819-upstream-changes-c89af86743fa

Best regards,
-- 
Ben Collins <bcollins@watter.com>
Re: [PATCH v8 0/5] iio: mcp9600: Features and improvements
Posted by Jonathan Cameron 1 month, 1 week ago
On Fri, 22 Aug 2025 09:23:49 -0400
Ben Collins <bcollins@watter.com> wrote:

Series applied with that unnecessary include that David pointed out dropped.

Applied to the togreg branch of iio.git but initially pushed out as testing
to give 0-day a few days to poke at it.

Thanks,

Jonathan


> ChangeLog:
> v7 -> v8:
>   - Style changes in dt-bindings example
>   - Simplify some return value checks
>   - Move assignment to where it's checked
>   - Speeling
> 
> v6 -> v7:
>   - Separate out the mcp9600 IIR series into its own series as there is
>     a lot of conversation around implementation (removed related
>     comments from this changelog).
> 
> v5 -> v6:
>   - Fix accidental typo added in dt-bindings: IRQ_TYPE_EDGE_RISIN
>   - Correct some constraints in dt-bindings
>   - Reverse if/then for mcp9601 vs mcp9600 constraints in dt-bindings
>   - Updates to changelog for patch 2/6 (dt-bindings mcp9600)
>   - Cleanup tabs that were converted to spaces
>   - Split thermocouple-type default to separate patch
> 
> v4 -> v5:
>   - None
> 
> v3 -> v4:
>   - Based on feedback from David Lechner <dlechner@baylibre.com>
>     * Allow fallback compatible in dt-bindings for mcp9601.
>   - Based on feedback from Jonathan Cameron <jic23@kernel.org>
>     * Be explicit in patch description for fixed width changes.
>     * Check chip_info for NULL to quiet warnings from kernel-test-robot
>     * Remove "and similar" for long description of MCP9600.
>   - Set default 3 for thermocouple in dt-binding
>   - Rework open/short circuit in dt-bindings
> 
> v2 -> v3:
>   - Improve changelogs in each patch
>   - Based on feedback from Andy Shevchenko <andy.shevchenko@gmail.com>
>     * Set register offsets to fixed width
>     * Fix typos
>     * Future-proof Kconfig changes
>     * Convert to using chip_info paradigm
>     * Verbiage: dt -> firmware description
>     * Use proper specifiers and drop castings
>     * Fix register offset to be fixed-width
>     * u8 for cfg var
>     * Fix % type for u32 to be %u
>     * Make blank lines consistent between case statements
> 
> v1 -> v2:
>   - Break into individual patches
> 
> v1:
>   - Initial patch to enable IIR and thermocouple-type
>   - Recognize mcp9601
> 
> Signed-off-by: Ben Collins <bcollins@watter.com>
> ---
> - Link to v7: https://lore.kernel.org/r/20250819-upstream-changes-v7-0-88a33aa78f6a@watter.com
> 
> ---
> Ben Collins (5):
>       dt-bindings: iio: mcp9600: Set default 3 for thermocouple-type
>       dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints
>       iio: mcp9600: White space and fixed width cleanup
>       iio: mcp9600: Recognize chip id for mcp9601
>       iio: mcp9600: Add support for thermocouple-type
> 
>  .../iio/temperature/microchip,mcp9600.yaml         |  57 +++++++-
>  drivers/iio/temperature/Kconfig                    |   8 +-
>  drivers/iio/temperature/mcp9600.c                  | 151 +++++++++++++++++----
>  3 files changed, 187 insertions(+), 29 deletions(-)
> ---
> base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
> change-id: 20250819-upstream-changes-c89af86743fa
> 
> Best regards,
Re: [PATCH v8 0/5] iio: mcp9600: Features and improvements
Posted by Ben Collins 1 month, 1 week ago
On Mon, Aug 25, 2025 at 10:38:47AM -0500, Jonathan Cameron wrote:
> On Fri, 22 Aug 2025 09:23:49 -0400
> Ben Collins <bcollins@watter.com> wrote:
> 
> Series applied with that unnecessary include that David pointed out dropped.
> 
> Applied to the togreg branch of iio.git but initially pushed out as testing
> to give 0-day a few days to poke at it.
> 

Thanks Jonathan and to everyone else for the input.

> 
> > ChangeLog:
> > v7 -> v8:
> >   - Style changes in dt-bindings example
> >   - Simplify some return value checks
> >   - Move assignment to where it's checked
> >   - Speeling
> > 
> > v6 -> v7:
> >   - Separate out the mcp9600 IIR series into its own series as there is
> >     a lot of conversation around implementation (removed related
> >     comments from this changelog).
> > 
> > v5 -> v6:
> >   - Fix accidental typo added in dt-bindings: IRQ_TYPE_EDGE_RISIN
> >   - Correct some constraints in dt-bindings
> >   - Reverse if/then for mcp9601 vs mcp9600 constraints in dt-bindings
> >   - Updates to changelog for patch 2/6 (dt-bindings mcp9600)
> >   - Cleanup tabs that were converted to spaces
> >   - Split thermocouple-type default to separate patch
> > 
> > v4 -> v5:
> >   - None
> > 
> > v3 -> v4:
> >   - Based on feedback from David Lechner <dlechner@baylibre.com>
> >     * Allow fallback compatible in dt-bindings for mcp9601.
> >   - Based on feedback from Jonathan Cameron <jic23@kernel.org>
> >     * Be explicit in patch description for fixed width changes.
> >     * Check chip_info for NULL to quiet warnings from kernel-test-robot
> >     * Remove "and similar" for long description of MCP9600.
> >   - Set default 3 for thermocouple in dt-binding
> >   - Rework open/short circuit in dt-bindings
> > 
> > v2 -> v3:
> >   - Improve changelogs in each patch
> >   - Based on feedback from Andy Shevchenko <andy.shevchenko@gmail.com>
> >     * Set register offsets to fixed width
> >     * Fix typos
> >     * Future-proof Kconfig changes
> >     * Convert to using chip_info paradigm
> >     * Verbiage: dt -> firmware description
> >     * Use proper specifiers and drop castings
> >     * Fix register offset to be fixed-width
> >     * u8 for cfg var
> >     * Fix % type for u32 to be %u
> >     * Make blank lines consistent between case statements
> > 
> > v1 -> v2:
> >   - Break into individual patches
> > 
> > v1:
> >   - Initial patch to enable IIR and thermocouple-type
> >   - Recognize mcp9601
> > 
> > Signed-off-by: Ben Collins <bcollins@watter.com>
> > ---
> > - Link to v7: https://lore.kernel.org/r/20250819-upstream-changes-v7-0-88a33aa78f6a@watter.com
> > 
> > ---
> > Ben Collins (5):
> >       dt-bindings: iio: mcp9600: Set default 3 for thermocouple-type
> >       dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints
> >       iio: mcp9600: White space and fixed width cleanup
> >       iio: mcp9600: Recognize chip id for mcp9601
> >       iio: mcp9600: Add support for thermocouple-type
> > 
> >  .../iio/temperature/microchip,mcp9600.yaml         |  57 +++++++-
> >  drivers/iio/temperature/Kconfig                    |   8 +-
> >  drivers/iio/temperature/mcp9600.c                  | 151 +++++++++++++++++----
> >  3 files changed, 187 insertions(+), 29 deletions(-)
> > ---
> > base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
> > change-id: 20250819-upstream-changes-c89af86743fa
> > 
> > Best regards,
> 
> 

-- 
 Ben Collins
 https://libjwt.io
 https://github.com/benmcollins
 --
 3EC9 7598 1672 961A 1139  173A 5D5A 57C7 242B 22CF