[PATCH 00/10] iio: Drop unnecessary -ENOMEM messages

Dixit Parmar posted 10 patches 1 month, 1 week ago
drivers/iio/accel/bma220_spi.c      | 4 +---
drivers/iio/accel/dmard06.c         | 4 +---
drivers/iio/accel/dmard09.c         | 4 +---
drivers/iio/accel/dmard10.c         | 4 +---
drivers/iio/accel/mc3230.c          | 4 +---
drivers/iio/accel/mma7660.c         | 4 +---
drivers/iio/accel/stk8312.c         | 4 +---
drivers/iio/accel/stk8ba50.c        | 4 +---
drivers/iio/adc/ad7949.c            | 4 +---
drivers/iio/adc/bcm_iproc_adc.c     | 4 +---
drivers/iio/adc/cpcap-adc.c         | 6 ++----
drivers/iio/adc/da9150-gpadc.c      | 5 ++---
drivers/iio/adc/dln2-adc.c          | 9 +++------
drivers/iio/adc/exynos_adc.c        | 4 +---
drivers/iio/adc/imx7d_adc.c         | 4 +---
drivers/iio/adc/imx8qxp-adc.c       | 4 +---
drivers/iio/adc/mxs-lradc-adc.c     | 4 +---
drivers/iio/adc/palmas_gpadc.c      | 4 +---
drivers/iio/adc/rn5t618-adc.c       | 4 +---
drivers/iio/adc/stm32-dfsdm-adc.c   | 4 +---
drivers/iio/adc/stmpe-adc.c         | 4 +---
drivers/iio/adc/ti-adc084s021.c     | 4 +---
drivers/iio/adc/ti-ads131e08.c      | 8 ++------
drivers/iio/adc/ti_am335x_adc.c     | 5 ++---
drivers/iio/adc/twl4030-madc.c      | 4 +---
drivers/iio/adc/viperboard_adc.c    | 4 +---
drivers/iio/dac/ad5380.c            | 4 +---
drivers/iio/dac/ad5764.c            | 4 +---
drivers/iio/dac/ds4424.c            | 4 +---
drivers/iio/dac/ti-dac7311.c        | 4 +---
drivers/iio/dac/vf610_dac.c         | 4 +---
drivers/iio/health/afe4403.c        | 4 +---
drivers/iio/health/afe4404.c        | 4 +---
drivers/iio/humidity/am2315.c       | 4 +---
drivers/iio/humidity/dht11.c        | 4 +---
drivers/iio/light/stk3310.c         | 4 +---
drivers/iio/potentiostat/lmp91000.c | 4 +---
drivers/iio/pressure/dlhl60d.c      | 4 +---
drivers/iio/proximity/ping.c        | 4 +---
drivers/iio/proximity/srf04.c       | 4 +---
drivers/iio/temperature/mlx90632.c  | 4 +---
41 files changed, 47 insertions(+), 130 deletions(-)
[PATCH 00/10] iio: Drop unnecessary -ENOMEM messages
Posted by Dixit Parmar 1 month, 1 week ago
The drivers do not require their own error messages for error
-ENOMEM, memory allocation failures. So remove the dev_err
messages from the probe().
With these patches, all the iio drivers now has uniform handling
of the -ENOMEM while device_allocation and trigger_allocation
calls.

Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
---
Dixit Parmar (10):
      iio: accel: Drop unnecessary -ENOMEM messages
      iio: adc: Drop unnecessary -ENOMEM messages
      iio: dac: Drop unnecessary -ENOMEM messages
      iio: health: Drop unnecessary -ENOMEM messages
      iio: humidity: Drop unnecessary -ENOMEM messages
      iio: light: Drop unnecessary -ENOMEM messages
      iio: potentiostat: Drop unnecessary -ENOMEM messages
      iio: pressure: Drop unnecessary -ENOMEM messages
      iio: proximity: Drop unnecessary -ENOMEM messages
      iio: temperature: Drop unnecessary -ENOMEM messages

 drivers/iio/accel/bma220_spi.c      | 4 +---
 drivers/iio/accel/dmard06.c         | 4 +---
 drivers/iio/accel/dmard09.c         | 4 +---
 drivers/iio/accel/dmard10.c         | 4 +---
 drivers/iio/accel/mc3230.c          | 4 +---
 drivers/iio/accel/mma7660.c         | 4 +---
 drivers/iio/accel/stk8312.c         | 4 +---
 drivers/iio/accel/stk8ba50.c        | 4 +---
 drivers/iio/adc/ad7949.c            | 4 +---
 drivers/iio/adc/bcm_iproc_adc.c     | 4 +---
 drivers/iio/adc/cpcap-adc.c         | 6 ++----
 drivers/iio/adc/da9150-gpadc.c      | 5 ++---
 drivers/iio/adc/dln2-adc.c          | 9 +++------
 drivers/iio/adc/exynos_adc.c        | 4 +---
 drivers/iio/adc/imx7d_adc.c         | 4 +---
 drivers/iio/adc/imx8qxp-adc.c       | 4 +---
 drivers/iio/adc/mxs-lradc-adc.c     | 4 +---
 drivers/iio/adc/palmas_gpadc.c      | 4 +---
 drivers/iio/adc/rn5t618-adc.c       | 4 +---
 drivers/iio/adc/stm32-dfsdm-adc.c   | 4 +---
 drivers/iio/adc/stmpe-adc.c         | 4 +---
 drivers/iio/adc/ti-adc084s021.c     | 4 +---
 drivers/iio/adc/ti-ads131e08.c      | 8 ++------
 drivers/iio/adc/ti_am335x_adc.c     | 5 ++---
 drivers/iio/adc/twl4030-madc.c      | 4 +---
 drivers/iio/adc/viperboard_adc.c    | 4 +---
 drivers/iio/dac/ad5380.c            | 4 +---
 drivers/iio/dac/ad5764.c            | 4 +---
 drivers/iio/dac/ds4424.c            | 4 +---
 drivers/iio/dac/ti-dac7311.c        | 4 +---
 drivers/iio/dac/vf610_dac.c         | 4 +---
 drivers/iio/health/afe4403.c        | 4 +---
 drivers/iio/health/afe4404.c        | 4 +---
 drivers/iio/humidity/am2315.c       | 4 +---
 drivers/iio/humidity/dht11.c        | 4 +---
 drivers/iio/light/stk3310.c         | 4 +---
 drivers/iio/potentiostat/lmp91000.c | 4 +---
 drivers/iio/pressure/dlhl60d.c      | 4 +---
 drivers/iio/proximity/ping.c        | 4 +---
 drivers/iio/proximity/srf04.c       | 4 +---
 drivers/iio/temperature/mlx90632.c  | 4 +---
 41 files changed, 47 insertions(+), 130 deletions(-)
---
base-commit: d7b8f8e20813f0179d8ef519541a3527e7661d3a
change-id: 20250822-enomam_logs-f66642957fb3

Best regards,
-- 
Dixit Parmar <dixitparmar19@gmail.com>
Re: [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages
Posted by Andy Shevchenko 1 month, 1 week ago
On Fri, Aug 22, 2025 at 6:50 AM Dixit Parmar <dixitparmar19@gmail.com> wrote:
>
> The drivers do not require their own error messages for error
> -ENOMEM, memory allocation failures. So remove the dev_err
> messages from the probe().
> With these patches, all the iio drivers now has uniform handling
> of the -ENOMEM while device_allocation and trigger_allocation
> calls.

I don't understand. Don't you have a subscription to linux-iio@ ML?
https://lore.kernel.org/linux-iio/CAHp75VdL9kV2fyi63zqPZnW4CaeYPmJ74tmGEgU=M7FSYBv0ww@mail.gmail.com/T/#t
If you found something new, please base it on that series as it was
already sent and reviewed.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages
Posted by Dixit Parmar 1 month, 1 week ago
On Fri, Aug 22, 2025 at 11:49 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> I don't understand. Don't you have a subscription to linux-iio@ ML?
> https://lore.kernel.org/linux-iio/CAHp75VdL9kV2fyi63zqPZnW4CaeYPmJ74tmGEgU=M7FSYBv0ww@mail.gmail.com/T/#t
> If you found something new, please base it on that series as it was
> already sent and reviewed.
Thanks. I do have subscription to linux-iio@ML and did check the patch
series you mentioned.
That patch series by Xichao Zhao removes dev_err_probe() for -ENOMEM
cases whereas
this series is targeting slightly different cleanup of removing the
plain dev_err() log messages
that are there for -ENOMEM.
As far as I can see, both the series are modifying completely
different driver files without overlapping changes.
Since the objectives are related but independent and addressing
different type of change, I thought to keep
these patches in different patch series and have clear differentiation.
Although to establish similarity it would have made more sense If I
would have added the link to that patch series here.
Thanks,
Dixit
Re: [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages
Posted by Andy Shevchenko 1 month, 1 week ago
On Fri, Aug 22, 2025 at 02:58:34PM +0530, Dixit Parmar wrote:
> On Fri, Aug 22, 2025 at 11:49 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > I don't understand. Don't you have a subscription to linux-iio@ ML?
> > https://lore.kernel.org/linux-iio/CAHp75VdL9kV2fyi63zqPZnW4CaeYPmJ74tmGEgU=M7FSYBv0ww@mail.gmail.com/T/#t
> > If you found something new, please base it on that series as it was
> > already sent and reviewed.

> Thanks. I do have subscription to linux-iio@ML and did check the patch
> series you mentioned.
> That patch series by Xichao Zhao removes dev_err_probe() for -ENOMEM
> cases whereas
> this series is targeting slightly different cleanup of removing the
> plain dev_err() log messages
> that are there for -ENOMEM.

I see, makes sense.

> As far as I can see, both the series are modifying completely
> different driver files without overlapping changes.
> Since the objectives are related but independent and addressing
> different type of change, I thought to keep
> these patches in different patch series and have clear differentiation.
> Although to establish similarity it would have made more sense If I
> would have added the link to that patch series here.

With this clarification it indeed may be applied independently.

-- 
With Best Regards,
Andy Shevchenko


Re: [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages
Posted by Jonathan Cameron 1 month, 1 week ago
On Fri, 22 Aug 2025 09:19:48 +0530
Dixit Parmar <dixitparmar19@gmail.com> wrote:

> The drivers do not require their own error messages for error
> -ENOMEM, memory allocation failures. So remove the dev_err
> messages from the probe().
> With these patches, all the iio drivers now has uniform handling
> of the -ENOMEM while device_allocation and trigger_allocation
> calls.
> 
> Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
Series looks fine to me, after the minor tweaks to commit messages
that Andy requested.  However as it touches a lot of drivers
I'd like to leave it on list a little longer.

Thanks,

Jonathan

> ---
> Dixit Parmar (10):
>       iio: accel: Drop unnecessary -ENOMEM messages
>       iio: adc: Drop unnecessary -ENOMEM messages
>       iio: dac: Drop unnecessary -ENOMEM messages
>       iio: health: Drop unnecessary -ENOMEM messages
>       iio: humidity: Drop unnecessary -ENOMEM messages
>       iio: light: Drop unnecessary -ENOMEM messages
>       iio: potentiostat: Drop unnecessary -ENOMEM messages
>       iio: pressure: Drop unnecessary -ENOMEM messages
>       iio: proximity: Drop unnecessary -ENOMEM messages
>       iio: temperature: Drop unnecessary -ENOMEM messages
> 
>  drivers/iio/accel/bma220_spi.c      | 4 +---
>  drivers/iio/accel/dmard06.c         | 4 +---
>  drivers/iio/accel/dmard09.c         | 4 +---
>  drivers/iio/accel/dmard10.c         | 4 +---
>  drivers/iio/accel/mc3230.c          | 4 +---
>  drivers/iio/accel/mma7660.c         | 4 +---
>  drivers/iio/accel/stk8312.c         | 4 +---
>  drivers/iio/accel/stk8ba50.c        | 4 +---
>  drivers/iio/adc/ad7949.c            | 4 +---
>  drivers/iio/adc/bcm_iproc_adc.c     | 4 +---
>  drivers/iio/adc/cpcap-adc.c         | 6 ++----
>  drivers/iio/adc/da9150-gpadc.c      | 5 ++---
>  drivers/iio/adc/dln2-adc.c          | 9 +++------
>  drivers/iio/adc/exynos_adc.c        | 4 +---
>  drivers/iio/adc/imx7d_adc.c         | 4 +---
>  drivers/iio/adc/imx8qxp-adc.c       | 4 +---
>  drivers/iio/adc/mxs-lradc-adc.c     | 4 +---
>  drivers/iio/adc/palmas_gpadc.c      | 4 +---
>  drivers/iio/adc/rn5t618-adc.c       | 4 +---
>  drivers/iio/adc/stm32-dfsdm-adc.c   | 4 +---
>  drivers/iio/adc/stmpe-adc.c         | 4 +---
>  drivers/iio/adc/ti-adc084s021.c     | 4 +---
>  drivers/iio/adc/ti-ads131e08.c      | 8 ++------
>  drivers/iio/adc/ti_am335x_adc.c     | 5 ++---
>  drivers/iio/adc/twl4030-madc.c      | 4 +---
>  drivers/iio/adc/viperboard_adc.c    | 4 +---
>  drivers/iio/dac/ad5380.c            | 4 +---
>  drivers/iio/dac/ad5764.c            | 4 +---
>  drivers/iio/dac/ds4424.c            | 4 +---
>  drivers/iio/dac/ti-dac7311.c        | 4 +---
>  drivers/iio/dac/vf610_dac.c         | 4 +---
>  drivers/iio/health/afe4403.c        | 4 +---
>  drivers/iio/health/afe4404.c        | 4 +---
>  drivers/iio/humidity/am2315.c       | 4 +---
>  drivers/iio/humidity/dht11.c        | 4 +---
>  drivers/iio/light/stk3310.c         | 4 +---
>  drivers/iio/potentiostat/lmp91000.c | 4 +---
>  drivers/iio/pressure/dlhl60d.c      | 4 +---
>  drivers/iio/proximity/ping.c        | 4 +---
>  drivers/iio/proximity/srf04.c       | 4 +---
>  drivers/iio/temperature/mlx90632.c  | 4 +---
>  41 files changed, 47 insertions(+), 130 deletions(-)
> ---
> base-commit: d7b8f8e20813f0179d8ef519541a3527e7661d3a
> change-id: 20250822-enomam_logs-f66642957fb3
> 
> Best regards,
Re: [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages
Posted by Jonathan Cameron 1 month, 1 week ago
On Mon, 25 Aug 2025 09:31:50 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Fri, 22 Aug 2025 09:19:48 +0530
> Dixit Parmar <dixitparmar19@gmail.com> wrote:
> 
> > The drivers do not require their own error messages for error
> > -ENOMEM, memory allocation failures. So remove the dev_err
> > messages from the probe().
> > With these patches, all the iio drivers now has uniform handling
> > of the -ENOMEM while device_allocation and trigger_allocation
> > calls.
> > 
> > Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>  
> Series looks fine to me, after the minor tweaks to commit messages
> that Andy requested.  However as it touches a lot of drivers
> I'd like to leave it on list a little longer.

I changed my mind after taking the dev_err_probe() series earlier.
I'm rather too busy at the moment, so clearing this out now will reduce
what I need to keep track of.

Fixed up the () that Andy asked for in commit messages and applied
to the togreg branch of iio.git, pushed out initially as testing.

There is still the rest of the week (probably) in which I can add
tags etc if anyone wants to give them before I push that out as
a non rebasing tree.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> > ---
> > Dixit Parmar (10):
> >       iio: accel: Drop unnecessary -ENOMEM messages
> >       iio: adc: Drop unnecessary -ENOMEM messages
> >       iio: dac: Drop unnecessary -ENOMEM messages
> >       iio: health: Drop unnecessary -ENOMEM messages
> >       iio: humidity: Drop unnecessary -ENOMEM messages
> >       iio: light: Drop unnecessary -ENOMEM messages
> >       iio: potentiostat: Drop unnecessary -ENOMEM messages
> >       iio: pressure: Drop unnecessary -ENOMEM messages
> >       iio: proximity: Drop unnecessary -ENOMEM messages
> >       iio: temperature: Drop unnecessary -ENOMEM messages
> > 
> >  drivers/iio/accel/bma220_spi.c      | 4 +---
> >  drivers/iio/accel/dmard06.c         | 4 +---
> >  drivers/iio/accel/dmard09.c         | 4 +---
> >  drivers/iio/accel/dmard10.c         | 4 +---
> >  drivers/iio/accel/mc3230.c          | 4 +---
> >  drivers/iio/accel/mma7660.c         | 4 +---
> >  drivers/iio/accel/stk8312.c         | 4 +---
> >  drivers/iio/accel/stk8ba50.c        | 4 +---
> >  drivers/iio/adc/ad7949.c            | 4 +---
> >  drivers/iio/adc/bcm_iproc_adc.c     | 4 +---
> >  drivers/iio/adc/cpcap-adc.c         | 6 ++----
> >  drivers/iio/adc/da9150-gpadc.c      | 5 ++---
> >  drivers/iio/adc/dln2-adc.c          | 9 +++------
> >  drivers/iio/adc/exynos_adc.c        | 4 +---
> >  drivers/iio/adc/imx7d_adc.c         | 4 +---
> >  drivers/iio/adc/imx8qxp-adc.c       | 4 +---
> >  drivers/iio/adc/mxs-lradc-adc.c     | 4 +---
> >  drivers/iio/adc/palmas_gpadc.c      | 4 +---
> >  drivers/iio/adc/rn5t618-adc.c       | 4 +---
> >  drivers/iio/adc/stm32-dfsdm-adc.c   | 4 +---
> >  drivers/iio/adc/stmpe-adc.c         | 4 +---
> >  drivers/iio/adc/ti-adc084s021.c     | 4 +---
> >  drivers/iio/adc/ti-ads131e08.c      | 8 ++------
> >  drivers/iio/adc/ti_am335x_adc.c     | 5 ++---
> >  drivers/iio/adc/twl4030-madc.c      | 4 +---
> >  drivers/iio/adc/viperboard_adc.c    | 4 +---
> >  drivers/iio/dac/ad5380.c            | 4 +---
> >  drivers/iio/dac/ad5764.c            | 4 +---
> >  drivers/iio/dac/ds4424.c            | 4 +---
> >  drivers/iio/dac/ti-dac7311.c        | 4 +---
> >  drivers/iio/dac/vf610_dac.c         | 4 +---
> >  drivers/iio/health/afe4403.c        | 4 +---
> >  drivers/iio/health/afe4404.c        | 4 +---
> >  drivers/iio/humidity/am2315.c       | 4 +---
> >  drivers/iio/humidity/dht11.c        | 4 +---
> >  drivers/iio/light/stk3310.c         | 4 +---
> >  drivers/iio/potentiostat/lmp91000.c | 4 +---
> >  drivers/iio/pressure/dlhl60d.c      | 4 +---
> >  drivers/iio/proximity/ping.c        | 4 +---
> >  drivers/iio/proximity/srf04.c       | 4 +---
> >  drivers/iio/temperature/mlx90632.c  | 4 +---
> >  41 files changed, 47 insertions(+), 130 deletions(-)
> > ---
> > base-commit: d7b8f8e20813f0179d8ef519541a3527e7661d3a
> > change-id: 20250822-enomam_logs-f66642957fb3
> > 
> > Best regards,  
> 
>
Re: [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages
Posted by Dixit Parmar 1 month, 1 week ago
On Mon, Aug 25, 2025 at 12:39:19PM +0100, Jonathan Cameron wrote:
> On Mon, 25 Aug 2025 09:31:50 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Fri, 22 Aug 2025 09:19:48 +0530
> > Dixit Parmar <dixitparmar19@gmail.com> wrote:
> > 
> > > The drivers do not require their own error messages for error
> > > -ENOMEM, memory allocation failures. So remove the dev_err
> > > messages from the probe().
> > > With these patches, all the iio drivers now has uniform handling
> > > of the -ENOMEM while device_allocation and trigger_allocation
> > > calls.
> > > 
> > > Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>  
> > Series looks fine to me, after the minor tweaks to commit messages
> > that Andy requested.  However as it touches a lot of drivers
> > I'd like to leave it on list a little longer.
> 
> I changed my mind after taking the dev_err_probe() series earlier.
> I'm rather too busy at the moment, so clearing this out now will reduce
> what I need to keep track of.
> 
> Fixed up the () that Andy asked for in commit messages and applied
> to the togreg branch of iio.git, pushed out initially as testing.
> 
> There is still the rest of the week (probably) in which I can add
> tags etc if anyone wants to give them before I push that out as
> a non rebasing tree.
> 
> Thanks,
> 
> Jonathan
Thanks Jonathan.