serial: 8250_core: fix coding style issues

[PATCH] serial: 8250_core: fix coding style issues

Posted by Osama Abdelkader 1 month, 1 week ago

Fix a few coding style issues in 8250_core.c:

- Remove redundant NULL initialization of a global pointer
- Add missing blank line after a variable declaration

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
 drivers/tty/serial/8250/8250_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index feb920c5b2e8..0d1d2eed2a5c 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
 		serial_unlink_irq_chain(up);
 }
 
-const struct uart_ops *univ8250_port_base_ops = NULL;
+const struct uart_ops *univ8250_port_base_ops;
 struct uart_ops univ8250_port_ops;
 
 static const struct uart_8250_ops univ8250_driver_ops = {
@@ -773,6 +773,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
 	 */
 	if (!has_acpi_companion(uart->port.dev)) {
 		struct mctrl_gpios *gpios = mctrl_gpio_init(&uart->port, 0);
+
 		if (IS_ERR(gpios)) {
 			ret = PTR_ERR(gpios);
 			goto err;
-- 
2.43.0

Re: [PATCH] serial: 8250_core: fix coding style issues

Posted by Jiri Slaby 1 month, 1 week ago

On 21. 08. 25, 19:58, Osama Abdelkader wrote:
> Fix a few coding style issues in 8250_core.c:
> 
> - Remove redundant NULL initialization of a global pointer
> - Add missing blank line after a variable declaration
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>   drivers/tty/serial/8250/8250_core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index feb920c5b2e8..0d1d2eed2a5c 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
>   		serial_unlink_irq_chain(up);
>   }
>   
> -const struct uart_ops *univ8250_port_base_ops = NULL;
> +const struct uart_ops *univ8250_port_base_ops;
>   struct uart_ops univ8250_port_ops;
>   
>   static const struct uart_8250_ops univ8250_driver_ops = {
> @@ -773,6 +773,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
>   	 */
>   	if (!has_acpi_companion(uart->port.dev)) {
>   		struct mctrl_gpios *gpios = mctrl_gpio_init(&uart->port, 0);
> +
>   		if (IS_ERR(gpios)) {

NACK to this one. It's a declaration with an initializer and the 'if' 
checks its value.

>   			ret = PTR_ERR(gpios);
>   			goto err;


-- 
js
suse labs

Re: [PATCH] serial: 8250_core: fix coding style issues

Posted by Osama Abdelkader 1 month, 1 week ago

On 8/22/25 6:30 AM, Jiri Slaby wrote:
> On 21. 08. 25, 19:58, Osama Abdelkader wrote:
>> Fix a few coding style issues in 8250_core.c:
>>
>> - Remove redundant NULL initialization of a global pointer
>> - Add missing blank line after a variable declaration
>>
>> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
>> ---
>>   drivers/tty/serial/8250/8250_core.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
>> index feb920c5b2e8..0d1d2eed2a5c 100644
>> --- a/drivers/tty/serial/8250/8250_core.c
>> +++ b/drivers/tty/serial/8250/8250_core.c
>> @@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
>>           serial_unlink_irq_chain(up);
>>   }
>>   -const struct uart_ops *univ8250_port_base_ops = NULL;
>> +const struct uart_ops *univ8250_port_base_ops;
>>   struct uart_ops univ8250_port_ops;
>>     static const struct uart_8250_ops univ8250_driver_ops = {
>> @@ -773,6 +773,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
>>        */
>>       if (!has_acpi_companion(uart->port.dev)) {
>>           struct mctrl_gpios *gpios = mctrl_gpio_init(&uart->port, 0);
>> +
>>           if (IS_ERR(gpios)) {
>
> NACK to this one. It's a declaration with an initializer and the 'if' checks its value.
Thanks for the review, I'm going to send v2.
>
>>               ret = PTR_ERR(gpios);
>>               goto err;
>
>

Re: [PATCH] serial: 8250_core: fix coding style issues

Posted by Greg KH 1 month, 1 week ago

On Thu, Aug 21, 2025 at 07:58:56PM +0200, Osama Abdelkader wrote:
> Fix a few coding style issues in 8250_core.c:
> 
> - Remove redundant NULL initialization of a global pointer
> - Add missing blank line after a variable declaration
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>  drivers/tty/serial/8250/8250_core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index feb920c5b2e8..0d1d2eed2a5c 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
>  		serial_unlink_irq_chain(up);
>  }
>  
> -const struct uart_ops *univ8250_port_base_ops = NULL;
> +const struct uart_ops *univ8250_port_base_ops;
>  struct uart_ops univ8250_port_ops;
>  
>  static const struct uart_8250_ops univ8250_driver_ops = {
> @@ -773,6 +773,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
>  	 */
>  	if (!has_acpi_companion(uart->port.dev)) {
>  		struct mctrl_gpios *gpios = mctrl_gpio_init(&uart->port, 0);
> +
>  		if (IS_ERR(gpios)) {
>  			ret = PTR_ERR(gpios);
>  			goto err;
> -- 
> 2.43.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot