[PATCH net-next 07/15] net: phy: aquantia: remove handling for get_rate_matching(PHY_INTERFACE_MODE_NA)

Vladimir Oltean posted 15 patches 1 month, 1 week ago
[PATCH net-next 07/15] net: phy: aquantia: remove handling for get_rate_matching(PHY_INTERFACE_MODE_NA)
Posted by Vladimir Oltean 1 month, 1 week ago
After commit 7642cc28fd37 ("net: phylink: fix PHY validation with rate
adaption"), the API contract changed and PHY drivers are no longer
required to respond to the .get_rate_matching() method for
PHY_INTERFACE_MODE_NA. This was later followed up by documentation
commit 6d4cfcf97986 ("net: phy: Update documentation for
get_rate_matching").

As such, handling PHY_INTERFACE_MODE_NA in the Aquantia PHY driver
implementation of this method is unnecessary and confusing. Remove it.

Cc: Sean Anderson <sean.anderson@seco.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/phy/aquantia/aquantia_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
index 9d704b7e3dc8..0f20ed6f96d8 100644
--- a/drivers/net/phy/aquantia/aquantia_main.c
+++ b/drivers/net/phy/aquantia/aquantia_main.c
@@ -1067,8 +1067,7 @@ static int aqr_gen2_get_rate_matching(struct phy_device *phydev,
 				      phy_interface_t iface)
 {
 	if (iface == PHY_INTERFACE_MODE_10GBASER ||
-	    iface == PHY_INTERFACE_MODE_2500BASEX ||
-	    iface == PHY_INTERFACE_MODE_NA)
+	    iface == PHY_INTERFACE_MODE_2500BASEX)
 		return RATE_MATCH_PAUSE;
 	return RATE_MATCH_NONE;
 }
-- 
2.34.1
Re: [PATCH net-next 07/15] net: phy: aquantia: remove handling for get_rate_matching(PHY_INTERFACE_MODE_NA)
Posted by Andrew Lunn 1 month, 1 week ago
On Thu, Aug 21, 2025 at 06:20:14PM +0300, Vladimir Oltean wrote:
> After commit 7642cc28fd37 ("net: phylink: fix PHY validation with rate
> adaption"), the API contract changed and PHY drivers are no longer
> required to respond to the .get_rate_matching() method for
> PHY_INTERFACE_MODE_NA. This was later followed up by documentation
> commit 6d4cfcf97986 ("net: phy: Update documentation for
> get_rate_matching").
> 
> As such, handling PHY_INTERFACE_MODE_NA in the Aquantia PHY driver
> implementation of this method is unnecessary and confusing. Remove it.
> 
> Cc: Sean Anderson <sean.anderson@seco.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew