[PATCH v2 0/6] DRM IDR to Xarray conversions

Sidhartha Kumar posted 6 patches 1 month, 1 week ago
There is a newer version of this series
drivers/gpu/drm/display/drm_dp_aux_dev.c | 38 ++++++--------
drivers/gpu/drm/drm_auth.c               | 22 ++++----
drivers/gpu/drm/drm_connector.c          | 26 ++++------
drivers/gpu/drm/drm_debugfs.c            | 19 +++----
drivers/gpu/drm/drm_gem.c                | 11 ++--
drivers/gpu/drm/drm_lease.c              | 15 +++---
drivers/gpu/drm/drm_mode_config.c        |  3 +-
drivers/gpu/drm/drm_syncobj.c            | 64 ++++++++----------------
include/drm/drm_auth.h                   |  9 ++--
include/drm/drm_device.h                 |  4 +-
include/drm/drm_file.h                   |  6 +--
include/drm/drm_mode_config.h            | 12 ++---
12 files changed, 86 insertions(+), 143 deletions(-)
[PATCH v2 0/6] DRM IDR to Xarray conversions
Posted by Sidhartha Kumar 1 month, 1 week ago
From: Sidhartha <sidhartha.kumar@oracle.com>

v1[1] -> v2:
  - rebase onto latest mainline v6.17-rc2
  - fix build error in patch 1 per Intel Test Robot

This series is part of a project to depcrecate the IDR in favor
of the Xarray. This simplifies the code as locking is handled by
the Xarray internally and removes the need for a seperate mutex to
proect the IDR.

The patches are from this tree and have been rebased to v6.17-rc2
https://git.infradead.org/?p=users/willy/xarray.git;a=shortlog;h=refs/heads/xarray-conv


The series has been compiled and tested with drivers/gpu/drm/tests/.kunitconfig
and passes all tests.

[15:22:04] Testing complete. Ran 608 tests: passed: 608
[15:22:04] Elapsed time: 34.792s total, 3.086s configuring, 31.541s building, 0.141s running

[1]: https://lore.kernel.org/dri-devel/20250818190046.157962-1-sidhartha.kumar@oracle.com/

Matthew Wilcox (6):
  drm: Convert aux_idr to XArray
  drm: Convert object_name_idr to XArray
  drm: Convert syncobj_idr to XArray
  drm: Convert magic_map to XArray
  drm: Convert lessee_idr to XArray
  drm: Convert tile_idr to XArray

 drivers/gpu/drm/display/drm_dp_aux_dev.c | 38 ++++++--------
 drivers/gpu/drm/drm_auth.c               | 22 ++++----
 drivers/gpu/drm/drm_connector.c          | 26 ++++------
 drivers/gpu/drm/drm_debugfs.c            | 19 +++----
 drivers/gpu/drm/drm_gem.c                | 11 ++--
 drivers/gpu/drm/drm_lease.c              | 15 +++---
 drivers/gpu/drm/drm_mode_config.c        |  3 +-
 drivers/gpu/drm/drm_syncobj.c            | 64 ++++++++----------------
 include/drm/drm_auth.h                   |  9 ++--
 include/drm/drm_device.h                 |  4 +-
 include/drm/drm_file.h                   |  6 +--
 include/drm/drm_mode_config.h            | 12 ++---
 12 files changed, 86 insertions(+), 143 deletions(-)

-- 
2.43.0
Re: [PATCH v2 0/6] DRM IDR to Xarray conversions
Posted by Jani Nikula 1 month, 1 week ago
On Thu, 21 Aug 2025, Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
> From: Sidhartha <sidhartha.kumar@oracle.com>
>
> v1[1] -> v2:
>   - rebase onto latest mainline v6.17-rc2
>   - fix build error in patch 1 per Intel Test Robot
>
> This series is part of a project to depcrecate the IDR in favor
> of the Xarray. This simplifies the code as locking is handled by
> the Xarray internally and removes the need for a seperate mutex to
> proect the IDR.

It would be great if the commit messages mentioned whether the
identifiers are expected to remain the same in the conversion.

BR,
Jani.

>
> The patches are from this tree and have been rebased to v6.17-rc2
> https://git.infradead.org/?p=users/willy/xarray.git;a=shortlog;h=refs/heads/xarray-conv
>
>
> The series has been compiled and tested with drivers/gpu/drm/tests/.kunitconfig
> and passes all tests.
>
> [15:22:04] Testing complete. Ran 608 tests: passed: 608
> [15:22:04] Elapsed time: 34.792s total, 3.086s configuring, 31.541s building, 0.141s running
>
> [1]: https://lore.kernel.org/dri-devel/20250818190046.157962-1-sidhartha.kumar@oracle.com/
>
> Matthew Wilcox (6):
>   drm: Convert aux_idr to XArray
>   drm: Convert object_name_idr to XArray
>   drm: Convert syncobj_idr to XArray
>   drm: Convert magic_map to XArray
>   drm: Convert lessee_idr to XArray
>   drm: Convert tile_idr to XArray
>
>  drivers/gpu/drm/display/drm_dp_aux_dev.c | 38 ++++++--------
>  drivers/gpu/drm/drm_auth.c               | 22 ++++----
>  drivers/gpu/drm/drm_connector.c          | 26 ++++------
>  drivers/gpu/drm/drm_debugfs.c            | 19 +++----
>  drivers/gpu/drm/drm_gem.c                | 11 ++--
>  drivers/gpu/drm/drm_lease.c              | 15 +++---
>  drivers/gpu/drm/drm_mode_config.c        |  3 +-
>  drivers/gpu/drm/drm_syncobj.c            | 64 ++++++++----------------
>  include/drm/drm_auth.h                   |  9 ++--
>  include/drm/drm_device.h                 |  4 +-
>  include/drm/drm_file.h                   |  6 +--
>  include/drm/drm_mode_config.h            | 12 ++---
>  12 files changed, 86 insertions(+), 143 deletions(-)

-- 
Jani Nikula, Intel
Re: [PATCH v2 0/6] DRM IDR to Xarray conversions
Posted by Sidhartha Kumar 1 month, 1 week ago
On 8/22/25 8:33 AM, Jani Nikula wrote:
> On Thu, 21 Aug 2025, Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
>> From: Sidhartha <sidhartha.kumar@oracle.com>
>>
>> v1[1] -> v2:
>>    - rebase onto latest mainline v6.17-rc2
>>    - fix build error in patch 1 per Intel Test Robot
>>
>> This series is part of a project to depcrecate the IDR in favor
>> of the Xarray. This simplifies the code as locking is handled by
>> the Xarray internally and removes the need for a seperate mutex to
>> proect the IDR.
> 
> It would be great if the commit messages mentioned whether the
> identifiers are expected to remain the same in the conversion.
> 

By identifiers do you mean if the name of the previous idr variable is 
the same as the XArray variable that is introduced? Sure I can add that 
in a v3.

Thanks,
Sid

> BR,
> Jani.
> 
>>
>> The patches are from this tree and have been rebased to v6.17-rc2
>> https://git.infradead.org/?p=users/willy/xarray.git;a=shortlog;h=refs/heads/xarray-conv
>>
>>
>> The series has been compiled and tested with drivers/gpu/drm/tests/.kunitconfig
>> and passes all tests.
>>
>> [15:22:04] Testing complete. Ran 608 tests: passed: 608
>> [15:22:04] Elapsed time: 34.792s total, 3.086s configuring, 31.541s building, 0.141s running
>>
>> [1]: https://lore.kernel.org/dri-devel/20250818190046.157962-1-sidhartha.kumar@oracle.com/
>>
>> Matthew Wilcox (6):
>>    drm: Convert aux_idr to XArray
>>    drm: Convert object_name_idr to XArray
>>    drm: Convert syncobj_idr to XArray
>>    drm: Convert magic_map to XArray
>>    drm: Convert lessee_idr to XArray
>>    drm: Convert tile_idr to XArray
>>
>>   drivers/gpu/drm/display/drm_dp_aux_dev.c | 38 ++++++--------
>>   drivers/gpu/drm/drm_auth.c               | 22 ++++----
>>   drivers/gpu/drm/drm_connector.c          | 26 ++++------
>>   drivers/gpu/drm/drm_debugfs.c            | 19 +++----
>>   drivers/gpu/drm/drm_gem.c                | 11 ++--
>>   drivers/gpu/drm/drm_lease.c              | 15 +++---
>>   drivers/gpu/drm/drm_mode_config.c        |  3 +-
>>   drivers/gpu/drm/drm_syncobj.c            | 64 ++++++++----------------
>>   include/drm/drm_auth.h                   |  9 ++--
>>   include/drm/drm_device.h                 |  4 +-
>>   include/drm/drm_file.h                   |  6 +--
>>   include/drm/drm_mode_config.h            | 12 ++---
>>   12 files changed, 86 insertions(+), 143 deletions(-)
>
Re: [PATCH v2 0/6] DRM IDR to Xarray conversions
Posted by Matthew Wilcox 1 month, 1 week ago
On Fri, Aug 22, 2025 at 10:36:24AM -0400, Sidhartha Kumar wrote:
> On 8/22/25 8:33 AM, Jani Nikula wrote:
> > It would be great if the commit messages mentioned whether the
> > identifiers are expected to remain the same in the conversion.
> 
> By identifiers do you mean if the name of the previous idr variable is the
> same as the XArray variable that is introduced? Sure I can add that in a v3.

I think Jani means that the actual numbers assigned should remain the
saame after the conversion.
Re: [PATCH v2 0/6] DRM IDR to Xarray conversions
Posted by Jani Nikula 1 month, 1 week ago
On Fri, 22 Aug 2025, Matthew Wilcox <willy@infradead.org> wrote:
> On Fri, Aug 22, 2025 at 10:36:24AM -0400, Sidhartha Kumar wrote:
>> On 8/22/25 8:33 AM, Jani Nikula wrote:
>> > It would be great if the commit messages mentioned whether the
>> > identifiers are expected to remain the same in the conversion.
>> 
>> By identifiers do you mean if the name of the previous idr variable is the
>> same as the XArray variable that is introduced? Sure I can add that in a v3.
>
> I think Jani means that the actual numbers assigned should remain the
> saame after the conversion.

Yes. Do they?

BR,
Jani.


-- 
Jani Nikula, Intel
Re: [PATCH v2 0/6] DRM IDR to Xarray conversions
Posted by Sidhartha Kumar 1 month, 1 week ago
On 8/25/25 2:52 AM, Jani Nikula wrote:
> On Fri, 22 Aug 2025, Matthew Wilcox <willy@infradead.org> wrote:
>> On Fri, Aug 22, 2025 at 10:36:24AM -0400, Sidhartha Kumar wrote:
>>> On 8/22/25 8:33 AM, Jani Nikula wrote:
>>>> It would be great if the commit messages mentioned whether the
>>>> identifiers are expected to remain the same in the conversion.
>>>
>>> By identifiers do you mean if the name of the previous idr variable is the
>>> same as the XArray variable that is introduced? Sure I can add that in a v3.
>>
>> I think Jani means that the actual numbers assigned should remain the
>> saame after the conversion.
> 
> Yes. Do they?

Yes, they'll remain the same after the patches. I'll add this to the 
commit messages in v3.

Thanks,
Sid


> 
> BR,
> Jani.
> 
>