[PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend

Bharat Uppal posted 1 patch 1 month, 1 week ago
drivers/ufs/host/ufs-exynos.c | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend
Posted by Bharat Uppal 1 month, 1 week ago
On FSD platform, gating the reference clock (ref_clk) and putting the
UFS device in reset by asserting the reset signal during UFS suspend,
improves the power savings and ensures the PHY is fully turned off.

These operations are added as FSD specific suspend hook to avoid
unintended side effects on other SoCs supported by this driver.

Signed-off-by: Nimesh Sati  <nimesh.sati@samsung.com>
Signed-off-by: Bharat Uppal <bharat.uppal@samsung.com>
---
 drivers/ufs/host/ufs-exynos.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index 3e545af536e5..4d0f7d6b84fe 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -1896,6 +1896,13 @@ static int fsd_ufs_pre_pwr_change(struct exynos_ufs *ufs,
 	return 0;
 }
 
+static int fsd_ufs_suspend(struct exynos_ufs *ufs)
+{
+	exynos_ufs_gate_clks(ufs);
+	hci_writel(ufs, 0, HCI_GPIO_OUT);
+	return 0;
+}
+
 static inline u32 get_mclk_period_unipro_18(struct exynos_ufs *ufs)
 {
 	return (16 * 1000 * 1000000UL / ufs->mclk_rate);
@@ -2162,6 +2169,7 @@ static const struct exynos_ufs_drv_data fsd_ufs_drvs = {
 	.pre_link               = fsd_ufs_pre_link,
 	.post_link              = fsd_ufs_post_link,
 	.pre_pwr_change         = fsd_ufs_pre_pwr_change,
+	.suspend                = fsd_ufs_suspend,
 };
 
 static const struct exynos_ufs_drv_data gs101_ufs_drvs = {
-- 
2.49.0
Re: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend
Posted by Martin K. Petersen 1 month ago
Bharat,

> On FSD platform, gating the reference clock (ref_clk) and putting the
> UFS device in reset by asserting the reset signal during UFS suspend,
> improves the power savings and ensures the PHY is fully turned off.

Applied to 6.18/scsi-staging, thanks!

-- 
Martin K. Petersen
Re: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend
Posted by Bart Van Assche 1 month ago
On 8/20/25 10:39 PM, Bharat Uppal wrote:
> On FSD platform, gating the reference clock (ref_clk) and putting the
> UFS device in reset by asserting the reset signal during UFS suspend,
> improves the power savings and ensures the PHY is fully turned off.
> 
> These operations are added as FSD specific suspend hook to avoid
> unintended side effects on other SoCs supported by this driver.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>