[PATCH 1/2] kselftest/arm64/gcs: Correctly check return value when disabling GCS

Thomas Weißschuh posted 2 patches 1 month, 1 week ago
[PATCH 1/2] kselftest/arm64/gcs: Correctly check return value when disabling GCS
Posted by Thomas Weißschuh 1 month, 1 week ago
The return value was not assigned to 'ret', so the check afterwards
does not do anything.

Fixes: 3d37d4307e0f ("kselftest/arm64: Add very basic GCS test program")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 tools/testing/selftests/arm64/gcs/basic-gcs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/arm64/gcs/basic-gcs.c b/tools/testing/selftests/arm64/gcs/basic-gcs.c
index 54f9c888249d74451e1432280a395156ce72e56c..100d2a983155f7347a19b2b8b88f9494dc6a51d5 100644
--- a/tools/testing/selftests/arm64/gcs/basic-gcs.c
+++ b/tools/testing/selftests/arm64/gcs/basic-gcs.c
@@ -410,7 +410,7 @@ int main(void)
 	}
 
 	/* One last test: disable GCS, we can do this one time */
-	my_syscall5(__NR_prctl, PR_SET_SHADOW_STACK_STATUS, 0, 0, 0, 0);
+	ret = my_syscall5(__NR_prctl, PR_SET_SHADOW_STACK_STATUS, 0, 0, 0, 0);
 	if (ret != 0)
 		ksft_print_msg("Failed to disable GCS: %d\n", ret);
 

-- 
2.50.1

Re: [PATCH 1/2] kselftest/arm64/gcs: Correctly check return value when disabling GCS
Posted by Mark Brown 1 month, 1 week ago
On Thu, Aug 21, 2025 at 05:13:02PM +0200, Thomas Weißschuh wrote:
> The return value was not assigned to 'ret', so the check afterwards
> does not do anything.

Reviewed-by: Mark Brown <broonie@kernel.org>