Add clarification to comment for memory hotplug callback ordering as the
current comment does not provide clear language on which callback happens
first.

Acked-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
v2:
- Clearer comment suggestion from DavidH.
---
 include/linux/memory.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/memory.h b/include/linux/memory.h
index 40eb70ccb09d..de5c0d8e8925 100644
--- a/include/linux/memory.h
+++ b/include/linux/memory.h
@@ -115,8 +115,8 @@ struct notifier_block;
 struct mem_section;
 
 /*
- * Priorities for the hotplug memory callback routines (stored in decreasing
- * order in the callback chain)
+ * Priorities for the hotplug memory callback routines. Invoked from
+ * high to low. Higher priorities corresponds to higher numbers.
  */
 #define DEFAULT_CALLBACK_PRI	0
 #define SLAB_CALLBACK_PRI	1
-- 
2.50.1

On 20.08.25 21:47, Dave Jiang wrote:
> Add clarification to comment for memory hotplug callback ordering as the
> current comment does not provide clear language on which callback happens
> first.
> 
> Acked-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> v2:
> - Clearer comment suggestion from DavidH.
> ---
>   include/linux/memory.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 40eb70ccb09d..de5c0d8e8925 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -115,8 +115,8 @@ struct notifier_block;
>   struct mem_section;
>   
>   /*
> - * Priorities for the hotplug memory callback routines (stored in decreasing
> - * order in the callback chain)
> + * Priorities for the hotplug memory callback routines. Invoked from
> + * high to low. Higher priorities corresponds to higher numbers.

Minor nit: s/corresponds/correspond/

-- 
Cheers

David / dhildenb

On Thu, 21 Aug 2025 23:17:38 +0200
David Hildenbrand <david@redhat.com> wrote:

> On 20.08.25 21:47, Dave Jiang wrote:
> > Add clarification to comment for memory hotplug callback ordering as the
> > current comment does not provide clear language on which callback happens
> > first.
> > 
> > Acked-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > ---
> > v2:
> > - Clearer comment suggestion from DavidH.
> > ---
> >   include/linux/memory.h | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/memory.h b/include/linux/memory.h
> > index 40eb70ccb09d..de5c0d8e8925 100644
> > --- a/include/linux/memory.h
> > +++ b/include/linux/memory.h
> > @@ -115,8 +115,8 @@ struct notifier_block;
> >   struct mem_section;
> >   
> >   /*
> > - * Priorities for the hotplug memory callback routines (stored in decreasing
> > - * order in the callback chain)
> > + * Priorities for the hotplug memory callback routines. Invoked from
> > + * high to low. Higher priorities corresponds to higher numbers.  
> 
> Minor nit: s/corresponds/correspond/

With that tidied up
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

>