[PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver

Jean-François Lessard posted 4 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Jean-François Lessard 1 month, 2 weeks ago
Signed-off-by: Jean-François Lessard <jefflessard3@gmail.com>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index daf520a13..55afed22f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25402,6 +25402,12 @@ W:	http://sourceforge.net/projects/tlan/
 F:	Documentation/networking/device_drivers/ethernet/ti/tlan.rst
 F:	drivers/net/ethernet/ti/tlan.*
 
+TM16XX-COMPATIBLE LED CONTROLLERS DISPLAY DRIVER
+M:	Jean-François Lessard <jefflessard3@gmail.com>
+S:	Maintained
+F:	Documentation/devicetree/bindings/auxdisplay/titanmec,tm16xx.yaml
+F:	drivers/auxdisplay/tm16xx.c
+
 TMIO/SDHI MMC DRIVER
 M:	Wolfram Sang <wsa+renesas@sang-engineering.com>
 L:	linux-mmc@vger.kernel.org
-- 
2.43.0

Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Andy Shevchenko 1 month, 2 weeks ago
On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
<jefflessard3@gmail.com> wrote:

Besides the missing commit message, the main part of this patch should
be merged with the patch 2 where the YAML file is being added.
Otherwise it will be a dangling file. I dunno if DT tooling has its
own concept of a maintainer database, though.


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Conor Dooley 1 month, 2 weeks ago
On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> <jefflessard3@gmail.com> wrote:
> 
> Besides the missing commit message, the main part of this patch should
> be merged with the patch 2 where the YAML file is being added.
> Otherwise it will be a dangling file. I dunno if DT tooling has its
> own concept of a maintainer database, though.

get_maintainer.pl will pull the maintainer out of the file, so it won't be
truly dangling without a way to associate Jean-François with this file, if
that;s what you mean.
Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Andy Shevchenko 1 month, 2 weeks ago
On Wed, Aug 20, 2025 at 10:52 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> > On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> > <jefflessard3@gmail.com> wrote:
> >
> > Besides the missing commit message, the main part of this patch should
> > be merged with the patch 2 where the YAML file is being added.
> > Otherwise it will be a dangling file. I dunno if DT tooling has its
> > own concept of a maintainer database, though.
>
> get_maintainer.pl will pull the maintainer out of the file, so it won't be
> truly dangling without a way to associate Jean-François with this file, if
> that;s what you mean.

Let's assume patch 2 is applied and patch 4 is not, what will be the
result of get_maintainer.pl for the YAML file?


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Conor Dooley 1 month, 1 week ago
On Wed, Aug 20, 2025 at 11:29:47PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 20, 2025 at 10:52 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> > > On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> > > <jefflessard3@gmail.com> wrote:
> > >
> > > Besides the missing commit message, the main part of this patch should
> > > be merged with the patch 2 where the YAML file is being added.
> > > Otherwise it will be a dangling file. I dunno if DT tooling has its
> > > own concept of a maintainer database, though.
> >
> > get_maintainer.pl will pull the maintainer out of the file, so it won't be
> > truly dangling without a way to associate Jean-François with this file, if
> > that;s what you mean.
> 
> Let's assume patch 2 is applied and patch 4 is not, what will be the
> result of get_maintainer.pl for the YAML file?

Andy Shevchenko <andy@kernel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
Geert Uytterhoeven <geert@linux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
"Jean-François Lessard" <jefflessard3@gmail.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:471/471=100%,in file)
                                                                                                                    ^^^^^^^

devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)
AUXILIARY DISPLAY DRIVERS status: Odd Fixes

Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Andy Shevchenko 1 month, 1 week ago
On Thu, Aug 21, 2025 at 8:40 PM Conor Dooley <conor@kernel.org> wrote:
> On Wed, Aug 20, 2025 at 11:29:47PM +0300, Andy Shevchenko wrote:
> > On Wed, Aug 20, 2025 at 10:52 PM Conor Dooley <conor@kernel.org> wrote:
> > > On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> > > > On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> > > > <jefflessard3@gmail.com> wrote:
> > > >
> > > > Besides the missing commit message, the main part of this patch should
> > > > be merged with the patch 2 where the YAML file is being added.
> > > > Otherwise it will be a dangling file. I dunno if DT tooling has its
> > > > own concept of a maintainer database, though.
> > >
> > > get_maintainer.pl will pull the maintainer out of the file, so it won't be
> > > truly dangling without a way to associate Jean-François with this file, if
> > > that;s what you mean.
> >
> > Let's assume patch 2 is applied and patch 4 is not, what will be the
> > result of get_maintainer.pl for the YAML file?
>
> Andy Shevchenko <andy@kernel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
> Geert Uytterhoeven <geert@linux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
> Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> "Jean-François Lessard" <jefflessard3@gmail.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:471/471=100%,in file)
>                                                                                                                     ^^^^^^^

Which is a git lookup heuristics. If you disable that, there is no
maintainer for the file. Try with --m and --no-git (IIRC the option
name).

> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@vger.kernel.org (open list)
> AUXILIARY DISPLAY DRIVERS status: Odd Fixes


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Andy Shevchenko 1 month, 1 week ago
On Thu, Aug 21, 2025 at 10:33 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Aug 21, 2025 at 8:40 PM Conor Dooley <conor@kernel.org> wrote:
> > On Wed, Aug 20, 2025 at 11:29:47PM +0300, Andy Shevchenko wrote:
> > > On Wed, Aug 20, 2025 at 10:52 PM Conor Dooley <conor@kernel.org> wrote:
> > > > On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> > > > > On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> > > > > <jefflessard3@gmail.com> wrote:
> > > > >
> > > > > Besides the missing commit message, the main part of this patch should
> > > > > be merged with the patch 2 where the YAML file is being added.
> > > > > Otherwise it will be a dangling file. I dunno if DT tooling has its
> > > > > own concept of a maintainer database, though.
> > > >
> > > > get_maintainer.pl will pull the maintainer out of the file, so it won't be
> > > > truly dangling without a way to associate Jean-François with this file, if
> > > > that;s what you mean.
> > >
> > > Let's assume patch 2 is applied and patch 4 is not, what will be the
> > > result of get_maintainer.pl for the YAML file?
> >
> > Andy Shevchenko <andy@kernel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
> > Geert Uytterhoeven <geert@linux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
> > Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > "Jean-François Lessard" <jefflessard3@gmail.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:471/471=100%,in file)
> >                                                                                                                     ^^^^^^^
>
> Which is a git lookup heuristics. If you disable that, there is no
> maintainer for the file. Try with --m and --no-git (IIRC the option
> name).

Actually doesn't checkpatch complain in this case?

> > devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > linux-kernel@vger.kernel.org (open list)
> > AUXILIARY DISPLAY DRIVERS status: Odd Fixes


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Conor Dooley 1 month, 1 week ago
On Thu, Aug 21, 2025 at 10:35:07PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 21, 2025 at 10:33 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Aug 21, 2025 at 8:40 PM Conor Dooley <conor@kernel.org> wrote:
> > > On Wed, Aug 20, 2025 at 11:29:47PM +0300, Andy Shevchenko wrote:
> > > > On Wed, Aug 20, 2025 at 10:52 PM Conor Dooley <conor@kernel.org> wrote:
> > > > > On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> > > > > > On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> > > > > > <jefflessard3@gmail.com> wrote:
> > > > > >
> > > > > > Besides the missing commit message, the main part of this patch should
> > > > > > be merged with the patch 2 where the YAML file is being added.
> > > > > > Otherwise it will be a dangling file. I dunno if DT tooling has its
> > > > > > own concept of a maintainer database, though.
> > > > >
> > > > > get_maintainer.pl will pull the maintainer out of the file, so it won't be
> > > > > truly dangling without a way to associate Jean-François with this file, if
> > > > > that;s what you mean.
> > > >
> > > > Let's assume patch 2 is applied and patch 4 is not, what will be the
> > > > result of get_maintainer.pl for the YAML file?
> > >
> > > Andy Shevchenko <andy@kernel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
> > > Geert Uytterhoeven <geert@linux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
> > > Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > "Jean-François Lessard" <jefflessard3@gmail.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:471/471=100%,in file)
> > >                                                                                                                     ^^^^^^^
> >
> > Which is a git lookup heuristics. If you disable that, there is no
> > maintainer for the file. Try with --m and --no-git (IIRC the option
> > name).

Also, I think linewrap might done some fuckery cos it was the
"in file" I was pointing to, pretty sure that's not coming from git.
I tried ./scripts/get_maintainer.pl --nogit --nogit-fallback -f Documentation/devicetree/bindings/auxdisplay/titanmec,tm16xx.yaml
(I think --nogit-fallback is the salient option, --nogit is a default
actually) and I got:
Andy Shevchenko <andy@kernel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
Geert Uytterhoeven <geert@linux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
"Jean-François Lessard" <jefflessard3@gmail.com> (in file)
                                                  ^^^^^^^
and the in file still appears.
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)
AUXILIARY DISPLAY DRIVERS status: Odd Fixes

> Actually doesn't checkpatch complain in this case?

The usual warning about MAINTAINERS appears ye, the one that appears
whenever a file is moved, created or deleted. I personally don't care
about that, as long as the end result of a series deals with it since
the file will produce the correct maintainer list in a bisection etc
anyway. Of course, your subsystem your prerogative.
Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver
Posted by Andy Shevchenko 1 month, 1 week ago
On Thu, Aug 21, 2025 at 11:11 PM Conor Dooley <conor@kernel.org> wrote:
> On Thu, Aug 21, 2025 at 10:35:07PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 21, 2025 at 10:33 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Thu, Aug 21, 2025 at 8:40 PM Conor Dooley <conor@kernel.org> wrote:
> > > > On Wed, Aug 20, 2025 at 11:29:47PM +0300, Andy Shevchenko wrote:
> > > > > On Wed, Aug 20, 2025 at 10:52 PM Conor Dooley <conor@kernel.org> wrote:
> > > > > > On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> > > > > > > On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> > > > > > > <jefflessard3@gmail.com> wrote:
> > > > > > >
> > > > > > > Besides the missing commit message, the main part of this patch should
> > > > > > > be merged with the patch 2 where the YAML file is being added.
> > > > > > > Otherwise it will be a dangling file. I dunno if DT tooling has its
> > > > > > > own concept of a maintainer database, though.
> > > > > >
> > > > > > get_maintainer.pl will pull the maintainer out of the file, so it won't be
> > > > > > truly dangling without a way to associate Jean-François with this file, if
> > > > > > that;s what you mean.
> > > > >
> > > > > Let's assume patch 2 is applied and patch 4 is not, what will be the
> > > > > result of get_maintainer.pl for the YAML file?
> > > >
> > > > Andy Shevchenko <andy@kernel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
> > > > Geert Uytterhoeven <geert@linux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
> > > > Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > > Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > > Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > > "Jean-François Lessard" <jefflessard3@gmail.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:471/471=100%,in file)
> > > >                                                                                                                     ^^^^^^^
> > >
> > > Which is a git lookup heuristics. If you disable that, there is no
> > > maintainer for the file. Try with --m and --no-git (IIRC the option
> > > name).
>
> Also, I think linewrap might done some fuckery cos it was the
> "in file" I was pointing to, pretty sure that's not coming from git.
> I tried ./scripts/get_maintainer.pl --nogit --nogit-fallback -f Documentation/devicetree/bindings/auxdisplay/titanmec,tm16xx.yaml
> (I think --nogit-fallback is the salient option, --nogit is a default
> actually) and I got:
> Andy Shevchenko <andy@kernel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
> Geert Uytterhoeven <geert@linux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
> Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> "Jean-François Lessard" <jefflessard3@gmail.com> (in file)
>                                                   ^^^^^^^
> and the in file still appears.

Cool, thanks for providing this, TIL! Is this documented somewhere? I
mean how should I know that YAML files are not orphaned by default
(assuming they are correct and have a "maintainer" field inside)?

> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@vger.kernel.org (open list)
> AUXILIARY DISPLAY DRIVERS status: Odd Fixes
>
> > Actually doesn't checkpatch complain in this case?
>
> The usual warning about MAINTAINERS appears ye, the one that appears
> whenever a file is moved, created or deleted. I personally don't care
> about that, as long as the end result of a series deals with it since
> the file will produce the correct maintainer list in a bisection etc
> anyway. Of course, your subsystem your prerogative.

Shouldn't checkpatch also be fixed at least for that part as
get_maintainer does?

-- 
With Best Regards,
Andy Shevchenko