[PATCH v2 2/3] reset: th1520: Support the new compatible for VO-subsystem controller

Yao Zi posted 3 patches 1 month, 2 weeks ago
[PATCH v2 2/3] reset: th1520: Support the new compatible for VO-subsystem controller
Posted by Yao Zi 1 month, 2 weeks ago
The reset controller for VO-subsystem is previously described with
compatible "thead,th1520-reset", which is misleading since it implies
control over all reset units on the SoC.

A new compatible, "thead,th1520-reset-vo", has been introduced to
describe the controller's scope explicitly, while the old one has been
deprecated. Let's support the compatible in the driver.

Fixes: 4a65326311ab ("reset: thead: Add TH1520 reset controller driver")
Reported-by: Icenowy Zheng <uwu@icenowy.me>
Co-developed-by: Michal Wilczynski <m.wilczynski@samsung.com>
Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
Signed-off-by: Yao Zi <ziyao@disroot.org>
---
 drivers/reset/reset-th1520.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-th1520.c b/drivers/reset/reset-th1520.c
index 14d964a9c6b6..4c8ea35b174e 100644
--- a/drivers/reset/reset-th1520.c
+++ b/drivers/reset/reset-th1520.c
@@ -154,6 +154,7 @@ static int th1520_reset_probe(struct platform_device *pdev)
 
 static const struct of_device_id th1520_reset_match[] = {
 	{ .compatible = "thead,th1520-reset" },
+	{ .compatible = "thead,th1520-reset-vo" },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, th1520_reset_match);
-- 
2.50.1
Re: [PATCH v2 2/3] reset: th1520: Support the new compatible for VO-subsystem controller
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On Wed, Aug 20, 2025 at 07:42:44AM +0000, Yao Zi wrote:
> The reset controller for VO-subsystem is previously described with
> compatible "thead,th1520-reset", which is misleading since it implies
> control over all reset units on the SoC.
> 
> A new compatible, "thead,th1520-reset-vo", has been introduced to
> describe the controller's scope explicitly, while the old one has been
> deprecated. Let's support the compatible in the driver.
> 
> Fixes: 4a65326311ab ("reset: thead: Add TH1520 reset controller driver")
> Reported-by: Icenowy Zheng <uwu@icenowy.me>

Missing Closes tag. Explain where is the bug. "Implies" different
meaning is not a bug. You need to describe user observable issues of
this bug.

Best regards,
Krzysztof