[PATCH v2 6/6] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML

Julien Massot posted 6 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH v2 6/6] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
Posted by Julien Massot 1 month, 2 weeks ago
Convert the existing text-based DT binding for MT8183 sound cards using
MT6358 and various other codecs to a YAML schema.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 .../sound/mediatek,mt8183_mt6358_ts3a227.yaml      | 59 ++++++++++++++++++++++
 .../sound/mt8183-mt6358-ts3a227-max98357.txt       | 25 ---------
 2 files changed, 59 insertions(+), 25 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a227.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a227.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..048fe62715d67d44daa08e75a63c782238815689
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a227.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mediatek,mt8183_mt6358_ts3a227.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT8183 sound card with MT6358, TS3A227, and MAX98357/RT1015 codecs
+
+maintainers:
+  - Julien Massot <julien.massot@collabora.com>
+
+description:
+  Binding for MediaTek MT8183 SoC-based sound cards using the MT6358 codec,
+  with optional TS3A227 headset codec, EC codec (via Chrome EC), and HDMI audio.
+  Speaker amplifier can be one of MAX98357A/B, RT1015, or RT1015P.
+
+properties:
+  compatible:
+    enum:
+      - mediatek,mt8183_mt6358_ts3a227_max98357
+      - mediatek,mt8183_mt6358_ts3a227_max98357b
+      - mediatek,mt8183_mt6358_ts3a227_rt1015
+      - mediatek,mt8183_mt6358_ts3a227_rt1015p
+
+  mediatek,platform:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: Phandle to the MT8183 ASoC platform node (e.g., AFE).
+
+  mediatek,headset-codec:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: Phandle to the TS3A227 headset codec.
+
+  mediatek,ec-codec:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: |
+      Optional phandle to a ChromeOS EC codec node.
+      See bindings in google,cros-ec-codec.yaml.
+
+  mediatek,hdmi-codec:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: Optional phandle to an HDMI audio codec node.
+
+required:
+  - compatible
+  - mediatek,platform
+
+additionalProperties: false
+
+examples:
+  - |
+    sound {
+        compatible = "mediatek,mt8183_mt6358_ts3a227_max98357";
+        mediatek,headset-codec = <&ts3a227>;
+        mediatek,ec-codec = <&ec_codec>;
+        mediatek,hdmi-codec = <&it6505dptx>;
+        mediatek,platform = <&afe>;
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt b/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
deleted file mode 100644
index ecd46ed8eb98b99d0f2cc9eeca5f6d0aef6a5ada..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MT8183 with MT6358, TS3A227, MAX98357, and RT1015 CODECS
-
-Required properties:
-- compatible : "mediatek,mt8183_mt6358_ts3a227_max98357" for MAX98357A codec
-               "mediatek,mt8183_mt6358_ts3a227_max98357b" for MAX98357B codec
-               "mediatek,mt8183_mt6358_ts3a227_rt1015" for RT1015 codec
-               "mediatek,mt8183_mt6358_ts3a227_rt1015p" for RT1015P codec
-- mediatek,platform: the phandle of MT8183 ASoC platform
-
-Optional properties:
-- mediatek,headset-codec: the phandles of ts3a227 codecs
-- mediatek,ec-codec: the phandle of EC codecs.
-                     See google,cros-ec-codec.txt for more details.
-- mediatek,hdmi-codec: the phandles of HDMI codec
-
-Example:
-
-	sound {
-		compatible = "mediatek,mt8183_mt6358_ts3a227_max98357";
-		mediatek,headset-codec = <&ts3a227>;
-		mediatek,ec-codec = <&ec_codec>;
-		mediatek,hdmi-codec = <&it6505dptx>;
-		mediatek,platform = <&afe>;
-	};
-

-- 
2.50.1
Re: [PATCH v2 6/6] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
Posted by Rob Herring 1 month, 1 week ago
On Wed, Aug 20, 2025 at 03:44:57PM +0200, Julien Massot wrote:
> Convert the existing text-based DT binding for MT8183 sound cards using
> MT6358 and various other codecs to a YAML schema.

In the subject (on all the patches), avoid saying 'binding' twice and I 
prefer 'DT schema' over YAML. Lot's of things are YAML, but only one 
thing is DT schema.

> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
>  .../sound/mediatek,mt8183_mt6358_ts3a227.yaml      | 59 ++++++++++++++++++++++
>  .../sound/mt8183-mt6358-ts3a227-max98357.txt       | 25 ---------
>  2 files changed, 59 insertions(+), 25 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a227.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a227.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..048fe62715d67d44daa08e75a63c782238815689
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a227.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mediatek,mt8183_mt6358_ts3a227.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT8183 sound card with MT6358, TS3A227, and MAX98357/RT1015 codecs
> +
> +maintainers:
> +  - Julien Massot <julien.massot@collabora.com>
> +
> +description:
> +  Binding for MediaTek MT8183 SoC-based sound cards using the MT6358 codec,

Drop 'Binding for '.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

And thank you for jumping on all these Mediatek bindings.

Rob
Re: [PATCH v2 6/6] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
Posted by Julien Massot 1 month, 1 week ago
On Fri, 2025-08-22 at 09:46 -0500, Rob Herring wrote:
> On Wed, Aug 20, 2025 at 03:44:57PM +0200, Julien Massot wrote:
> > Convert the existing text-based DT binding for MT8183 sound cards
> > using
> > MT6358 and various other codecs to a YAML schema.
> 
> In the subject (on all the patches), avoid saying 'binding' twice and I 
> prefer 'DT schema' over YAML. Lot's of things are YAML, but only one 
> thing is DT schema.

Ok, I fixed all the commit messages and replaced 'YAML' by 'DT schema'.

> 
> > 
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com>
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > ---
> >  .../sound/mediatek,mt8183_mt6358_ts3a227.yaml      | 59
> > ++++++++++++++++++++++
> >  .../sound/mt8183-mt6358-ts3a227-max98357.txt       | 25 ---------
> >  2 files changed, 59 insertions(+), 25 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a2
> > 27.yaml
> > b/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a2
> > 27.yaml
> > new file mode 100644
> > index
> > 0000000000000000000000000000000000000000..048fe62715d67d44daa08e75a63c
> > 782238815689
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/sound/mediatek,mt8183_mt6358_ts3a2
> > 27.yaml
> > @@ -0,0 +1,59 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/sound/mediatek,mt8183_mt6358_ts3a227.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek MT8183 sound card with MT6358, TS3A227, and
> > MAX98357/RT1015 codecs
> > +
> > +maintainers:
> > +  - Julien Massot <julien.massot@collabora.com>
> > +
> > +description:
> > +  Binding for MediaTek MT8183 SoC-based sound cards using the MT6358
> > codec,
> 
> Drop 'Binding for '.
> 
> Sure
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> 
> And thank you for jumping on all these Mediatek bindings.
> 
> Rob
No problem, Thanks for your time.

Regards,
Julien