The mt8183-mfgcfg node uses a power domain in its device tree node.
To prevent schema validation warnings, add the optional `power-domains`
property to the binding schema for mediatek syscon clocks.

Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 .../devicetree/bindings/clock/mediatek,syscon.yaml        | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
index a86a64893c675ac134af609b3a49242565db6ad8..a52f90bfc9f92b52feb9f488db5550630ac55f0a 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
@@ -76,6 +76,9 @@ properties:
           - const: mediatek,mt2701-vdecsys
           - const: syscon
 
+  power-domains:
+    maxItems: 1
+
   reg:
     maxItems: 1
 
@@ -86,6 +89,18 @@ required:
   - compatible
   - '#clock-cells'
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: mediatek,mt8183-mfgcfg
+then:
+  properties:
+    power-domains: true
+else:
+  properties:
+    power-domains: false
+
 additionalProperties: false
 
 examples:

-- 
2.50.1

On Wed, Aug 20, 2025 at 03:44:52PM +0200, Julien Massot wrote:
> The mt8183-mfgcfg node uses a power domain in its device tree node.
> To prevent schema validation warnings, add the optional `power-domains`
> property to the binding schema for mediatek syscon clocks.
> 
> Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")

Checkpatch complains here, but more important - where is explanation of
dropped tag?

> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

But this tag appeared? It wasn't even given!

You remove public tags and add tags never given on the lists.

Best regards,
Krzysztof

On 21/08/2025 09:16, Krzysztof Kozlowski wrote:
> On Wed, Aug 20, 2025 at 03:44:52PM +0200, Julien Massot wrote:
>> The mt8183-mfgcfg node uses a power domain in its device tree node.
>> To prevent schema validation warnings, add the optional `power-domains`
>> property to the binding schema for mediatek syscon clocks.
>>
>> Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> 
> Checkpatch complains here, but more important - where is explanation of
> dropped tag?
> 
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> But this tag appeared? It wasn't even given!
> 
> You remove public tags and add tags never given on the lists.

I found Angelo's tag, but still dropping other acks is not explained.

Best regards,
Krzysztof

Hi Krzysztof, 

Thanks for the review
On Thu, 2025-08-21 at 09:30 +0200, Krzysztof Kozlowski wrote:
> On 21/08/2025 09:16, Krzysztof Kozlowski wrote:
> > On Wed, Aug 20, 2025 at 03:44:52PM +0200, Julien Massot wrote:
> > > The mt8183-mfgcfg node uses a power domain in its device tree node.
> > > To prevent schema validation warnings, add the optional `power-domains`
> > > property to the binding schema for mediatek syscon clocks.
> > > 
> > > Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> > 
> > Checkpatch complains here, but more important - where is explanation of
> > dropped tag?

Right the proper tag is 
Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains properity to mfgcfg")

> > 
> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > 
> > But this tag appeared? It wasn't even given!
> > 
> > You remove public tags and add tags never given on the lists.
> 
> I found Angelo's tag, but still dropping other acks is not explained.
> 
Regarding the tags: in v2 the patch changed quite a lot after I applied
Angelo's suggestion, so I decided to drop Rob’s Acked-by as it no longer
applies to the new version. I should have explained this in the changelog.

Regards,
Julien