[v1] ethernet: tlan: Convert to use jiffies macro

[PATCH] ethernet: tlan: Convert to use jiffies macro

Posted by zhang.enpei@zte.com.cn 5 months, 3 weeks ago

From: Zhang Enpei <zhang.enpei@zte.com.cn>

Use time_after_eq macro instead of using jiffies directly to handle
wraparound.

Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
---
 drivers/net/ethernet/ti/tlan.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index a55b0f951181..78e439834f26 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -1817,7 +1817,6 @@ static void tlan_timer(struct timer_list *t)
 {
        struct tlan_priv        *priv = timer_container_of(priv, t, timer);
        struct net_device       *dev = priv->dev;
-       u32             elapsed;
        unsigned long   flags = 0;

        priv->timer.function = NULL;
@@ -1844,8 +1843,7 @@ static void tlan_timer(struct timer_list *t)
        case TLAN_TIMER_ACTIVITY:
                spin_lock_irqsave(&priv->lock, flags);
                if (priv->timer.function == NULL) {
-                       elapsed = jiffies - priv->timer_set_at;
-                       if (elapsed >= TLAN_TIMER_ACT_DELAY) {
+                       if (time_after_eq(jiffies, priv->timer_set_at + TLAN_TIMER_ACT_DELAY)) {
                                tlan_dio_write8(dev->base_addr,
                                                TLAN_LED_REG, TLAN_LED_LINK);
                        } else  {
-- 
2.25.1

Re: [PATCH] ethernet: tlan: Convert to use jiffies macro

Posted by Jakub Kicinski 5 months, 3 weeks ago

On Tue, 19 Aug 2025 16:16:16 +0800 (CST) zhang.enpei@zte.com.cn wrote:
> +                       if (time_after_eq(jiffies, priv->timer_set_at + TLAN_TIMER_ACT_DELAY)) {

Better still: time_is_after_eq_jiffies()
-- 
pw-bot: cr

Re: [PATCH] ethernet: tlan: Convert to use jiffies macro

Posted by Przemek Kitszel 5 months, 3 weeks ago

On 8/19/25 10:16, zhang.enpei@zte.com.cn wrote:
> From: Zhang Enpei <zhang.enpei@zte.com.cn>
> 
> Use time_after_eq macro instead of using jiffies directly to handle
> wraparound.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
> ---
>   drivers/net/ethernet/ti/tlan.c | 4 +---

change looks good, and it seems that there is no more candidates in ti/
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
> index a55b0f951181..78e439834f26 100644
> --- a/drivers/net/ethernet/ti/tlan.c
> +++ b/drivers/net/ethernet/ti/tlan.c
> @@ -1817,7 +1817,6 @@ static void tlan_timer(struct timer_list *t)
>   {
>          struct tlan_priv        *priv = timer_container_of(priv, t, timer);
>          struct net_device       *dev = priv->dev;
> -       u32             elapsed;
>          unsigned long   flags = 0;
> 
>          priv->timer.function = NULL;
> @@ -1844,8 +1843,7 @@ static void tlan_timer(struct timer_list *t)
>          case TLAN_TIMER_ACTIVITY:
>                  spin_lock_irqsave(&priv->lock, flags);
>                  if (priv->timer.function == NULL) {
> -                       elapsed = jiffies - priv->timer_set_at;
> -                       if (elapsed >= TLAN_TIMER_ACT_DELAY) {
> +                       if (time_after_eq(jiffies, priv->timer_set_at + TLAN_TIMER_ACT_DELAY)) {
>                                  tlan_dio_write8(dev->base_addr,
>                                                  TLAN_LED_REG, TLAN_LED_LINK);
>                          } else  {