xfs: Remove redundant header files

[PATCH] xfs: Remove redundant header files

Posted by Liao Yuanhong 1 month, 2 weeks ago

The header file "xfs_rtbitmap.h" is already included on line 24. Remove the
redundant include.

Fixes: f1a6d9b4c3177 ("xfs: online repair of realtime file bmaps")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
 fs/xfs/scrub/repair.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/scrub/repair.c b/fs/xfs/scrub/repair.c
index d00c18954a26..e35a1c56d706 100644
--- a/fs/xfs/scrub/repair.c
+++ b/fs/xfs/scrub/repair.c
@@ -38,7 +38,6 @@
 #include "xfs_attr.h"
 #include "xfs_dir2.h"
 #include "xfs_rtrmap_btree.h"
-#include "xfs_rtbitmap.h"
 #include "xfs_rtgroup.h"
 #include "xfs_rtalloc.h"
 #include "xfs_metafile.h"
-- 
2.34.1

Re: [PATCH] xfs: Remove redundant header files

Posted by Darrick J. Wong 1 month, 2 weeks ago

On Tue, Aug 19, 2025 at 09:14:38PM +0800, Liao Yuanhong wrote:
> The header file "xfs_rtbitmap.h" is already included on line 24. Remove the
> redundant include.
> 
> Fixes: f1a6d9b4c3177 ("xfs: online repair of realtime file bmaps")
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>

https://lore.kernel.org/linux-xfs/20250319034806.3812673-1-nichen@iscas.ac.cn/
?

--D

> ---
>  fs/xfs/scrub/repair.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/scrub/repair.c b/fs/xfs/scrub/repair.c
> index d00c18954a26..e35a1c56d706 100644
> --- a/fs/xfs/scrub/repair.c
> +++ b/fs/xfs/scrub/repair.c
> @@ -38,7 +38,6 @@
>  #include "xfs_attr.h"
>  #include "xfs_dir2.h"
>  #include "xfs_rtrmap_btree.h"
> -#include "xfs_rtbitmap.h"
>  #include "xfs_rtgroup.h"
>  #include "xfs_rtalloc.h"
>  #include "xfs_metafile.h"
> -- 
> 2.34.1
> 
>