Tegra20, Tegra30 and Tegra114 have VI revision 1.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 drivers/staging/media/tegra-video/tegra20.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/staging/media/tegra-video/tegra20.c
index 735611c3c47d..71dcb982c97b 100644
--- a/drivers/staging/media/tegra-video/tegra20.c
+++ b/drivers/staging/media/tegra-video/tegra20.c
@@ -587,6 +587,7 @@ const struct tegra_vi_soc tegra20_vi_soc = {
 	.nformats = ARRAY_SIZE(tegra20_video_formats),
 	.default_video_format = &tegra20_video_formats[0],
 	.ops = &tegra20_vi_ops,
+	.hw_revision = 1,
 	.vi_max_channels = 1, /* parallel input (VIP) */
 	.vi_max_clk_hz = 150000000,
 	.has_h_v_flip = true,
-- 
2.48.1

On Tue, 19 Aug 2025 15:16:25 +0300
Svyatoslav Ryhel <clamor95@gmail.com> wrote:

> Tegra20, Tegra30 and Tegra114 have VI revision 1.

Why? You should mention the reason in the commit message.

But I don't see hw_revision used in the series, so unless I missed
something you should drop this patch.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

пт, 5 вер. 2025 р. о 19:08 Luca Ceresoli <luca.ceresoli@bootlin.com> пише:
>
> On Tue, 19 Aug 2025 15:16:25 +0300
> Svyatoslav Ryhel <clamor95@gmail.com> wrote:
>
> > Tegra20, Tegra30 and Tegra114 have VI revision 1.
>
> Why? You should mention the reason in the commit message.
>

Because TRM states that Tegra20, Tegra30 and Tegra114 have VI revision
1, Tegra124 has VI revision 2 and Tegra210 has VI revision 3 (which is
set in tegra210.c btw).

> But I don't see hw_revision used in the series, so unless I missed
> something you should drop this patch.
>
> Luca
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Hello Svyatoslav,

On Fri, 5 Sep 2025 19:11:06 +0300
Svyatoslav Ryhel <clamor95@gmail.com> wrote:

> пт, 5 вер. 2025 р. о 19:08 Luca Ceresoli <luca.ceresoli@bootlin.com> пише:
> >
> > On Tue, 19 Aug 2025 15:16:25 +0300
> > Svyatoslav Ryhel <clamor95@gmail.com> wrote:
> >  
> > > Tegra20, Tegra30 and Tegra114 have VI revision 1.  
> >
> > Why? You should mention the reason in the commit message.
> >  
> 
> Because TRM states that Tegra20, Tegra30 and Tegra114 have VI revision
> 1, Tegra124 has VI revision 2 and Tegra210 has VI revision 3 (which is
> set in tegra210.c btw).
> 
> > But I don't see hw_revision used in the series, so unless I missed
> > something you should drop this patch.

My point was rather that the hw revision is not used in the series, not
quite about the value itself. I was missing it is exposed by MC, so
this is fine.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com