nvmem: qnap-mcu-eeprom: swap header order to fix missing type definitions

[PATCH] nvmem: qnap-mcu-eeprom: swap header order to fix missing type definitions

Posted by Heiko Stuebner 1 month, 2 weeks ago

The main header for the qnap-mcu uses types without (at the moment)
including the necessary types.h header.

While there is patch pending to fix that for every use:
  https://lore.kernel.org/all/20250804130726.3180806-2-heiko@sntech.de/
this does not help the nvmem driver right now.

Swapping the order of module.h and qnap-mcu.h headers does fix the
problem locally until the main change gets merged though.

Fixes: 117c3f3014a9 ("nvmem: add driver for the eeprom in qnap-mcu controllers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202508191205.ROvIX7IA-lkp@intel.com/
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/nvmem/qnap-mcu-eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/qnap-mcu-eeprom.c b/drivers/nvmem/qnap-mcu-eeprom.c
index fea1e7b91764..e18e9ff4cfce 100644
--- a/drivers/nvmem/qnap-mcu-eeprom.c
+++ b/drivers/nvmem/qnap-mcu-eeprom.c
@@ -9,8 +9,8 @@
  * Copyright (C) 2008 Wolfram Sang, Pengutronix
  */
 
-#include <linux/mfd/qnap-mcu.h>
 #include <linux/module.h>
+#include <linux/mfd/qnap-mcu.h>
 #include <linux/nvmem-provider.h>
 #include <linux/platform_device.h>
 
-- 
2.47.2

Re: [PATCH] nvmem: qnap-mcu-eeprom: swap header order to fix missing type definitions

Posted by Heiko Stübner 1 month, 2 weeks ago

Am Dienstag, 19. August 2025, 13:10:44 Mitteleuropäische Sommerzeit schrieb Heiko Stuebner:
> The main header for the qnap-mcu uses types without (at the moment)
> including the necessary types.h header.
> 
> While there is patch pending to fix that for every use:
>   https://lore.kernel.org/all/20250804130726.3180806-2-heiko@sntech.de/
> this does not help the nvmem driver right now.
> 
> Swapping the order of module.h and qnap-mcu.h headers does fix the
> problem locally until the main change gets merged though.
> 
> Fixes: 117c3f3014a9 ("nvmem: add driver for the eeprom in qnap-mcu controllers")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508191205.ROvIX7IA-lkp@intel.com/
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

The offending patch has been removed, so this patch is not necessary anymore.


Heiko