Refer to PCIe CEM r6.0, sec 2.3 WAKE# Signal, WAKE# signal is only
asserted by the Add-in Card when all its functions are in D3Cold state
and at least one of its functions is enabled for wakeup generation.
The 3.3V auxiliary power (+3.3Vaux) must be present and used for wakeup
process. Since the main power supply would be gated off to let Add-in
Card to be in D3Cold, add the vaux and keep it enabled to power up WAKE#
circuit for the entire PCIe controller lifecycle when WAKE# is supported.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
.../devicetree/bindings/pci/snps,dw-pcie-common.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
index 34594972d8dbe..5283f51388584 100644
--- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
+++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
@@ -262,6 +262,12 @@ properties:
dma-coherent: true
+ vaux-supply:
+ description: Should specify the regulator in charge of power source
+ of the WAKE# generation on the PCIe connector. When the WAKE# is
+ enabled, this regualor would be always on and used to power up
+ WAKE# circuit.
+
additionalProperties: true
...
--
2.37.1
On Tue, Aug 19, 2025 at 03:16:29PM GMT, Richard Zhu wrote: > Refer to PCIe CEM r6.0, sec 2.3 WAKE# Signal, WAKE# signal is only > asserted by the Add-in Card when all its functions are in D3Cold state > and at least one of its functions is enabled for wakeup generation. > > The 3.3V auxiliary power (+3.3Vaux) must be present and used for wakeup > process. Since the main power supply would be gated off to let Add-in > Card to be in D3Cold, add the vaux and keep it enabled to power up WAKE# > circuit for the entire PCIe controller lifecycle when WAKE# is supported. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > .../devicetree/bindings/pci/snps,dw-pcie-common.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > index 34594972d8dbe..5283f51388584 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > @@ -262,6 +262,12 @@ properties: > > dma-coherent: true > > + vaux-supply: > + description: Should specify the regulator in charge of power source > + of the WAKE# generation on the PCIe connector. When the WAKE# is > + enabled, this regualor would be always on and used to power up > + WAKE# circuit. 3.3Vaux supply is already documented in the dtschema: https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/pci/pci-bus-common.yaml#L179 So you should use that instead. - Mani -- மணிவண்ணன் சதாசிவம்
On Tue, 19 Aug 2025 15:16:29 +0800, Richard Zhu wrote: > Refer to PCIe CEM r6.0, sec 2.3 WAKE# Signal, WAKE# signal is only > asserted by the Add-in Card when all its functions are in D3Cold state > and at least one of its functions is enabled for wakeup generation. > > The 3.3V auxiliary power (+3.3Vaux) must be present and used for wakeup > process. Since the main power supply would be gated off to let Add-in > Card to be in D3Cold, add the vaux and keep it enabled to power up WAKE# > circuit for the entire PCIe controller lifecycle when WAKE# is supported. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > .../devicetree/bindings/pci/snps,dw-pcie-common.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250819071630.1813134-2-hongxing.zhu@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
© 2016 - 2025 Red Hat, Inc.