[PATCH] bus: mhi: host: pci_generic: Use subsystem device ID PCI_ANY_ID for Foxconn T99W696 variants

Slark Xiao posted 1 patch 1 month, 2 weeks ago
drivers/bus/mhi/host/pci_generic.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
[PATCH] bus: mhi: host: pci_generic: Use subsystem device ID PCI_ANY_ID for Foxconn T99W696 variants
Posted by Slark Xiao 1 month, 2 weeks ago
Since there are too many variants for Foxconn T99W696 SKU, and
they share same settings. So we use PCI_ANY_ID as the subsystem
device ID to match each possible settings.

Fixes: 0d63055e1406 ("bus: mhi: host: pci_generic: Add Foxconn T99W696 modem")
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
 drivers/bus/mhi/host/pci_generic.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 4edb5bb476ba..4564e2528775 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -917,20 +917,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 	/* Telit FE990A */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2015),
 		.driver_data = (kernel_ulong_t) &mhi_telit_fe990a_info },
-	/* Foxconn T99W696.01, Lenovo Generic SKU */
-	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe142),
-		.driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
-	/* Foxconn T99W696.02, Lenovo X1 Carbon SKU */
-	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe143),
-		.driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
-	/* Foxconn T99W696.03, Lenovo X1 2in1 SKU */
-	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe144),
-		.driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
-	/* Foxconn T99W696.04, Lenovo PRC SKU */
-	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe145),
-		.driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
-	/* Foxconn T99W696.00, Foxconn SKU */
-	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe146),
+	/* Foxconn T99W696, all variants */
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, PCI_ANY_ID),
 		.driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
 	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),
 		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },
-- 
2.25.1
Re: [PATCH] bus: mhi: host: pci_generic: Use subsystem device ID PCI_ANY_ID for Foxconn T99W696 variants
Posted by Manivannan Sadhasivam 4 weeks ago
On Tue, 19 Aug 2025 10:00:13 +0800, Slark Xiao wrote:
> Since there are too many variants for Foxconn T99W696 SKU, and
> they share same settings. So we use PCI_ANY_ID as the subsystem
> device ID to match each possible settings.
> 
> 

Applied, thanks!

[1/1] bus: mhi: host: pci_generic: Use subsystem device ID PCI_ANY_ID for Foxconn T99W696 variants
      commit: 376358bb9770e5313d22d8784511497096cdb75f

Best regards,
-- 
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>