arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports

[PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports

Posted by Stephan Gerhold 1 month, 2 weeks ago

The &eusb3_repeater belongs to the first port of the USB MP controller and
the &eusb6_repeater belongs to the second. This is obvious if one looks at
e.g. the CRD or the Dell XPS where only the second port of the USB MP is
used: They only have the &eusb6_repeater and already specify it for the
&usb_mp_hsphy1.

Swap them for the affected boards with 2 ports to set the correct repeater
for each of the USB ports. Boards with just a single port used (CRD, Dell
XPS) are already correct.

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
Stephan Gerhold (4):
      arm64: dts: qcom: x1e001de-devkit: Fix swapped USB MP repeaters
      arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix swapped USB MP repeaters
      arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix swapped USB MP repeaters
      arm64: dts: qcom: x1e80100-qcp: Fix swapped USB MP repeaters

 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts                | 4 ++--
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts     | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                   | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
---
base-commit: 1aa50d938e88fcad1312467bd09be4037bfe68ff
change-id: 20250813-x1e80100-fix-usb-mp-repeaters-3756556463d7

Best regards,
-- 
Stephan Gerhold <stephan.gerhold@linaro.org>

Re: [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports

Posted by Bjorn Andersson 1 month, 1 week ago

On Tue, 19 Aug 2025 12:45:19 +0200, Stephan Gerhold wrote:
> The &eusb3_repeater belongs to the first port of the USB MP controller and
> the &eusb6_repeater belongs to the second. This is obvious if one looks at
> e.g. the CRD or the Dell XPS where only the second port of the USB MP is
> used: They only have the &eusb6_repeater and already specify it for the
> &usb_mp_hsphy1.
> 
> Swap them for the affected boards with 2 ports to set the correct repeater
> for each of the USB ports. Boards with just a single port used (CRD, Dell
> XPS) are already correct.
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: qcom: x1e001de-devkit: Fix swapped USB MP repeaters
      commit: 59a4b94a8c46c71f6c7aac00c21dc781b525fd6d
[2/4] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix swapped USB MP repeaters
      commit: c3994b495111bd0ae663c63fc96a869678d03e6c
[3/4] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix swapped USB MP repeaters
      commit: d5d72e326762c24f2fbc48e5f223cb674cecad1a
[4/4] arm64: dts: qcom: x1e80100-qcp: Fix swapped USB MP repeaters
      commit: 6dcc44fc695b11bf4e654774a7c865abf96a2af3

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>