arm: dts: stm32: Drop redundant status=okay

[PATCH] arm: dts: stm32: Drop redundant status=okay

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

Device nodes are enabled by default, so remove confusing or duplicated
enabling of few nodes.  No practical impact, verified with dtx_diff.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/st/stm32mp157c-dk2.dts          | 2 --
 arch/arm/boot/dts/st/stm32mp157f-dk2.dts          | 2 --
 arch/arm/boot/dts/st/stm32mp15xx-dhcom-drc02.dtsi | 1 -
 arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi  | 3 ---
 arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi   | 2 --
 5 files changed, 10 deletions(-)

diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
index 1b34fbe10b4f..78165c7865e1 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts
@@ -45,7 +45,6 @@ panel@0 {
 		reg = <0>;
 		reset-gpios = <&gpioe 4 GPIO_ACTIVE_LOW>;
 		power-supply = <&v3v3>;
-		status = "okay";
 
 		port {
 			panel_in: endpoint {
@@ -71,7 +70,6 @@ touchscreen@38 {
 		interrupt-parent = <&gpiof>;
 		touchscreen-size-x = <480>;
 		touchscreen-size-y = <800>;
-		status = "okay";
 	};
 };
 
diff --git a/arch/arm/boot/dts/st/stm32mp157f-dk2.dts b/arch/arm/boot/dts/st/stm32mp157f-dk2.dts
index 43375c4d62a3..8fa61e54d026 100644
--- a/arch/arm/boot/dts/st/stm32mp157f-dk2.dts
+++ b/arch/arm/boot/dts/st/stm32mp157f-dk2.dts
@@ -51,7 +51,6 @@ panel@0 {
 		reg = <0>;
 		reset-gpios = <&gpioe 4 GPIO_ACTIVE_LOW>;
 		power-supply = <&scmi_v3v3>;
-		status = "okay";
 
 		port {
 			panel_in: endpoint {
@@ -77,7 +76,6 @@ touchscreen@38 {
 		interrupt-parent = <&gpiof>;
 		touchscreen-size-x = <480>;
 		touchscreen-size-y = <800>;
-		status = "okay";
 	};
 };
 
diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-drc02.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-drc02.dtsi
index abe2dfe70636..52c4e69597a4 100644
--- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-drc02.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-drc02.dtsi
@@ -62,7 +62,6 @@ &i2c2 {
 	pinctrl-0 = <&i2c2_pins_a>;
 	i2c-scl-rising-time-ns = <185>;
 	i2c-scl-falling-time-ns = <20>;
-	status = "okay";
 	/* spare dmas for other usage */
 	/delete-property/dmas;
 	/delete-property/dma-names;
diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
index 0fb4e55843b9..5c77202ee196 100644
--- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi
@@ -20,7 +20,6 @@ display_bl: display-bl {
 		default-brightness-level = <8>;
 		enable-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;
 		power-supply = <&reg_panel_bl>;
-		status = "okay";
 	};
 
 	gpio-keys-polled {
@@ -135,7 +134,6 @@ sound {
 			  "MIC_IN", "Microphone Jack",
 			  "Microphone Jack", "Mic Bias";
 		dais = <&sai2a_port &sai2b_port>;
-		status = "okay";
 	};
 };
 
@@ -150,7 +148,6 @@ &i2c2 {	/* Header X22 */
 	pinctrl-0 = <&i2c2_pins_a>;
 	i2c-scl-rising-time-ns = <185>;
 	i2c-scl-falling-time-ns = <20>;
-	status = "okay";
 	/* spare dmas for other usage */
 	/delete-property/dmas;
 	/delete-property/dma-names;
diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi
index 142d4a8731f8..4cc633683c6b 100644
--- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi
@@ -269,7 +269,6 @@ pmic: stpmic@33 {
 		interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>;
 		interrupt-controller;
 		#interrupt-cells = <2>;
-		status = "okay";
 
 		regulators {
 			compatible = "st,stpmic1-regulators";
@@ -388,7 +387,6 @@ onkey {
 			interrupts = <IT_PONKEY_F 0>, <IT_PONKEY_R 0>;
 			interrupt-names = "onkey-falling", "onkey-rising";
 			power-off-time-sec = <10>;
-			status = "okay";
 		};
 
 		watchdog {
-- 
2.48.1

Re: [PATCH] arm: dts: stm32: Drop redundant status=okay

Posted by Alexandre TORGUE 1 month ago

Hi

On 8/18/25 16:37, Krzysztof Kozlowski wrote:
> Device nodes are enabled by default, so remove confusing or duplicated
> enabling of few nodes.  No practical impact, verified with dtx_diff.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm/boot/dts/st/stm32mp157c-dk2.dts          | 2 --
>   arch/arm/boot/dts/st/stm32mp157f-dk2.dts          | 2 --
>   arch/arm/boot/dts/st/stm32mp15xx-dhcom-drc02.dtsi | 1 -
>   arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi  | 3 ---
>   arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi   | 2 --
>   5 files changed, 10 deletions(-)
> 

Applied on stm32-next.

thanks
Alex

Re: [PATCH] arm: dts: stm32: Drop redundant status=okay

Posted by Marek Vasut 1 month, 2 weeks ago

On 8/18/25 4:37 PM, Krzysztof Kozlowski wrote:
> Device nodes are enabled by default, so remove confusing or duplicated
> enabling of few nodes.  No practical impact, verified with dtx_diff.
I assume the "no practical impact" means DTs are identical before/after 
this patch ? If yes,

Reviewed-by: Marek Vasut <marek.vasut@mailbox.org>

Thanks !

Re: [PATCH] arm: dts: stm32: Drop redundant status=okay

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 18/08/2025 16:45, Marek Vasut wrote:
> On 8/18/25 4:37 PM, Krzysztof Kozlowski wrote:
>> Device nodes are enabled by default, so remove confusing or duplicated
>> enabling of few nodes.  No practical impact, verified with dtx_diff.
> I assume the "no practical impact" means DTs are identical before/after 
> this patch ? If yes,


No, DTS cannot be identical in this case because one had status, new one
does not have. Practical impact means... visible impact in practice. How
to say it more clearly?

> 
> Reviewed-by: Marek Vasut <marek.vasut@mailbox.org>



Best regards,
Krzysztof

Re: [PATCH] arm: dts: stm32: Drop redundant status=okay

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 18/08/2025 16:51, Krzysztof Kozlowski wrote:
> On 18/08/2025 16:45, Marek Vasut wrote:
>> On 8/18/25 4:37 PM, Krzysztof Kozlowski wrote:
>>> Device nodes are enabled by default, so remove confusing or duplicated
>>> enabling of few nodes.  No practical impact, verified with dtx_diff.
>> I assume the "no practical impact" means DTs are identical before/after 
>> this patch ? If yes,
> 
> 
> No, DTS cannot be identical in this case because one had status, new one
> does not have. Practical impact means... visible impact in practice. How
> to say it more clearly?
To illustrate: this is "no practical impact":


--- dts-old/st/stm32mp157c-dhcom-picoitx.dtb
+++ dts-new/st/stm32mp157c-dhcom-picoitx.dtb
@@ -691,14 +691,12 @@
 					interrupt-controller;
 					interrupts-extended = <0x49 0x00
 					reg = <0x33>;
-					status = "okay";


But this would be a practical impact:


@@ -1124,7 +1121,7 @@
 					dmas = <0x26 0x59 0x400 0x01>;
 					phandle = <0x39>;
 					reg = <0x04 0x20>;
-					status = "okay";
+					status = "disabled";


Best regards,
Krzysztof

Re: [PATCH] arm: dts: stm32: Drop redundant status=okay

Posted by Marek Vasut 1 month, 2 weeks ago

On 8/18/25 4:56 PM, Krzysztof Kozlowski wrote:
> On 18/08/2025 16:51, Krzysztof Kozlowski wrote:
>> On 18/08/2025 16:45, Marek Vasut wrote:
>>> On 8/18/25 4:37 PM, Krzysztof Kozlowski wrote:
>>>> Device nodes are enabled by default, so remove confusing or duplicated
>>>> enabling of few nodes.  No practical impact, verified with dtx_diff.
>>> I assume the "no practical impact" means DTs are identical before/after
>>> this patch ? If yes,
>>
>>
>> No, DTS cannot be identical in this case because one had status, new one
>> does not have. Practical impact means... visible impact in practice. How
>> to say it more clearly?
> To illustrate: this is "no practical impact":
> 
> 
> --- dts-old/st/stm32mp157c-dhcom-picoitx.dtb
> +++ dts-new/st/stm32mp157c-dhcom-picoitx.dtb
> @@ -691,14 +691,12 @@
>   					interrupt-controller;
>   					interrupts-extended = <0x49 0x00
>   					reg = <0x33>;
> -					status = "okay";
Sorry, yes, this ^ is what I meant and obviously wrote too fast and too 
inaccurately. My RB still stands. Thanks