The DRM subsystem has a set of preferred, prefixed logging functions
(drm_info, drm_warn, drm_err) which improve debuggability by including
the driver and function name in the log output.

As part of the ongoing effort to modernize logging calls,
convert a dev_err() call in the bochs hardware initialization
function to its drm_err() equivalent.

This work was suggested by the DRM TODO list.

Signed-off-by: Leander Kieweg <kieweg.leander@gmail.com>
---
 drivers/gpu/drm/tiny/bochs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 8d3b7c4fa6a4..d2d5e9f1269f 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -252,7 +252,7 @@ static int bochs_hw_init(struct bochs_device *bochs)
 		}
 		bochs->ioports = 1;
 	} else {
-		dev_err(dev->dev, "I/O ports are not supported\n");
+		drm_err(dev, "I/O ports are not supported\n");
 		return -EIO;
 	}
 
-- 
2.43.0

Hi

Am 18.08.25 um 13:35 schrieb Leander Kieweg:
> The DRM subsystem has a set of preferred, prefixed logging functions
> (drm_info, drm_warn, drm_err) which improve debuggability by including
> the driver and function name in the log output.
>
> As part of the ongoing effort to modernize logging calls,
> convert a dev_err() call in the bochs hardware initialization
> function to its drm_err() equivalent.
>
> This work was suggested by the DRM TODO list.
>
> Signed-off-by: Leander Kieweg <kieweg.leander@gmail.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

I'll soon add the patch to our tree.

Best regards
Thomas

> ---
>   drivers/gpu/drm/tiny/bochs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
> index 8d3b7c4fa6a4..d2d5e9f1269f 100644
> --- a/drivers/gpu/drm/tiny/bochs.c
> +++ b/drivers/gpu/drm/tiny/bochs.c
> @@ -252,7 +252,7 @@ static int bochs_hw_init(struct bochs_device *bochs)
>   		}
>   		bochs->ioports = 1;
>   	} else {
> -		dev_err(dev->dev, "I/O ports are not supported\n");
> +		drm_err(dev, "I/O ports are not supported\n");
>   		return -EIO;
>   	}
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Gentle ping on this patch.

Is this change still of interest? I'm happy to make any changes or
rebase if needed.

Thanks,
Leander Kieweg