ext4: replace min/max nesting with clamp()

[PATCH] ext4: replace min/max nesting with clamp()

Posted by Xichao Zhao 1 month, 2 weeks ago

The clamp() macro explicitly expresses the intent of constraining a value
within bounds.Therefore, replacing max(min(a,b),c) with clamp(val, lo, hi)
can improve code readability.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
 fs/ext4/mmp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 51661570cf3b..ab1ff51302fb 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -231,9 +231,9 @@ static int kmmpd(void *data)
 		 * Adjust the mmp_check_interval depending on how much time
 		 * it took for the MMP block to be written.
 		 */
-		mmp_check_interval = max(min(EXT4_MMP_CHECK_MULT * diff / HZ,
-					     EXT4_MMP_MAX_CHECK_INTERVAL),
-					 EXT4_MMP_MIN_CHECK_INTERVAL);
+		mmp_check_interval = clamp(EXT4_MMP_CHECK_MULT * diff / HZ,
+					   EXT4_MMP_MIN_CHECK_INTERVAL,
+					   EXT4_MMP_MAX_CHECK_INTERVAL);
 		mmp->mmp_check_interval = cpu_to_le16(mmp_check_interval);
 	}
 
-- 
2.34.1

Re: [PATCH] ext4: replace min/max nesting with clamp()

Posted by Theodore Ts'o 1 week ago

On Mon, 18 Aug 2025 15:28:59 +0800, Xichao Zhao wrote:
> The clamp() macro explicitly expresses the intent of constraining a value
> within bounds.Therefore, replacing max(min(a,b),c) with clamp(val, lo, hi)
> can improve code readability.
> 
> 

Applied, thanks!

[1/1] ext4: replace min/max nesting with clamp()
      commit: 981b696faf2d59a58d1dc8e258bba00b12e5de93

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>