The duster register needs to be disabled on test patterns. While the
code is correctly doing so, the register address contained a typo, thus
not disabling the duster correctly. Fix the typo.

Fixes: e56616d7b23c ("media: i2c: Add driver for ST VD55G1 camera sensor")

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
---
 drivers/media/i2c/vd55g1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
index b89fff7e11f891dea04a0085a9e7aac841b6643d..cf35f73fdd1086c6d4d76f67c2b6e4cf66eadff8 100644
--- a/drivers/media/i2c/vd55g1.c
+++ b/drivers/media/i2c/vd55g1.c
@@ -66,7 +66,7 @@
 #define VD55G1_REG_READOUT_CTRL				CCI_REG8(0x052e)
 #define VD55G1_READOUT_CTRL_BIN_MODE_NORMAL		0
 #define VD55G1_READOUT_CTRL_BIN_MODE_DIGITAL_X2		1
-#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ea)
+#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ae)
 #define VD55G1_DUSTER_ENABLE				BIT(0)
 #define VD55G1_DUSTER_DISABLE				0
 #define VD55G1_DUSTER_DYN_ENABLE			BIT(1)

---
base-commit: 2412f16c9afa7710778fc032139a6df38b68fd7c
change-id: 20250818-vd55g1_fix_duster-6b6979280248

Best regards,
-- 
Benjamin Mugnier <benjamin.mugnier@foss.st.com>

Hi Benjamin,

On Mon, Aug 18, 2025 at 03:50:58PM +0200, Benjamin Mugnier wrote:
> The duster register needs to be disabled on test patterns. While the
> code is correctly doing so, the register address contained a typo, thus
> not disabling the duster correctly. Fix the typo.
> 
> Fixes: e56616d7b23c ("media: i2c: Add driver for ST VD55G1 camera sensor")
> 

Extra newline; I'll remove it while applying.

> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  drivers/media/i2c/vd55g1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index b89fff7e11f891dea04a0085a9e7aac841b6643d..cf35f73fdd1086c6d4d76f67c2b6e4cf66eadff8 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -66,7 +66,7 @@
>  #define VD55G1_REG_READOUT_CTRL				CCI_REG8(0x052e)
>  #define VD55G1_READOUT_CTRL_BIN_MODE_NORMAL		0
>  #define VD55G1_READOUT_CTRL_BIN_MODE_DIGITAL_X2		1
> -#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ea)
> +#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ae)
>  #define VD55G1_DUSTER_ENABLE				BIT(0)
>  #define VD55G1_DUSTER_DISABLE				0
>  #define VD55G1_DUSTER_DYN_ENABLE			BIT(1)
> 

-- 
Regards,

Sakari Ailus

Hi Sakari,

On 8/18/25 16:08, Sakari Ailus wrote:
> Hi Benjamin,
> 
> On Mon, Aug 18, 2025 at 03:50:58PM +0200, Benjamin Mugnier wrote:
>> The duster register needs to be disabled on test patterns. While the
>> code is correctly doing so, the register address contained a typo, thus
>> not disabling the duster correctly. Fix the typo.
>>
>> Fixes: e56616d7b23c ("media: i2c: Add driver for ST VD55G1 camera sensor")
>>
> 
> Extra newline; I'll remove it while applying.
> 

Thanks a lot.

>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>> ---
>>  drivers/media/i2c/vd55g1.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
>> index b89fff7e11f891dea04a0085a9e7aac841b6643d..cf35f73fdd1086c6d4d76f67c2b6e4cf66eadff8 100644
>> --- a/drivers/media/i2c/vd55g1.c
>> +++ b/drivers/media/i2c/vd55g1.c
>> @@ -66,7 +66,7 @@
>>  #define VD55G1_REG_READOUT_CTRL				CCI_REG8(0x052e)
>>  #define VD55G1_READOUT_CTRL_BIN_MODE_NORMAL		0
>>  #define VD55G1_READOUT_CTRL_BIN_MODE_DIGITAL_X2		1
>> -#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ea)
>> +#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ae)
>>  #define VD55G1_DUSTER_ENABLE				BIT(0)
>>  #define VD55G1_DUSTER_DISABLE				0
>>  #define VD55G1_DUSTER_DYN_ENABLE			BIT(1)
>>
> 

-- 
Regards,
Benjamin