[PATCH 2/2] arm64: defconfig: Modularize SX150X GPIO expander

Fange Zhang posted 2 patches 1 month, 2 weeks ago
[PATCH 2/2] arm64: defconfig: Modularize SX150X GPIO expander
Posted by Fange Zhang 1 month, 2 weeks ago
Modularize the SX150X GPIO expander which is equipped on the QCS615 Ride
board to allow the ANX7625 external bridge to function correctly.

Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 667c4859ecc3cda9b0a3dae7abdd8587fc4f8dbe..dce4450fa9fa58fab0556a6e84b899a3306b4db3 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -598,6 +598,7 @@ CONFIG_PINCTRL_DA9062=m
 CONFIG_PINCTRL_MAX77620=y
 CONFIG_PINCTRL_RK805=m
 CONFIG_PINCTRL_SINGLE=y
+CONFIG_PINCTRL_SX150X=m
 CONFIG_PINCTRL_OWL=y
 CONFIG_PINCTRL_S700=y
 CONFIG_PINCTRL_S900=y

-- 
2.34.1
Re: [PATCH 2/2] arm64: defconfig: Modularize SX150X GPIO expander
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 18/08/2025 06:41, Fange Zhang wrote:
> Modularize the SX150X GPIO expander which is equipped on the QCS615 Ride

Qualcomm QCS615 Ride

You are changing defconfig for all platforms, it's not your personal or
company defconfig.

> 


Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: defconfig: Modularize SX150X GPIO expander
Posted by Fange Zhang 1 month, 2 weeks ago

On 8/18/2025 2:33 PM, Krzysztof Kozlowski wrote:
> On 18/08/2025 06:41, Fange Zhang wrote:
>> Modularize the SX150X GPIO expander which is equipped on the QCS615 Ride
> 
> Qualcomm QCS615 Ride
> 
> You are changing defconfig for all platforms, it's not your personal or
> company defconfig.

Thank you for the feedback. Yes, The change is intended to support the 
Qualcomm QCS615 Ride platform, which is now upstream-ready and actively 
maintained.
I believe enabling it as a module ensures it's available without 
impacting other platforms. While it's not currently used directly in the 
kernel, having it built as a module allows flexibility for platforms 
like QCS615 that may require it in future use cases.

> 
>>
> 
> 
> Best regards,
> Krzysztof
Re: [PATCH 2/2] arm64: defconfig: Modularize SX150X GPIO expander
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 18/08/2025 09:10, Fange Zhang wrote:
> 
> 
> On 8/18/2025 2:33 PM, Krzysztof Kozlowski wrote:
>> On 18/08/2025 06:41, Fange Zhang wrote:
>>> Modularize the SX150X GPIO expander which is equipped on the QCS615 Ride
>>
>> Qualcomm QCS615 Ride
>>
>> You are changing defconfig for all platforms, it's not your personal or
>> company defconfig.
> 
> Thank you for the feedback. Yes, The change is intended to support the 
> Qualcomm QCS615 Ride platform, which is now upstream-ready and actively 
> maintained.
> I believe enabling it as a module ensures it's available without 
> impacting other platforms. While it's not currently used directly in the 
> kernel, having it built as a module allows flexibility for platforms 

Hm? Not used? So this rationale is incorrect.

> like QCS615 that may require it in future use cases.

No, we do not make defconfig changes for future.


Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: defconfig: Modularize SX150X GPIO expander
Posted by Fange Zhang 1 month, 2 weeks ago

On 8/18/2025 4:02 PM, Krzysztof Kozlowski wrote:
> On 18/08/2025 09:10, Fange Zhang wrote:
>>
>>
>> On 8/18/2025 2:33 PM, Krzysztof Kozlowski wrote:
>>> On 18/08/2025 06:41, Fange Zhang wrote:
>>>> Modularize the SX150X GPIO expander which is equipped on the QCS615 Ride
>>>
>>> Qualcomm QCS615 Ride
>>>
>>> You are changing defconfig for all platforms, it's not your personal or
>>> company defconfig.
>>
>> Thank you for the feedback. Yes, The change is intended to support the
>> Qualcomm QCS615 Ride platform, which is now upstream-ready and actively
>> maintained.
>> I believe enabling it as a module ensures it's available without
>> impacting other platforms. While it's not currently used directly in the
>> kernel, having it built as a module allows flexibility for platforms
> 
> Hm? Not used? So this rationale is incorrect.

Yes, still not used yet, but we're actively working to upstream full 
support for the QCS615 platform, and this change is part of that effort.
(see 
https://lore.kernel.org/all/20250818-add-display-support-for-qcs615-platform-v6-2-62aad5138a78@oss.qualcomm.com/)

> 
>> like QCS615 that may require it in future use cases.
> 
> No, we do not make defconfig changes for future.

Thank you for the clarification — I understand and respect the policy.
That said, would it be acceptable to consider the defconfig change 
together with the platform support patch, once it's accepted?

> 
> 
> Best regards,
> Krzysztof