Modularize SX150X GPIO expander

[PATCH 1/2] pinctrl: sx150x: Make the driver tristate

Posted by Fange Zhang 1 month, 2 weeks ago

Set PINCTRL_SX150X config option as a tristate and add
MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.

Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>
---
 drivers/pinctrl/Kconfig          | 2 +-
 drivers/pinctrl/pinctrl-sx150x.c | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index ddd11668457ceded9861438768f89945f2307e31..3d06f02a3da549317a9364540d1b598051b926f4 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -550,7 +550,7 @@ config PINCTRL_STMFX
 	  interrupt-controller.
 
 config PINCTRL_SX150X
-	bool "Semtech SX150x I2C GPIO expander pinctrl driver"
+	tristate "Semtech SX150x I2C GPIO expander pinctrl driver"
 	depends on I2C=y
 	select PINMUX
 	select PINCONF
diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c
index 53cf8168b274c5310706512dcd3ba8d4d25f5049..b613568b42b73d1c1b220b641e292055e23f4de2 100644
--- a/drivers/pinctrl/pinctrl-sx150x.c
+++ b/drivers/pinctrl/pinctrl-sx150x.c
@@ -863,6 +863,7 @@ static const struct of_device_id sx150x_of_match[] = {
 	{ .compatible = "semtech,sx1509q", .data = &sx1509q_device_data },
 	{},
 };
+MODULE_DEVICE_TABLE(of, sx150x_of_match);
 
 static int sx150x_reset(struct sx150x_pinctrl *pctl)
 {
@@ -1266,3 +1267,6 @@ static int __init sx150x_init(void)
 	return i2c_add_driver(&sx150x_driver);
 }
 subsys_initcall(sx150x_init);
+
+MODULE_DESCRIPTION("Semtech SX150x I2C GPIO expander pinctrl driver");
+MODULE_LICENSE("GPL");

-- 
2.34.1

Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

Posted by Linus Walleij 1 month, 2 weeks ago

On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
<fange.zhang@oss.qualcomm.com> wrote:

> Set PINCTRL_SX150X config option as a tristate and add
> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>
> Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>

Fair enough!

This patch 1/2 applied to the pinctrl tree.

Please funnel patch 2/2 through the SoC tree.

> subsys_initcall(sx150x_init

I seriously wonder about this. It feels like this driver should
be a pure module_init() device. But other users may disagree.

Yours,
Linus Walleij

Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

Posted by Fange Zhang 1 month, 2 weeks ago


On 8/19/2025 8:55 PM, Linus Walleij wrote:
> On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
> <fange.zhang@oss.qualcomm.com> wrote:
> 
>> Set PINCTRL_SX150X config option as a tristate and add
>> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>>
>> Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>
> 
> Fair enough!
> 
> This patch 1/2 applied to the pinctrl tree.

Thanks

> 
> Please funnel patch 2/2 through the SoC tree.

Hi Bjorn, Konrad,

Would it be acceptable to include this defconfig change, or is there a 
preferred process I should follow to get it reviewed and accepted?

Thanks,
Fange Zhang

> 
>> subsys_initcall(sx150x_init
> 
> I seriously wonder about this. It feels like this driver should
> be a pure module_init() device. But other users may disagree.
> 
> Yours,
> Linus Walleij

Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 20/08/2025 04:55, Fange Zhang wrote:
> 
> 
> On 8/19/2025 8:55 PM, Linus Walleij wrote:
>> On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
>> <fange.zhang@oss.qualcomm.com> wrote:
>>
>>> Set PINCTRL_SX150X config option as a tristate and add
>>> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>>>
>>> Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>
>>
>> Fair enough!
>>
>> This patch 1/2 applied to the pinctrl tree.
> 
> Thanks
> 
>>
>> Please funnel patch 2/2 through the SoC tree.
> 
> Hi Bjorn, Konrad,
> 
> Would it be acceptable to include this defconfig change, or is there a 
> preferred process I should follow to get it reviewed and accepted?

You need to send it to them... Cc-ing people on random email does not
solve the problem. You need to send the patch to proper maintainers.

Best regards,
Krzysztof

Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

Posted by Fange Zhang 1 month, 2 weeks ago


On 8/20/2025 2:18 PM, Krzysztof Kozlowski wrote:
> On 20/08/2025 04:55, Fange Zhang wrote:
>>
>>
>> On 8/19/2025 8:55 PM, Linus Walleij wrote:
>>> On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
>>> <fange.zhang@oss.qualcomm.com> wrote:
>>>
>>>> Set PINCTRL_SX150X config option as a tristate and add
>>>> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>>>>
>>>> Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>
>>>
>>> Fair enough!
>>>
>>> This patch 1/2 applied to the pinctrl tree.
>>
>> Thanks
>>
>>>
>>> Please funnel patch 2/2 through the SoC tree.
>>
>> Hi Bjorn, Konrad,
>>
>> Would it be acceptable to include this defconfig change, or is there a
>> preferred process I should follow to get it reviewed and accepted?
> 
> You need to send it to them... Cc-ing people on random email does not
> solve the problem. You need to send the patch to proper maintainers.

Got it, will update in next patch

> 
> Best regards,
> Krzysztof