binder: remove MODULE_LICENSE()

[PATCH] binder: remove MODULE_LICENSE()

Posted by Carlos Llamas 1 month, 2 weeks ago

The MODULE_LICENSE() macro is intended for drivers that can be built as
loadable modules. The binder driver is always built-in, using this macro
here is unnecessary and potentially confusing. Remove it.

Cc: Salvatore Bonaccorso <carnil@debian.org>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
 drivers/android/binder.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 312b462e349d..28634f786e70 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -7088,5 +7088,3 @@ device_initcall(binder_init);
 
 #define CREATE_TRACE_POINTS
 #include "binder_trace.h"
-
-MODULE_LICENSE("GPL v2");
-- 
2.51.0.rc1.163.g2494970778-goog

Re: [PATCH] binder: remove MODULE_LICENSE()

Posted by Tiffany Yang 1 month, 2 weeks ago

Carlos Llamas <cmllamas@google.com> writes:

> The MODULE_LICENSE() macro is intended for drivers that can be built as
> loadable modules. The binder driver is always built-in, using this macro
> here is unnecessary and potentially confusing. Remove it.

> Cc: Salvatore Bonaccorso <carnil@debian.org>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
>   drivers/android/binder.c | 2 --
>   1 file changed, 2 deletions(-)

> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 312b462e349d..28634f786e70 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -7088,5 +7088,3 @@ device_initcall(binder_init);

>   #define CREATE_TRACE_POINTS
>   #include "binder_trace.h"
> -
> -MODULE_LICENSE("GPL v2");

Reviewed-by: Tiffany Yang <ynaffit@google.com>

-- 
Tiffany Y. Yang