Hi all,
This v7 series follows up on v6 of the
"scsi: sd: Fix build warning in sd_revalidate_disk()" patches.
On Mon, 11 Aug 2025 09:39 Damien Le Moal wrote:
> The order of the patches must be reversed because the fix build warning patch
> must be CC-ed to stable with a Fixes tag. The cleanup making
> sd_revalidate_disk() a void function must come after the fix. That will avoid
> the weird placeholder comment and also will allow a more extensive cleanup to
> replace several "goto out" with a simple return.
Damien Le Moal pointed out that the order of the patches should be reversed:
The build warning fix must come first, since it requires a Fixes tag
and should be CC-ed to stable.
The cleanup making sd_revalidate_disk() return void should follow afterwards,
which also allows for a cleaner refactor without placeholder comments and prepares
for further simplifications.
Changes in v7:
Reversed patch order:
Fix build warning in sd_revalidate_disk() (with Fixes and Cc: stable)
Refactor sd_revalidate_disk() to return void
I have built and tested this series locally with both gcc and clang;
no build errors or warnings remain.
Many thanks to Damien for the review and guidance.
Abinash Singh (2):
scsi: sd: Fix build warning in sd_revalidate_disk()
scsi: sd: make sd_revalidate_disk() return void
drivers/scsi/sd.c | 58 +++++++++++++++++++++++++++--------------------
1 file changed, 33 insertions(+), 25 deletions(-)
--
2.43.0