According to Radxa E52C Schematic V1.2 [1] page 5, vcc_3v3_pmu
is directly connected to vcc_3v3_s3 via a 0 ohm resistor.
The vcc_3v3_pmu is not a new regulator, so remove it.

[1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 1883bd183396..4a3ae95f122f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -98,16 +98,6 @@ vcc_1v1_nldo_s3: regulator-1v1 {
 		vin-supply = <&vcc_sysin>;
 	};
 
-	vcc_3v3_pmu: regulator-3v3-0 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_3v3_pmu";
-		regulator-always-on;
-		regulator-boot-on;
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		vin-supply = <&vcc_3v3_s3>;
-	};
-
 	vcc_3v3_s0: regulator-3v3-1 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_3v3_s0";
@@ -255,7 +245,7 @@ eeprom@50 {
 		reg = <0x50>;
 		pagesize = <16>;
 		read-only;
-		vcc-supply = <&vcc_3v3_pmu>;
+		vcc-supply = <&vcc_3v3_s3>;
 	};
 };
 
-- 
2.25.1

Hi Chukun,

On 8/16/25 17:00, Chukun Pan wrote:
> According to Radxa E52C Schematic V1.2 [1] page 5, vcc_3v3_pmu
> is directly connected to vcc_3v3_s3 via a 0 ohm resistor.
> The vcc_3v3_pmu is not a new regulator, so remove it.
> 
> [1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 1883bd183396..4a3ae95f122f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -98,16 +98,6 @@ vcc_1v1_nldo_s3: regulator-1v1 {
>   		vin-supply = <&vcc_sysin>;
>   	};
>   
> -	vcc_3v3_pmu: regulator-3v3-0 {
> -		compatible = "regulator-fixed";
> -		regulator-name = "vcc_3v3_pmu";
> -		regulator-always-on;
> -		regulator-boot-on;
> -		regulator-min-microvolt = <3300000>;
> -		regulator-max-microvolt = <3300000>;
> -		vin-supply = <&vcc_3v3_s3>;
> -	};
> -
>   	vcc_3v3_s0: regulator-3v3-1 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "vcc_3v3_s0";
> @@ -255,7 +245,7 @@ eeprom@50 {
>   		reg = <0x50>;
>   		pagesize = <16>;
>   		read-only;
> -		vcc-supply = <&vcc_3v3_pmu>;
> +		vcc-supply = <&vcc_3v3_s3>;

How about the following instead?

@@ -538,7 +538,7 @@ regulator-state-mem {
  				};
  			};

-			vcc_3v3_s3: dcdc-reg8 {
+			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
  				regulator-name = "vcc_3v3_s3";
  				regulator-always-on;
  				regulator-boot-on;

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>   	};
>   };
>

Hi,

> How about the following instead?
>
> @@ -538,7 +538,7 @@ regulator-state-mem {
> 				};
> 			};
>
> -			vcc_3v3_s3: dcdc-reg8 {
> +			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
> 				regulator-name = "vcc_3v3_s3";
> 				regulator-always-on;
> 				regulator-boot-on;

On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
is also connected through a 0 ohm resistor, so I didn't write like
this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19

Thanks,
Chukun

--
2.25.1

Hi Chukun,

On 8/19/25 22:40, Chukun Pan wrote:
> Hi,
> 
>> How about the following instead?
>>
>> @@ -538,7 +538,7 @@ regulator-state-mem {
>> 				};
>> 			};
>>
>> -			vcc_3v3_s3: dcdc-reg8 {
>> +			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
>> 				regulator-name = "vcc_3v3_s3";
>> 				regulator-always-on;
>> 				regulator-boot-on;
> 
> On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
> is also connected through a 0 ohm resistor, so I didn't write like
> this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19

I think it should match the schematic, i.e. it should be "vcc-supply = 
<&vccio_flash>;".

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Thanks,
> Chukun
> 
> --
> 2.25.1
> 
> 
>

Am Mittwoch, 20. August 2025, 04:10:24 Mitteleuropäische Sommerzeit schrieb FUKAUMI Naoki:
> Hi Chukun,
> 
> On 8/19/25 22:40, Chukun Pan wrote:
> > Hi,
> > 
> >> How about the following instead?
> >>
> >> @@ -538,7 +538,7 @@ regulator-state-mem {
> >> 				};
> >> 			};
> >>
> >> -			vcc_3v3_s3: dcdc-reg8 {
> >> +			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
> >> 				regulator-name = "vcc_3v3_s3";
> >> 				regulator-always-on;
> >> 				regulator-boot-on;
> > 
> > On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
> > is also connected through a 0 ohm resistor, so I didn't write like
> > this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19
> 
> I think it should match the schematic, i.e. it should be "vcc-supply = 
> <&vccio_flash>;".

I very much agree :-) .

Having at least the phandle match the schematics nameing is very helpful
when someone tries to look something up between those two.


Heiko