Update the TI TWL family Device Tree binding to include additional
subnodes for TWL4030, TWL6030, and TWL6032 devices.
The simple power and PWM bindings (ti,twl4030-power, ti,twl-pwm, and
ti,twl-pwmled) are now defined directly within this binding.
Other child node definitions (audio, gpio, keypad, usb, etc.) are also
added to the schema. These additions fix 'unevaluated properties'
errors found during dtbs_check for boards like the omap3-beagle
and improve the binding's overall completeness.
Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
Changes in v3:
- New patch to consolidate simple bindings (power, pwm) and add
definitions for all child nodes to fix dtbs_check validation
errors found in v2.
---
.../devicetree/bindings/mfd/ti,twl.yaml | 191 ++++++++++++++++++
.../devicetree/bindings/mfd/twl4030-power.txt | 48 -----
.../devicetree/bindings/pwm/ti,twl-pwm.txt | 17 --
.../devicetree/bindings/pwm/ti,twl-pwmled.txt | 17 --
4 files changed, 191 insertions(+), 82 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/twl4030-power.txt
delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt
delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt
diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
index f162ab60c..b0f1cb7b5 100644
--- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
@@ -76,6 +76,98 @@ allOf:
properties:
compatible:
const: ti,twl4030-wdt
+
+ audio:
+ type: object
+ $ref: /schemas/sound/ti,twl4030-audio.yaml#
+ unevaluatedProperties: false
+
+ keypad:
+ type: object
+ $ref: /schemas/input/ti,twl4030-keypad.yaml#
+ unevaluatedProperties: false
+
+ pwm:
+ type: object
+ $ref: /schemas/pwm/pwm.yaml#
+ unevaluatedProperties: false
+ description: |
+ TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals)
+ properties:
+ compatible:
+ enum:
+ - ti,twl4030-pwm
+ '#pwm-cells':
+ const: 2
+ required:
+ - compatible
+ - '#pwm-cells'
+
+ pwmled:
+ type: object
+ $ref: /schemas/pwm/pwm.yaml#
+ unevaluatedProperties: false
+ description: |
+ TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals)
+ properties:
+ compatible:
+ enum:
+ - ti,twl4030-pwmled
+ '#pwm-cells':
+ const: 2
+ required:
+ - compatible
+ - '#pwm-cells'
+
+ 'twl4030-usb':
+ type: object
+ $ref: /schemas/usb/ti,twlxxxx-usb.yaml#
+ unevaluatedProperties: false
+
+ gpio:
+ type: object
+ $ref: /schemas/gpio/ti,twl4030-gpio.yaml#
+ unevaluatedProperties: false
+
+ power:
+ type: object
+ additionalProperties: false
+ description:
+ The power management module inside the TWL4030 provides several facilities
+ to control the power resources, including power scripts. For now, the
+ binding only supports the complete shutdown of the system after poweroff.
+ properties:
+ compatible:
+ description: |
+ The compatible string determines the specific power configuration.
+ "ti,twl4030-power": Standard power control.
+ "ti,twl4030-power-reset": Recommended for OMAP3530 and similar SoCs
+ that require a special configuration for warm reset to work correctly.
+ "ti,twl4030-power-idle": Loads the TI-recommended configuration for
+ idle modes into the PMIC.
+ "ti,twl4030-power-idle-osc-off": Uses the recommended idle configuration
+ but also shuts down the external oscillator. This may not work on all
+ boards depending on the oscillator wiring.
+ enum:
+ - ti,twl4030-power
+ - ti,twl4030-power-reset
+ - ti,twl4030-power-idle
+ - ti,twl4030-power-idle-osc-off
+
+ ti,system-power-controller:
+ type: boolean
+ deprecated: true
+ description: |
+ DEPRECATED. The standard 'system-power-controller' property
+ on the parent node should be used instead.
+
+ ti,use_poweroff:
+ type: boolean
+ deprecated: true
+
+ required:
+ - compatible
+
- if:
properties:
compatible:
@@ -115,6 +207,44 @@ allOf:
properties:
compatible:
const: ti,twl6030-gpadc
+
+ pwm:
+ type: object
+ $ref: /schemas/pwm/pwm.yaml#
+ unevaluatedProperties: false
+ description: |
+ TWL6030 series: LED PWM (mainly used as charging indicator LED)
+ properties:
+ compatible:
+ enum:
+ - ti,twl6030-pwm
+ '#pwm-cells':
+ const: 2
+ required:
+ - compatible
+ - '#pwm-cells'
+
+ pwmled:
+ type: object
+ $ref: /schemas/pwm/pwm.yaml#
+ unevaluatedProperties: false
+ description: |
+ TWL6030 series: LED PWM (mainly used as charging indicator LED)
+ properties:
+ compatible:
+ enum:
+ - ti,twl6030-pwmled
+ '#pwm-cells':
+ const: 2
+ required:
+ - compatible
+ - '#pwm-cells'
+
+ 'twl6030-usb':
+ type: object
+ $ref: /schemas/usb/ti,twlxxxx-usb.yaml#
+ unevaluatedProperties: false
+
- if:
properties:
compatible:
@@ -154,6 +284,43 @@ allOf:
compatible:
const: ti,twl6032-gpadc
+ pwm:
+ type: object
+ $ref: /schemas/pwm/pwm.yaml#
+ unevaluatedProperties: false
+ description: |
+ TWL6030 series: LED PWM (mainly used as charging indicator LED)
+ properties:
+ compatible:
+ enum:
+ - ti,twl6030-pwm
+ '#pwm-cells':
+ const: 2
+ required:
+ - compatible
+ - '#pwm-cells'
+
+ pwmled:
+ type: object
+ $ref: /schemas/pwm/pwm.yaml#
+ unevaluatedProperties: false
+ description: |
+ TWL6030 series: LED PWM (mainly used as charging indicator LED)
+ properties:
+ compatible:
+ enum:
+ - ti,twl6030-pwmled
+ '#pwm-cells':
+ const: 2
+ required:
+ - compatible
+ - '#pwm-cells'
+
+ 'twl6030-usb':
+ type: object
+ $ref: /schemas/usb/ti,twlxxxx-usb.yaml
+ unevaluatedProperties: false
+
properties:
compatible:
description:
@@ -271,6 +438,16 @@ examples:
compatible = "ti,twl6030-vmmc";
ti,retain-on-reset;
};
+
+ pwm {
+ compatible = "ti,twl6030-pwm";
+ #pwm-cells = <2>;
+ };
+
+ pwmled {
+ compatible = "ti,twl6030-pwmled";
+ #pwm-cells = <2>;
+ };
};
};
@@ -325,6 +502,20 @@ examples:
watchdog {
compatible = "ti,twl4030-wdt";
};
+
+ power {
+ compatible = "ti,twl4030-power";
+ };
+
+ pwm {
+ compatible = "ti,twl4030-pwm";
+ #pwm-cells = <2>;
+ };
+
+ pwmled {
+ compatible = "ti,twl4030-pwmled";
+ #pwm-cells = <2>;
+ };
};
};
...
diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
deleted file mode 100644
index 3d1996331..000000000
--- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
+++ /dev/null
@@ -1,48 +0,0 @@
-Texas Instruments TWL family (twl4030) reset and power management module
-
-The power management module inside the TWL family provides several facilities
-to control the power resources, including power scripts. For now, the
-binding only supports the complete shutdown of the system after poweroff.
-
-Required properties:
-- compatible : must be one of the following
- "ti,twl4030-power"
- "ti,twl4030-power-reset"
- "ti,twl4030-power-idle"
- "ti,twl4030-power-idle-osc-off"
-
-The use of ti,twl4030-power-reset is recommended at least on
-3530 that needs a special configuration for warm reset to work.
-
-When using ti,twl4030-power-idle, the TI recommended configuration
-for idle modes is loaded to the tlw4030 PMIC.
-
-When using ti,twl4030-power-idle-osc-off, the TI recommended
-configuration is used with the external oscillator being shut
-down during off-idle. Note that this does not work on all boards
-depending on how the external oscillator is wired.
-
-Optional properties:
-
-- ti,system-power-controller: This indicates that TWL4030 is the
- power supply master of the system. With this flag, the chip will
- initiate an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
- system poweroffs.
-
-- ti,use_poweroff: Deprecated name for ti,system-power-controller
-
-Example:
-&i2c1 {
- clock-frequency = <2600000>;
-
- twl: twl@48 {
- reg = <0x48>;
- interrupts = <7>; /* SYS_NIRQ cascaded to intc */
- interrupt-parent = <&intc>;
-
- twl_power: power {
- compatible = "ti,twl4030-power";
- ti,use_poweroff;
- };
- };
-};
diff --git a/Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt b/Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt
deleted file mode 100644
index d97ca1964..000000000
--- a/Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Texas Instruments TWL series PWM drivers
-
-Supported PWMs:
-On TWL4030 series: PWM1 and PWM2
-On TWL6030 series: PWM0 and PWM1
-
-Required properties:
-- compatible: "ti,twl4030-pwm" or "ti,twl6030-pwm"
-- #pwm-cells: should be 2. See pwm.yaml in this directory for a description of
- the cells format.
-
-Example:
-
-twl_pwm: pwm {
- compatible = "ti,twl6030-pwm";
- #pwm-cells = <2>;
-};
diff --git a/Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt b/Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt
deleted file mode 100644
index 31ca1b032..000000000
--- a/Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Texas Instruments TWL series PWM drivers connected to LED terminals
-
-Supported PWMs:
-On TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals)
-On TWL6030 series: LED PWM (mainly used as charging indicator LED)
-
-Required properties:
-- compatible: "ti,twl4030-pwmled" or "ti,twl6030-pwmled"
-- #pwm-cells: should be 2. See pwm.yaml in this directory for a description of
- the cells format.
-
-Example:
-
-twl_pwmled: pwmled {
- compatible = "ti,twl6030-pwmled";
- #pwm-cells = <2>;
-};
--
2.39.5On Sat, Aug 16, 2025 at 04:15:18AM +0200, Jihed Chaibi wrote: > Update the TI TWL family Device Tree binding to include additional > subnodes for TWL4030, TWL6030, and TWL6032 devices. > > The simple power and PWM bindings (ti,twl4030-power, ti,twl-pwm, and > ti,twl-pwmled) are now defined directly within this binding. > > Other child node definitions (audio, gpio, keypad, usb, etc.) are also > added to the schema. These additions fix 'unevaluated properties' > errors found during dtbs_check for boards like the omap3-beagle > and improve the binding's overall completeness. > > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com> > > --- > Changes in v3: > - New patch to consolidate simple bindings (power, pwm) and add > definitions for all child nodes to fix dtbs_check validation > errors found in v2. > --- > .../devicetree/bindings/mfd/ti,twl.yaml | 191 ++++++++++++++++++ > .../devicetree/bindings/mfd/twl4030-power.txt | 48 ----- > .../devicetree/bindings/pwm/ti,twl-pwm.txt | 17 -- > .../devicetree/bindings/pwm/ti,twl-pwmled.txt | 17 -- > 4 files changed, 191 insertions(+), 82 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/twl4030-power.txt > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt > > diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > index f162ab60c..b0f1cb7b5 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > @@ -76,6 +76,98 @@ allOf: > properties: > compatible: > const: ti,twl4030-wdt > + > + audio: > + type: object > + $ref: /schemas/sound/ti,twl4030-audio.yaml# > + unevaluatedProperties: false > + > + keypad: > + type: object > + $ref: /schemas/input/ti,twl4030-keypad.yaml# > + unevaluatedProperties: false > + > + pwm: > + type: object > + $ref: /schemas/pwm/pwm.yaml# > + unevaluatedProperties: false > + description: | > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > + properties: > + compatible: > + enum: > + - ti,twl4030-pwm > + '#pwm-cells': > + const: 2 > + required: > + - compatible > + - '#pwm-cells' > + > + pwmled: > + type: object > + $ref: /schemas/pwm/pwm.yaml# > + unevaluatedProperties: false > + description: | > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > + properties: > + compatible: > + enum: > + - ti,twl4030-pwmled > + '#pwm-cells': > + const: 2 > + required: > + - compatible > + - '#pwm-cells' > + > + 'twl4030-usb': No need for quotes. > + type: object > + $ref: /schemas/usb/ti,twlxxxx-usb.yaml# Are you sure your patchset is bsiectable? Apply this patch and test. You will see errors and you must fix these. Even after fixing you have strict dependencies so your cover letter must explain these (or merging constraints)... I suggest listing here only compatible with additionalProperties:true and splitting entire patchset per different maintainers. Best regards, Krzysztof
Am Tue, 19 Aug 2025 10:13:39 +0200 schrieb Krzysztof Kozlowski <krzk@kernel.org>: > On Sat, Aug 16, 2025 at 04:15:18AM +0200, Jihed Chaibi wrote: > > Update the TI TWL family Device Tree binding to include additional > > subnodes for TWL4030, TWL6030, and TWL6032 devices. > > > > The simple power and PWM bindings (ti,twl4030-power, ti,twl-pwm, and > > ti,twl-pwmled) are now defined directly within this binding. > > > > Other child node definitions (audio, gpio, keypad, usb, etc.) are also > > added to the schema. These additions fix 'unevaluated properties' > > errors found during dtbs_check for boards like the omap3-beagle > > and improve the binding's overall completeness. > > > > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com> > > > > --- > > Changes in v3: > > - New patch to consolidate simple bindings (power, pwm) and add > > definitions for all child nodes to fix dtbs_check validation > > errors found in v2. > > --- > > .../devicetree/bindings/mfd/ti,twl.yaml | 191 ++++++++++++++++++ > > .../devicetree/bindings/mfd/twl4030-power.txt | 48 ----- > > .../devicetree/bindings/pwm/ti,twl-pwm.txt | 17 -- > > .../devicetree/bindings/pwm/ti,twl-pwmled.txt | 17 -- > > 4 files changed, 191 insertions(+), 82 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mfd/twl4030-power.txt > > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt > > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > index f162ab60c..b0f1cb7b5 100644 > > --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > @@ -76,6 +76,98 @@ allOf: > > properties: > > compatible: > > const: ti,twl4030-wdt > > + > > + audio: > > + type: object > > + $ref: /schemas/sound/ti,twl4030-audio.yaml# > > + unevaluatedProperties: false > > + > > + keypad: > > + type: object > > + $ref: /schemas/input/ti,twl4030-keypad.yaml# > > + unevaluatedProperties: false > > + > > + pwm: > > + type: object > > + $ref: /schemas/pwm/pwm.yaml# > > + unevaluatedProperties: false > > + description: | > > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > > + properties: > > + compatible: > > + enum: > > + - ti,twl4030-pwm > > + '#pwm-cells': > > + const: 2 > > + required: > > + - compatible > > + - '#pwm-cells' > > + > > + pwmled: > > + type: object > > + $ref: /schemas/pwm/pwm.yaml# > > + unevaluatedProperties: false > > + description: | > > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > > + properties: > > + compatible: > > + enum: > > + - ti,twl4030-pwmled > > + '#pwm-cells': > > + const: 2 > > + required: > > + - compatible > > + - '#pwm-cells' > > + > > + 'twl4030-usb': > > No need for quotes. > > > + type: object > > + $ref: /schemas/usb/ti,twlxxxx-usb.yaml# > > Are you sure your patchset is bsiectable? Apply this patch and test. You > will see errors and you must fix these. Even after fixing you have > strict dependencies so your cover letter must explain these (or merging > constraints)... > what are the rules here regarding bisectability? non-existing files in $ref are probably bad. Are then unveiled errors in dts also a problem? I would not expect too much fixing effort needed here. I have not run dtbs_check yet. I have expected this would all go via Lee's usual immutable branches. Regards, Andreas
On 19/08/2025 22:31, Andreas Kemnade wrote: >> >>> + type: object >>> + $ref: /schemas/usb/ti,twlxxxx-usb.yaml# >> >> Are you sure your patchset is bsiectable? Apply this patch and test. You >> will see errors and you must fix these. Even after fixing you have >> strict dependencies so your cover letter must explain these (or merging >> constraints)... >> > what are the rules here regarding bisectability? non-existing files dt_binding_check. Best regards, Krzysztof
On Wed, Aug 20, 2025 at 7:57 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 19/08/2025 22:31, Andreas Kemnade wrote: > >> > >>> + type: object > >>> + $ref: /schemas/usb/ti,twlxxxx-usb.yaml# > >> > >> Are you sure your patchset is bsiectable? Apply this patch and test. You > >> will see errors and you must fix these. Even after fixing you have > >> strict dependencies so your cover letter must explain these (or merging > >> constraints)... > >> > > what are the rules here regarding bisectability? non-existing files > > dt_binding_check. > > > Best regards, > Krzysztof Hello Krzysztof and Andreas, Thanks again for your feedback, You were right that my series had strict dependencies. Testing again I found that a local 'dt_binding_check' -only including this patch- passed, but the dependencies (non-existent yaml files in $ref) caused errors during a full 'dtbs_check'. I managed to fix those dtbs_check warnings/errors thanks to 'additionalProperties: true' to break the hard dependencies on the other new YAML files, and by adding optional definitions for the 'clocks' and 'clock-names' properties, which I found are used by several OMAP dts files. Please let me know what you think of this, and whether I should send the new, corrected v4 of this MFD (single) patch. I have already sent the independent v4 patches for the other subsystems (ASoC, USB, etc.). in order to reach a much better orthogonality and independence between the patches. Thanks again for your guidance. Best regards, Jihed
On Tue, Aug 19, 2025 at 10:13 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Sat, Aug 16, 2025 at 04:15:18AM +0200, Jihed Chaibi wrote: > > Update the TI TWL family Device Tree binding to include additional > > subnodes for TWL4030, TWL6030, and TWL6032 devices. > > > > The simple power and PWM bindings (ti,twl4030-power, ti,twl-pwm, and > > ti,twl-pwmled) are now defined directly within this binding. > > > > Other child node definitions (audio, gpio, keypad, usb, etc.) are also > > added to the schema. These additions fix 'unevaluated properties' > > errors found during dtbs_check for boards like the omap3-beagle > > and improve the binding's overall completeness. > > > > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com> > > > > --- > > Changes in v3: > > - New patch to consolidate simple bindings (power, pwm) and add > > definitions for all child nodes to fix dtbs_check validation > > errors found in v2. > > --- > > .../devicetree/bindings/mfd/ti,twl.yaml | 191 ++++++++++++++++++ > > .../devicetree/bindings/mfd/twl4030-power.txt | 48 ----- > > .../devicetree/bindings/pwm/ti,twl-pwm.txt | 17 -- > > .../devicetree/bindings/pwm/ti,twl-pwmled.txt | 17 -- > > 4 files changed, 191 insertions(+), 82 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mfd/twl4030-power.txt > > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt > > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > index f162ab60c..b0f1cb7b5 100644 > > --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > @@ -76,6 +76,98 @@ allOf: > > properties: > > compatible: > > const: ti,twl4030-wdt > > + > > + audio: > > + type: object > > + $ref: /schemas/sound/ti,twl4030-audio.yaml# > > + unevaluatedProperties: false > > + > > + keypad: > > + type: object > > + $ref: /schemas/input/ti,twl4030-keypad.yaml# > > + unevaluatedProperties: false > > + > > + pwm: > > + type: object > > + $ref: /schemas/pwm/pwm.yaml# > > + unevaluatedProperties: false > > + description: | > > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > > + properties: > > + compatible: > > + enum: > > + - ti,twl4030-pwm > > + '#pwm-cells': > > + const: 2 > > + required: > > + - compatible > > + - '#pwm-cells' > > + > > + pwmled: > > + type: object > > + $ref: /schemas/pwm/pwm.yaml# > > + unevaluatedProperties: false > > + description: | > > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > > + properties: > > + compatible: > > + enum: > > + - ti,twl4030-pwmled > > + '#pwm-cells': > > + const: 2 > > + required: > > + - compatible > > + - '#pwm-cells' > > + > > + 'twl4030-usb': > > No need for quotes. > > > + type: object > > + $ref: /schemas/usb/ti,twlxxxx-usb.yaml# > > Are you sure your patchset is bsiectable? Apply this patch and test. You > will see errors and you must fix these. Even after fixing you have > strict dependencies so your cover letter must explain these (or merging > constraints)... > > I suggest listing here only compatible with additionalProperties:true > and splitting entire patchset per different maintainers. Hi Krzysztof, Thank you for the review. That additionalProperties suggestion is definitely helpful in this scenario. I will split (in v4) the patchset into smaller & independent series for each subsystem as recommended. Thanks again for your guidance. Jihed
© 2016 - 2025 Red Hat, Inc.