[PATCH 0/5] Add ethernet support for RPi5

Stanimir Varbanov posted 5 patches 1 month, 2 weeks ago
.../devicetree/bindings/net/cdns,macb.yaml     |  1 +
.../boot/dts/broadcom/bcm2712-rpi-5-b.dts      | 18 ++++++++++++++++++
arch/arm64/boot/dts/broadcom/rp1-common.dtsi   | 16 ++++++++++++++++
drivers/net/ethernet/cadence/macb_main.c       | 17 +++++++++++++++++
4 files changed, 52 insertions(+)
[PATCH 0/5] Add ethernet support for RPi5
Posted by Stanimir Varbanov 1 month, 2 weeks ago
Hello,

Few patches to enable support of ethernet on RPi5.

 - first patch is setting upper 32bits of DMA RX ring buffer in case of
   RX queue corruption.
 - second patch is adding a new compatible in cdns,macb yaml document
 - third patch adds compatible and configuration for raspberrypi,rp1-gem
 - forth and fifth patches are adding and enabling ethernet DT node on
   RPi5.

Comments are welcome!

Regards,
~Stan

Dave Stevenson (2):
  dt-bindings: net: cdns,macb: Add compatible for Raspberry Pi RP1
  net: cadence: macb: Add support for Raspberry Pi RP1 ethernet
    controller

Stanimir Varbanov (3):
  net: cadence: macb: Set upper 32bits of DMA ring buffer
  arm64: dts: rp1: Add ethernet DT node
  arm64: dts: broadcom: Enable RP1 ethernet for Raspberry Pi 5

 .../devicetree/bindings/net/cdns,macb.yaml     |  1 +
 .../boot/dts/broadcom/bcm2712-rpi-5-b.dts      | 18 ++++++++++++++++++
 arch/arm64/boot/dts/broadcom/rp1-common.dtsi   | 16 ++++++++++++++++
 drivers/net/ethernet/cadence/macb_main.c       | 17 +++++++++++++++++
 4 files changed, 52 insertions(+)

-- 
2.47.0
Re: [PATCH 0/5] Add ethernet support for RPi5
Posted by Florian Fainelli 1 month, 2 weeks ago
On 8/15/25 06:59, Stanimir Varbanov wrote:
> Hello,
> 
> Few patches to enable support of ethernet on RPi5.
> 
>   - first patch is setting upper 32bits of DMA RX ring buffer in case of
>     RX queue corruption.
>   - second patch is adding a new compatible in cdns,macb yaml document
>   - third patch adds compatible and configuration for raspberrypi,rp1-gem
>   - forth and fifth patches are adding and enabling ethernet DT node on
>     RPi5.
> 
> Comments are welcome!

netdev maintainers, do you mind if I take patches 2, 4 and 5 via the 
Broadcom ARM SoC tree to avoid generating conflicts down the road? You 
can take patches 1 and 3. Thanks
-- 
Florian
Re: [PATCH 0/5] Add ethernet support for RPi5
Posted by Jakub Kicinski 1 month, 2 weeks ago
On Mon, 18 Aug 2025 11:02:15 -0700 Florian Fainelli wrote:
> > Few patches to enable support of ethernet on RPi5.
> > 
> >   - first patch is setting upper 32bits of DMA RX ring buffer in case of
> >     RX queue corruption.
> >   - second patch is adding a new compatible in cdns,macb yaml document
> >   - third patch adds compatible and configuration for raspberrypi,rp1-gem
> >   - forth and fifth patches are adding and enabling ethernet DT node on
> >     RPi5.
> > 
> > Comments are welcome!  
> 
> netdev maintainers, do you mind if I take patches 2, 4 and 5 via the 
> Broadcom ARM SoC tree to avoid generating conflicts down the road? You 
> can take patches 1 and 3. Thanks

4, 5 make perfect sense, why patch 2? We usually take bindings.
Re: [PATCH 0/5] Add ethernet support for RPi5
Posted by Florian Fainelli 1 month, 2 weeks ago
On 8/18/25 11:50, Jakub Kicinski wrote:
> On Mon, 18 Aug 2025 11:02:15 -0700 Florian Fainelli wrote:
>>> Few patches to enable support of ethernet on RPi5.
>>>
>>>    - first patch is setting upper 32bits of DMA RX ring buffer in case of
>>>      RX queue corruption.
>>>    - second patch is adding a new compatible in cdns,macb yaml document
>>>    - third patch adds compatible and configuration for raspberrypi,rp1-gem
>>>    - forth and fifth patches are adding and enabling ethernet DT node on
>>>      RPi5.
>>>
>>> Comments are welcome!
>>
>> netdev maintainers, do you mind if I take patches 2, 4 and 5 via the
>> Broadcom ARM SoC tree to avoid generating conflicts down the road? You
>> can take patches 1 and 3. Thanks
> 
> 4, 5 make perfect sense, why patch 2? We usually take bindings.

Because that way when CI runs against the ARM SoC tree, we don't get 
errors that the bindings are undocumented.
-- 
Florian
Re: [PATCH 0/5] Add ethernet support for RPi5
Posted by Jakub Kicinski 1 month, 2 weeks ago
On Mon, 18 Aug 2025 11:52:28 -0700 Florian Fainelli wrote:
> On 8/18/25 11:50, Jakub Kicinski wrote:
> > On Mon, 18 Aug 2025 11:02:15 -0700 Florian Fainelli wrote:  
> >> netdev maintainers, do you mind if I take patches 2, 4 and 5 via the
> >> Broadcom ARM SoC tree to avoid generating conflicts down the road? You
> >> can take patches 1 and 3. Thanks  
> > 
> > 4, 5 make perfect sense, why patch 2? We usually take bindings.  
> 
> Because that way when CI runs against the ARM SoC tree, we don't get 
> errors that the bindings are undocumented.

Hm, my understanding is that validation should use bindings from
linux-next.. tho I'm not 100% sure. Perhaps DT maintainers can
clarify. This problem exists for all DT changes, unless there's
something exceptional about the patches I'd rather follow the default
process.