[v1] selftests/kselftest_harness: Add harness-selftest.expected to TEST_FILES

[PATCH] selftests/kselftest_harness: Add harness-selftest.expected to TEST_FILES

Posted by Yi Lai 5 months, 3 weeks ago

The harness-selftest.expected is not installed in INSTALL_PATH.
Attempting to execute harness-selftest.sh shows warning:

diff: ./kselftest_harness/harness-selftest.expected: No such file or
directory

Add harness-selftest.expected to TEST_FILES.

Signed-off-by: Yi Lai <yi1.lai@intel.com>
---
 tools/testing/selftests/kselftest_harness/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/kselftest_harness/Makefile b/tools/testing/selftests/kselftest_harness/Makefile
index 0617535a6ce4..d2369c01701a 100644
--- a/tools/testing/selftests/kselftest_harness/Makefile
+++ b/tools/testing/selftests/kselftest_harness/Makefile
@@ -2,6 +2,7 @@
 
 TEST_GEN_PROGS_EXTENDED := harness-selftest
 TEST_PROGS := harness-selftest.sh
+TEST_FILES := harness-selftest.expected
 EXTRA_CLEAN := harness-selftest.seen
 
 include ../lib.mk
-- 
2.43.0

Re: [PATCH] selftests/kselftest_harness: Add harness-selftest.expected to TEST_FILES

Posted by Thomas Weißschuh 5 months, 3 weeks ago

On Fri, Aug 15, 2025 at 05:10:32PM +0800, Yi Lai wrote:
> The harness-selftest.expected is not installed in INSTALL_PATH.
> Attempting to execute harness-selftest.sh shows warning:
> 
> diff: ./kselftest_harness/harness-selftest.expected: No such file or
> directory
> 
> Add harness-selftest.expected to TEST_FILES.
> 
> Signed-off-by: Yi Lai <yi1.lai@intel.com>

Fixes: df82ffc5a3c1 ("selftests: harness: Add kselftest harness selftest")
Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Thanks!

> ---
>  tools/testing/selftests/kselftest_harness/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/kselftest_harness/Makefile b/tools/testing/selftests/kselftest_harness/Makefile
> index 0617535a6ce4..d2369c01701a 100644
> --- a/tools/testing/selftests/kselftest_harness/Makefile
> +++ b/tools/testing/selftests/kselftest_harness/Makefile
> @@ -2,6 +2,7 @@
>  
>  TEST_GEN_PROGS_EXTENDED := harness-selftest
>  TEST_PROGS := harness-selftest.sh
> +TEST_FILES := harness-selftest.expected
>  EXTRA_CLEAN := harness-selftest.seen
>  
>  include ../lib.mk
> -- 
> 2.43.0
>

Re: [PATCH] selftests/kselftest_harness: Add harness-selftest.expected to TEST_FILES

Posted by Lai, Yi 5 months ago

On Fri, Aug 15, 2025 at 11:28:40AM +0200, Thomas Weißschuh wrote:
> On Fri, Aug 15, 2025 at 05:10:32PM +0800, Yi Lai wrote:
> > The harness-selftest.expected is not installed in INSTALL_PATH.
> > Attempting to execute harness-selftest.sh shows warning:
> > 
> > diff: ./kselftest_harness/harness-selftest.expected: No such file or
> > directory
> > 
> > Add harness-selftest.expected to TEST_FILES.
> > 
> > Signed-off-by: Yi Lai <yi1.lai@intel.com>
> 
> Fixes: df82ffc5a3c1 ("selftests: harness: Add kselftest harness selftest")
> Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> 
> Thanks!
>

Sorry for the late response. Thank you for review. I will send a v2
patch containing the fixes tag.

Regards,
Yi Lai

> > ---
> >  tools/testing/selftests/kselftest_harness/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/testing/selftests/kselftest_harness/Makefile b/tools/testing/selftests/kselftest_harness/Makefile
> > index 0617535a6ce4..d2369c01701a 100644
> > --- a/tools/testing/selftests/kselftest_harness/Makefile
> > +++ b/tools/testing/selftests/kselftest_harness/Makefile
> > @@ -2,6 +2,7 @@
> >  
> >  TEST_GEN_PROGS_EXTENDED := harness-selftest
> >  TEST_PROGS := harness-selftest.sh
> > +TEST_FILES := harness-selftest.expected
> >  EXTRA_CLEAN := harness-selftest.seen
> >  
> >  include ../lib.mk
> > -- 
> > 2.43.0
> >

Re: [PATCH] selftests/kselftest_harness: Add harness-selftest.expected to TEST_FILES

Posted by Muhammad Usama Anjum 5 months, 3 weeks ago

On 8/15/25 2:10 PM, Yi Lai wrote:
> The harness-selftest.expected is not installed in INSTALL_PATH.
> Attempting to execute harness-selftest.sh shows warning:
> 
> diff: ./kselftest_harness/harness-selftest.expected: No such file or
> directory
This is a bug. Please try to find which patch had broken this and
add a fixes tag?

> 
> Add harness-selftest.expected to TEST_FILES.
> 
> Signed-off-by: Yi Lai <yi1.lai@intel.com>
> ---
>  tools/testing/selftests/kselftest_harness/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/kselftest_harness/Makefile b/tools/testing/selftests/kselftest_harness/Makefile
> index 0617535a6ce4..d2369c01701a 100644
> --- a/tools/testing/selftests/kselftest_harness/Makefile
> +++ b/tools/testing/selftests/kselftest_harness/Makefile
> @@ -2,6 +2,7 @@
>  
>  TEST_GEN_PROGS_EXTENDED := harness-selftest
>  TEST_PROGS := harness-selftest.sh
> +TEST_FILES := harness-selftest.expected
>  EXTRA_CLEAN := harness-selftest.seen
>  
>  include ../lib.mk


---
Thanks,
Usama