[PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg() prints

Nishanth Menon posted 4 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg() prints
Posted by Nishanth Menon 1 month, 2 weeks ago
Drop the ftrace like dev_dbg() that checkpatch --strict complains about:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+	dev_dbg(dev, "%s\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+	dev_dbg(dev, "%s\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+	dev_dbg(dev, "%s\n", __func__);

Signed-off-by: Nishanth Menon <nm@ti.com>
---
Changes in V3:
* New patch

 drivers/gpu/drm/bridge/ite-it66121.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index aa7b1dcc5d70..9b8ed2fae2f4 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -1384,8 +1384,6 @@ static int it66121_audio_startup(struct device *dev, void *data)
 	int ret;
 	struct it66121_ctx *ctx = dev_get_drvdata(dev);
 
-	dev_dbg(dev, "%s\n", __func__);
-
 	mutex_lock(&ctx->lock);
 	ret = it661221_audio_output_enable(ctx, true);
 	if (ret)
@@ -1401,8 +1399,6 @@ static void it66121_audio_shutdown(struct device *dev, void *data)
 	int ret;
 	struct it66121_ctx *ctx = dev_get_drvdata(dev);
 
-	dev_dbg(dev, "%s\n", __func__);
-
 	mutex_lock(&ctx->lock);
 	ret = it661221_audio_output_enable(ctx, false);
 	if (ret)
@@ -1479,8 +1475,6 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev)
 		.no_capture_mute = 1,
 	};
 
-	dev_dbg(dev, "%s\n", __func__);
-
 	if (!of_property_present(dev->of_node, "#sound-dai-cells")) {
 		dev_info(dev, "No \"#sound-dai-cells\", no audio\n");
 		return 0;
-- 
2.47.0
Re: [PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg() prints
Posted by Dmitry Baryshkov 1 month, 2 weeks ago
On Thu, Aug 14, 2025 at 10:41:03PM -0500, Nishanth Menon wrote:
> Drop the ftrace like dev_dbg() that checkpatch --strict complains about:
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes in V3:
> * New patch
> 
>  drivers/gpu/drm/bridge/ite-it66121.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry
Re: [PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg() prints
Posted by Andrew Davis 1 month, 2 weeks ago
On 8/14/25 10:41 PM, Nishanth Menon wrote:
> Drop the ftrace like dev_dbg() that checkpatch --strict complains about:
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---

Reviewed-by: Andrew Davis <afd@ti.com>

> Changes in V3:
> * New patch
> 
>   drivers/gpu/drm/bridge/ite-it66121.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index aa7b1dcc5d70..9b8ed2fae2f4 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -1384,8 +1384,6 @@ static int it66121_audio_startup(struct device *dev, void *data)
>   	int ret;
>   	struct it66121_ctx *ctx = dev_get_drvdata(dev);
>   
> -	dev_dbg(dev, "%s\n", __func__);
> -
>   	mutex_lock(&ctx->lock);
>   	ret = it661221_audio_output_enable(ctx, true);
>   	if (ret)
> @@ -1401,8 +1399,6 @@ static void it66121_audio_shutdown(struct device *dev, void *data)
>   	int ret;
>   	struct it66121_ctx *ctx = dev_get_drvdata(dev);
>   
> -	dev_dbg(dev, "%s\n", __func__);
> -
>   	mutex_lock(&ctx->lock);
>   	ret = it661221_audio_output_enable(ctx, false);
>   	if (ret)
> @@ -1479,8 +1475,6 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev)
>   		.no_capture_mute = 1,
>   	};
>   
> -	dev_dbg(dev, "%s\n", __func__);
> -
>   	if (!of_property_present(dev->of_node, "#sound-dai-cells")) {
>   		dev_info(dev, "No \"#sound-dai-cells\", no audio\n");
>   		return 0;