regulator: RT5133: add missing HAS_IOMEM dependency

[PATCH] regulator: RT5133: add missing HAS_IOMEM dependency

Posted by Randy Dunlap 5 months, 3 weeks ago

When building on ARCH=um (which does not set HAS_IOMEM), kconfig
reports an unmet dependency caused by REGULATOR_RT5133. It selects
OF_GPIO, which depends on HAS_IOMEM. To stop this warning,
REGULATOR_RT5133 should also depend on HAS_IOMEM.

kconfig warning:
WARNING: unmet direct dependencies detected for OF_GPIO
  Depends on [n]: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n]
  Selected by [y]:
  - REGULATOR_RT5133 [=y] && REGULATOR [=y] && I2C [=y] && GPIOLIB [=y] && OF [=y]

Fixes: 714165e1c4b0 ("regulator: rt5133: Add RT5133 PMIC regulator Support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Jeff Chang <jeff_chang@richtek.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>

 drivers/regulator/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20250814.orig/drivers/regulator/Kconfig
+++ linux-next-20250814/drivers/regulator/Kconfig
@@ -1251,6 +1251,7 @@ config REGULATOR_RT5120
 config REGULATOR_RT5133
 	tristate "Richtek RT5133 PMIC Regulators"
 	depends on I2C && GPIOLIB && OF
+	depends on HAS_IOMEM
 	select REGMAP
 	select CRC8
 	select OF_GPIO

Re: [PATCH] regulator: RT5133: add missing HAS_IOMEM dependency

Posted by Randy Dunlap 5 months, 1 week ago

Hi,

On 8/14/25 7:27 PM, Randy Dunlap wrote:
> When building on ARCH=um (which does not set HAS_IOMEM), kconfig
> reports an unmet dependency caused by REGULATOR_RT5133. It selects
> OF_GPIO, which depends on HAS_IOMEM. To stop this warning,
> REGULATOR_RT5133 should also depend on HAS_IOMEM.
> 
> kconfig warning:
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n]
>   Selected by [y]:
>   - REGULATOR_RT5133 [=y] && REGULATOR [=y] && I2C [=y] && GPIOLIB [=y] && OF [=y]
> 
> Fixes: 714165e1c4b0 ("regulator: rt5133: Add RT5133 PMIC regulator Support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Jeff Chang <jeff_chang@richtek.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> 
>  drivers/regulator/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20250814.orig/drivers/regulator/Kconfig
> +++ linux-next-20250814/drivers/regulator/Kconfig
> @@ -1251,6 +1251,7 @@ config REGULATOR_RT5120
>  config REGULATOR_RT5133
>  	tristate "Richtek RT5133 PMIC Regulators"
>  	depends on I2C && GPIOLIB && OF
> +	depends on HAS_IOMEM
>  	select REGMAP
>  	select CRC8
>  	select OF_GPIO


Ping. Any comments?

thanks.
-- 
~Randy