1. Patchew
  2. linux
  3. [PATCH 0/6] Kselftests: fix spelling mistakes
  4. View patch

[PATCH 2/6] setftests: net: netfilter: fix spelling mistakes in output

Soham Metha posted 6 patches 1 month, 2 weeks ago
Only 2 patches received!
[PATCH 2/6] setftests: net: netfilter: fix spelling mistakes in output
Posted by Soham Metha 1 month, 2 weeks ago 
found/fixed following typos

- add add -> add
- cannnot -> cannot
- fowarded -> forwarded

in `tools/testing/selftests/net/netfilter/nft_nat.sh`

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 .../testing/selftests/net/netfilter/nft_nat.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/tools/testing/selftests/net/netfilter/nft_nat.sh b/tools/testing/selftests/net/netfilter/nft_nat.sh
index a954754b99b3..44a8fdf5c19c 100755
--- a/tools/testing/selftests/net/netfilter/nft_nat.sh
+++ b/tools/testing/selftests/net/netfilter/nft_nat.sh
@@ -164,7 +164,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family dnat hook"
+		echo "SKIP: Could not add $family dnat hook"
 		return $ksft_skip
 	fi
 
@@ -239,7 +239,7 @@ EOF
 			test_inet_nat=false
 			return $ksft_skip
 		fi
-		echo "SKIP: Could not add add $family dnat hook"
+		echo "SKIP: Could not add $family dnat hook"
 		return $ksft_skip
 	fi
 
@@ -418,7 +418,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family masquerade hook"
+		echo "SKIP: Could not add $family masquerade hook"
 		return $ksft_skip
 	fi
 
@@ -509,7 +509,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family masquerade hook"
+		echo "SKIP: Could not add $family masquerade hook"
 		return $ksft_skip
 	fi
 
@@ -569,7 +569,7 @@ test_redirect6()
 	ip netns exec "$ns0" sysctl net.ipv6.conf.all.forwarding=1 > /dev/null
 
 	if ! ip netns exec "$ns2" ping -q -c 1 dead:1::99 > /dev/null;then
-		echo "ERROR: cannnot ping $ns1 from $ns2 via ipv6"
+		echo "ERROR: cannot ping $ns1 from $ns2 via ipv6"
 		lret=1
 	fi
 
@@ -598,7 +598,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family redirect hook"
+		echo "SKIP: Could not add $family redirect hook"
 		return $ksft_skip
 	fi
 
@@ -673,7 +673,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family redirect hook"
+		echo "SKIP: Could not add $family redirect hook"
 		return $ksft_skip
 	fi
 
@@ -844,7 +844,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family masquerade hook"
+		echo "SKIP: Could not add $family masquerade hook"
 		return $ksft_skip
 	fi
 
@@ -859,7 +859,7 @@ EOF
 	# from router:service bypass connection tracking.
 	test_port_shadow_notrack "$family"
 
-	# test nat based mitigation: fowarded packets coming from service port
+	# test nat based mitigation: forwarded packets coming from service port
 	# are masqueraded with random highport.
 	test_port_shadow_pat "$family"
 
-- 
2.34.1
Re: [PATCH 2/6] setftests: net: netfilter: fix spelling mistakes in output
Posted by Florian Westphal 1 month, 2 weeks ago 
Soham Metha <sohammetha01@gmail.com> wrote:
> found/fixed following typos
> 
> - add add -> add
> - cannnot -> cannot
> - fowarded -> forwarded

OK, but what tree are you targetting?

In case netdev maintainers or someone else wants to take it:

Acked-by: Florian Westphal <fw@strlen.de>

Else we can route it via nf-next in the coming week.
[PATCH 3/6] selftests: ublk: fixed spelling mistake in output
Posted by Soham Metha 1 month, 2 weeks ago 
found/fixed following typos

- faile -> failed

in `tools/testing/selftests/ublk/test_common.sh`

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 tools/testing/selftests/ublk/test_common.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ublk/test_common.sh b/tools/testing/selftests/ublk/test_common.sh
index 8a4dbd09feb0..e21476ff1f06 100755
--- a/tools/testing/selftests/ublk/test_common.sh
+++ b/tools/testing/selftests/ublk/test_common.sh
@@ -358,7 +358,7 @@ run_io_and_recover()
 
 	state=$(_recover_ublk_dev -n "$dev_id" "$@")
 	if [ "$state" != "LIVE" ]; then
-		echo "faile to recover to LIVE($state)"
+		echo "failed to recover to LIVE($state)"
 		return 255
 	fi
 
-- 
2.34.1
Re: [PATCH 3/6] selftests: ublk: fixed spelling mistake in output
Posted by Ming Lei 1 month, 2 weeks ago 
On Fri, Aug 15, 2025 at 05:48:00AM +0530, Soham Metha wrote:
> found/fixed following typos
> 
> - faile -> failed
> 
> in `tools/testing/selftests/ublk/test_common.sh`
> 
> Signed-off-by: Soham Metha <sohammetha01@gmail.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming
[PATCH 4/6] selftests: kvm: riscv: fix spelling mistakes in comments
Posted by Soham Metha 1 month, 2 weeks ago 
found/fixed the following typos

- indicies -> indices
- requrired -> required
- guranteed -> guaranteed

in `tools/testing/selftests/kvm/riscv/sbi_pmu_test.c`

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 tools/testing/selftests/kvm/riscv/sbi_pmu_test.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/testing/selftests/kvm/riscv/sbi_pmu_test.c b/tools/testing/selftests/kvm/riscv/sbi_pmu_test.c
index 924a335d2262..6a8818ac036c 100644
--- a/tools/testing/selftests/kvm/riscv/sbi_pmu_test.c
+++ b/tools/testing/selftests/kvm/riscv/sbi_pmu_test.c
@@ -212,7 +212,7 @@ static void update_counter_info(int num_counters)
 	for (i = 0; i < num_counters; i++) {
 		ret = sbi_ecall(SBI_EXT_PMU, SBI_EXT_PMU_COUNTER_GET_INFO, i, 0, 0, 0, 0, 0);
 
-		/* There can be gaps in logical counter indicies*/
+		/* There can be gaps in logical counter indices*/
 		if (ret.error)
 			continue;
 		GUEST_ASSERT_NE(ret.value, 0);
@@ -446,7 +446,7 @@ static void test_pmu_basic_sanity(void)
 		ret = sbi_ecall(SBI_EXT_PMU, SBI_EXT_PMU_COUNTER_GET_INFO, i,
 				0, 0, 0, 0, 0);
 
-		/* There can be gaps in logical counter indicies*/
+		/* There can be gaps in logical counter indices*/
 		if (ret.error)
 			continue;
 		GUEST_ASSERT_NE(ret.value, 0);
@@ -474,7 +474,7 @@ static void test_pmu_events_snaphost(void)
 	struct riscv_pmu_snapshot_data *snapshot_data = snapshot_gva;
 	int i;
 
-	/* Verify presence of SBI PMU and minimum requrired SBI version */
+	/* Verify presence of SBI PMU and minimum required SBI version */
 	verify_sbi_requirement_assert();
 
 	snapshot_set_shmem(snapshot_gpa, 0);
@@ -489,7 +489,7 @@ static void test_pmu_events_snaphost(void)
 		if (counter_mask_available & (BIT(i)))
 			GUEST_ASSERT_EQ(READ_ONCE(snapshot_data->ctr_values[i]), 0);
 	}
-	/* Only these two events are guranteed to be present */
+	/* Only these two events are guaranteed to be present */
 	test_pmu_event_snapshot(SBI_PMU_HW_CPU_CYCLES);
 	test_pmu_event_snapshot(SBI_PMU_HW_INSTRUCTIONS);
 
@@ -500,7 +500,7 @@ static void test_pmu_events_overflow(void)
 {
 	int num_counters = 0, i = 0;
 
-	/* Verify presence of SBI PMU and minimum requrired SBI version */
+	/* Verify presence of SBI PMU and minimum required SBI version */
 	verify_sbi_requirement_assert();
 
 	snapshot_set_shmem(snapshot_gpa, 0);
-- 
2.34.1
[PATCH 5/6] selftests: kvm: s390: fixed spelling mistake in output
Posted by Soham Metha 1 month, 2 weeks ago 
found/fixed the following typo

- avaialable -> available

in `tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c`

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c b/tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c
index 27255880dabd..aded795d42be 100644
--- a/tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c
+++ b/tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c
@@ -291,7 +291,7 @@ int main(int argc, char *argv[])
 			ksft_test_result_pass("%s\n", testlist[idx].subfunc_name);
 			free(array);
 		} else {
-			ksft_test_result_skip("%s feature is not avaialable\n",
+			ksft_test_result_skip("%s feature is not available\n",
 					      testlist[idx].subfunc_name);
 		}
 	}
-- 
2.34.1
Re: [PATCH 5/6] selftests: kvm: s390: fixed spelling mistake in output
Posted by David Hildenbrand 1 month, 2 weeks ago 
On 15.08.25 02:18, Soham Metha wrote:
> found/fixed the following typo
> 
> - avaialable -> available
> 
> in `tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c`
> 
> Signed-off-by: Soham Metha <sohammetha01@gmail.com>
> ---

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers

David / dhildenb
[PATCH 6/6] selftests: net: tcp_ao: fix spelling mistake in comments
Posted by Soham Metha 1 month, 2 weeks ago 
found/fixed the following typos

- requries -> requires

in `tools/testing/selftests/safesetid/safesetid-test.c`

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 tools/testing/selftests/safesetid/safesetid-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/safesetid/safesetid-test.c b/tools/testing/selftests/safesetid/safesetid-test.c
index eb9bf0aee951..80f736d545a9 100644
--- a/tools/testing/selftests/safesetid/safesetid-test.c
+++ b/tools/testing/selftests/safesetid/safesetid-test.c
@@ -19,7 +19,7 @@
 
 /*
  * NOTES about this test:
- * - requries libcap-dev to be installed on test system
+ * - requires libcap-dev to be installed on test system
  * - requires securityfs to me mounted at /sys/kernel/security, e.g.:
  * mount -n -t securityfs -o nodev,noexec,nosuid securityfs /sys/kernel/security
  * - needs CONFIG_SECURITYFS and CONFIG_SAFESETID to be enabled
-- 
2.34.1

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.