[PATCH 06/13] soc: amlogic: clk-measure: Unify the compatible property

Chuan Liu via B4 Relay posted 13 patches 1 month, 2 weeks ago
[PATCH 06/13] soc: amlogic: clk-measure: Unify the compatible property
Posted by Chuan Liu via B4 Relay 1 month, 2 weeks ago
From: Chuan Liu <chuan.liu@amlogic.com>

The clk-measure IPs across Amlogic SoCs have minimal differences, so
they can be managed with a unified compatible property.

Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
 drivers/soc/amlogic/meson-clk-measure.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
index 4d91d463d2a5..6927f87b99cc 100644
--- a/drivers/soc/amlogic/meson-clk-measure.c
+++ b/drivers/soc/amlogic/meson-clk-measure.c
@@ -292,28 +292,7 @@ static int meson_msr_probe(struct platform_device *pdev)
 
 static const struct of_device_id meson_msr_match_table[] = {
 	{
-		.compatible = "amlogic,meson-gx-clk-measure",
-	},
-	{
-		.compatible = "amlogic,meson8-clk-measure",
-	},
-	{
-		.compatible = "amlogic,meson8b-clk-measure",
-	},
-	{
-		.compatible = "amlogic,meson-axg-clk-measure",
-	},
-	{
-		.compatible = "amlogic,meson-g12a-clk-measure",
-	},
-	{
-		.compatible = "amlogic,meson-sm1-clk-measure",
-	},
-	{
-		.compatible = "amlogic,c3-clk-measure",
-	},
-	{
-		.compatible = "amlogic,s4-clk-measure",
+		.compatible = "amlogic,clk-measure",
 	},
 	{ /* sentinel */ }
 };

-- 
2.42.0
Re: [PATCH 06/13] soc: amlogic: clk-measure: Unify the compatible property
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On Fri, Aug 15, 2025 at 04:37:32PM +0800, Chuan Liu wrote:
> The clk-measure IPs across Amlogic SoCs have minimal differences, so
> they can be managed with a unified compatible property.
> 
> Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
> ---
>  drivers/soc/amlogic/meson-clk-measure.c | 23 +----------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)
> 
> diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
> index 4d91d463d2a5..6927f87b99cc 100644
> --- a/drivers/soc/amlogic/meson-clk-measure.c
> +++ b/drivers/soc/amlogic/meson-clk-measure.c
> @@ -292,28 +292,7 @@ static int meson_msr_probe(struct platform_device *pdev)
>  
>  static const struct of_device_id meson_msr_match_table[] = {
>  	{
> -		.compatible = "amlogic,meson-gx-clk-measure",

NAK, ABI break, obviously.

Don't ever send patches from your downstream tree but read the rules
ALREADY DOCUMENTED in upstream Linux kerenl and adjust to this process.

Did you read writing bindings?

Best regards,
Krzysztof