soc: amlogic: clk-measure: Add more SoCs to support clk-measure

[PATCH 05/13] dt-bindings: soc: amlogic: Unify the compatible property for clk-measure

Posted by Chuan Liu via B4 Relay 1 month, 2 weeks ago

From: Chuan Liu <chuan.liu@amlogic.com>

The clk-measure IPs across Amlogic SoCs have minimal differences, so
they can be managed with a unified compatible property.

Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
 .../bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
index 1c9d37eef5f0..a7927acde2fe 100644
--- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
+++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
@@ -15,15 +15,7 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - amlogic,meson-gx-clk-measure
-      - amlogic,meson8-clk-measure
-      - amlogic,meson8b-clk-measure
-      - amlogic,meson-axg-clk-measure
-      - amlogic,meson-g12a-clk-measure
-      - amlogic,meson-sm1-clk-measure
-      - amlogic,c3-clk-measure
-      - amlogic,s4-clk-measure
+    const: amlogic,clk-measure
 
   reg:
     maxItems: 1
@@ -67,7 +59,7 @@ examples:
      * offsets.
      */
     clock-measure@8758 {
-        compatible = "amlogic,meson-gx-clk-measure";
+        compatible = "amlogic,clk-measure";
         reg = <0x8758 0x10>;
         clkmsr-indices = <0>,
                          <1>,
@@ -82,7 +74,7 @@ examples:
      * Example 2: clk-measure uses V2 version register address offsets.
      */
     clock-measure@48000 {
-        compatible = "amlogic,c3-clk-measure";
+        compatible = "amlogic,clk-measure";
         reg = <0x48000 0x1c>;
         clkmsr-reg-v2;
         clkmsr-indices = <0>,

-- 
2.42.0

Re: [PATCH 05/13] dt-bindings: soc: amlogic: Unify the compatible property for clk-measure

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On Fri, Aug 15, 2025 at 04:37:31PM +0800, Chuan Liu wrote:
> The clk-measure IPs across Amlogic SoCs have minimal differences, so
> they can be managed with a unified compatible property.
> 
> Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
> ---
>  .../bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> index 1c9d37eef5f0..a7927acde2fe 100644
> --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> @@ -15,15 +15,7 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - amlogic,meson-gx-clk-measure
> -      - amlogic,meson8-clk-measure
> -      - amlogic,meson8b-clk-measure
> -      - amlogic,meson-axg-clk-measure
> -      - amlogic,meson-g12a-clk-measure
> -      - amlogic,meson-sm1-clk-measure
> -      - amlogic,c3-clk-measure
> -      - amlogic,s4-clk-measure
> +    const: amlogic,clk-measure

Obviously NAK, cannot stress more how wrong your approach is. It defies
all rules for writing bindings.

Best regards,
Krzysztof