power: supply: use max() to improve code

[PATCH] power: supply: use max() to improve code

Posted by Qianfeng Rong 1 month, 2 weeks ago

Use max() to reduce the code in cw_battery_get_property() and improve
its readability.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
 drivers/power/supply/cw2015_battery.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index f63c3c410451..afc607fee5c9 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -506,10 +506,7 @@ static int cw_battery_get_property(struct power_supply *psy,
 
 	case POWER_SUPPLY_PROP_CHARGE_FULL:
 	case POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN:
-		if (cw_bat->battery->charge_full_design_uah > 0)
-			val->intval = cw_bat->battery->charge_full_design_uah;
-		else
-			val->intval = 0;
+		val->intval = max(cw_bat->battery->charge_full_design_uah, 0);
 		break;
 
 	case POWER_SUPPLY_PROP_CHARGE_NOW:
-- 
2.34.1

Re: [PATCH] power: supply: use max() to improve code

Posted by Sebastian Reichel 3 weeks, 6 days ago

On Thu, 14 Aug 2025 22:36:53 +0800, Qianfeng Rong wrote:
> Use max() to reduce the code in cw_battery_get_property() and improve
> its readability.
> 
> 

Applied, thanks!

[1/1] power: supply: use max() to improve code
      commit: d48d4e4f141b38944da3b0a9c21ce6828ec31d83

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>