[v2] Revise Meta Santabarbara devicetree

[PATCH v2 0/4] Revise Meta Santabarbara devicetree

Posted by Fred Chen 1 month, 3 weeks ago

Summary:
Revise linux device tree entry related to Meta (Facebook) Santabarbara.

Change log
v1 -> v2:
  - add 'bmc_ready_noled' LED and update commit message
  - add sgpio line name for leak detection
v1:
  - add sensor nodes for extension board
  - add mctp node for NIC
  - adjust LED configuration

Fred Chen (4):
  ARM: dts: aspeed: santabarbara: add sensor support for extension
    boards
  ARM: dts: aspeed: santabarbara: Enable MCTP for frontend NIC
  ARM: dts: aspeed: santabarbara: Adjust LED configuration
  ARM: dts: aspeed: santabarbara: add sgpio line name for leak detection

 .../aspeed-bmc-facebook-santabarbara.dts      | 857 +++++++++++++++++-
 1 file changed, 853 insertions(+), 4 deletions(-)

-- 
2.49.0

Re: [PATCH v2 0/4] Revise Meta Santabarbara devicetree

Posted by Rob Herring (Arm) 1 month, 2 weeks ago

On Thu, 14 Aug 2025 21:16:56 +0800, Fred Chen wrote:
> Summary:
> Revise linux device tree entry related to Meta (Facebook) Santabarbara.
> 
> Change log
> v1 -> v2:
>   - add 'bmc_ready_noled' LED and update commit message
>   - add sgpio line name for leak detection
> v1:
>   - add sensor nodes for extension board
>   - add mctp node for NIC
>   - adjust LED configuration
> 
> Fred Chen (4):
>   ARM: dts: aspeed: santabarbara: add sensor support for extension
>     boards
>   ARM: dts: aspeed: santabarbara: Enable MCTP for frontend NIC
>   ARM: dts: aspeed: santabarbara: Adjust LED configuration
>   ARM: dts: aspeed: santabarbara: add sgpio line name for leak detection
> 
>  .../aspeed-bmc-facebook-santabarbara.dts      | 857 +++++++++++++++++-
>  1 file changed, 853 insertions(+), 4 deletions(-)
> 
> --
> 2.49.0
> 
> 
> 

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.17-rc1-9-g8e4021078863 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for 20250814131706.1567067-1-fredchen.openbmc@gmail.com:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dtb: mctp@10 (mctp-i2c-controller): 'label' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/net/mctp-i2c-controller.yaml#

Re: [PATCH v2 0/4] Revise Meta Santabarbara devicetree

Posted by Andrew Jeffery 1 month ago

Hi Fred,

On Fri, 2025-08-15 at 16:19 -0500, Rob Herring (Arm) wrote:
> 
> On Thu, 14 Aug 2025 21:16:56 +0800, Fred Chen wrote:
> > Summary:
> > Revise linux device tree entry related to Meta (Facebook) Santabarbara.
> > 
> > Change log
> > v1 -> v2:
> >   - add 'bmc_ready_noled' LED and update commit message
> >   - add sgpio line name for leak detection
> > v1:
> >   - add sensor nodes for extension board
> >   - add mctp node for NIC
> >   - adjust LED configuration
> > 
> > Fred Chen (4):
> >   ARM: dts: aspeed: santabarbara: add sensor support for extension
> >     boards
> >   ARM: dts: aspeed: santabarbara: Enable MCTP for frontend NIC
> >   ARM: dts: aspeed: santabarbara: Adjust LED configuration
> >   ARM: dts: aspeed: santabarbara: add sgpio line name for leak detection
> > 
> >  .../aspeed-bmc-facebook-santabarbara.dts      | 857 +++++++++++++++++-
> >  1 file changed, 853 insertions(+), 4 deletions(-)
> > 
> > --
> > 2.49.0
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/v6.17-rc1-9-g8e4021078863 (exact match)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for 20250814131706.1567067-1-fredchen.openbmc@gmail.com:
> 
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dtb: mctp@10 (mctp-i2c-controller): 'label' does not match any of the regexes: '^pinctrl-[0-9]+$'
>         from schema $id: http://devicetree.org/schemas/net/mctp-i2c-controller.yaml#
> 

Can you please address this warning and send v3? Check that it no-
longer appears after you fix the dts. You can test it with the command
suggested above. More thoughts here:

https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/

Thanks,

Andrew